* [PATCH] Make assert-valid-graph public
@ 2021-02-18 10:37 Andrew Tropin
2021-02-18 18:19 ` [bug#46619] Fwd: " Andrew Tropin
2021-02-18 18:22 ` Andrew Tropin
0 siblings, 2 replies; 5+ messages in thread
From: Andrew Tropin @ 2021-02-18 10:37 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 197 bytes --]
I would like to reuse this function for home-shepherd-service for `guix
home` I'm currently implementing. It seems reasonable to make this
function public instead of copying or reimplementing it.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: assert-valid-graph visibility patch --]
[-- Type: text/x-patch, Size: 731 bytes --]
From ffc244f5845996bf4b0365024ac866c86cef81df Mon Sep 17 00:00:00 2001
From: Andrew Tropin <andrew@trop.in>
Date: Thu, 18 Feb 2021 13:30:22 +0300
Subject: [PATCH] gnu: services: shepherd: Make assert-valid-graph public
---
gnu/services/shepherd.scm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/gnu/services/shepherd.scm b/gnu/services/shepherd.scm
index e2ec59f5aa..38b35b6154 100644
--- a/gnu/services/shepherd.scm
+++ b/gnu/services/shepherd.scm
@@ -73,7 +73,9 @@
shepherd-service-back-edges
shepherd-service-upgrade
- user-processes-service-type))
+ user-processes-service-type
+
+ assert-valid-graph))
;;; Commentary:
;;;
--
2.30.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#46619] Fwd: [PATCH] Make assert-valid-graph public
2021-02-18 10:37 [PATCH] Make assert-valid-graph public Andrew Tropin
@ 2021-02-18 18:19 ` Andrew Tropin
2021-03-03 13:22 ` bug#46619: " Ludovic Courtès
2021-02-18 18:22 ` Andrew Tropin
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Tropin @ 2021-02-18 18:19 UTC (permalink / raw)
To: 46619
[-- Attachment #1: Type: text/plain, Size: 243 bytes --]
I would like to reuse assert-valid-graph function for home-shepherd-service
for `guix home` I'm currently implementing. It seems reasonable to make this
function public instead of copying or reimplementing it.
--
Best regards,
Andrew Tropin
[-- Attachment #2: 0001-gnu-services-shepherd-Make-assert-valid-graph-public.patch --]
[-- Type: application/x-patch, Size: 758 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Make assert-valid-graph public
2021-02-18 10:37 [PATCH] Make assert-valid-graph public Andrew Tropin
2021-02-18 18:19 ` [bug#46619] Fwd: " Andrew Tropin
@ 2021-02-18 18:22 ` Andrew Tropin
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Tropin @ 2021-02-18 18:22 UTC (permalink / raw)
To: guix-devel
Sent to the this mailing list by mistake, please ignore it. Forwarded
to guix-patches.
On Thu, Feb 18, 2021 at 1:37 PM Andrew Tropin <andrew@trop.in> wrote:
>
> I would like to reuse this function for home-shepherd-service for `guix
> home` I'm currently implementing. It seems reasonable to make this
> function public instead of copying or reimplementing it.
>
--
Best regards,
Andrew Tropin
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#46619: [PATCH] Make assert-valid-graph public
2021-02-18 18:19 ` [bug#46619] Fwd: " Andrew Tropin
@ 2021-03-03 13:22 ` Ludovic Courtès
2021-03-03 14:40 ` [bug#46619] " Andrew Tropin
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2021-03-03 13:22 UTC (permalink / raw)
To: Andrew Tropin; +Cc: 46619-done
Hi Andrew,
Andrew Tropin <andrew@trop.in> skribis:
> From ffc244f5845996bf4b0365024ac866c86cef81df Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew@trop.in>
> Date: Thu, 18 Feb 2021 13:30:22 +0300
> Subject: [PATCH] gnu: services: shepherd: Make assert-valid-graph public
>
> ---
> gnu/services/shepherd.scm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
I added a commit log and pushed as
63bee8f0addc95c81426199c9fbf1d0bcf7f1450.
As mentioned on IRC, note that this kind of procedure doesn’t make for a
great API, which is why it’s usually kept private. Second, if a
procedure like this one doesn’t have any user in Guix proper, it could
well be removed or changed incompatibly, so beware.
In this case, I think it’s acceptable to make it public though.
Thanks and apologies for the delay!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#46619] [PATCH] Make assert-valid-graph public
2021-03-03 13:22 ` bug#46619: " Ludovic Courtès
@ 2021-03-03 14:40 ` Andrew Tropin
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Tropin @ 2021-03-03 14:40 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 46619-done
> As mentioned on IRC, note that this kind of procedure doesn\u2019t make for a
> great API, which is why it's usually kept private. Second, if a
> procedure like this one doesn't have any user in Guix proper, it could
> well be removed or changed incompatibly, so beware.
Took into account. Hope, it will be used by one small guix's module
someday) Plan to propose to include `guix home` in guix
repo. https://git.sr.ht/~abcdw/rde/tree/master/item/gnu
>
> In this case, I think it's acceptable to make it public though.
>
> Thanks and apologies for the delay!
>
> Ludo'.
Thank you for all your work!
--
Best regards,
Andrew Tropin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-03 14:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18 10:37 [PATCH] Make assert-valid-graph public Andrew Tropin
2021-02-18 18:19 ` [bug#46619] Fwd: " Andrew Tropin
2021-03-03 13:22 ` bug#46619: " Ludovic Courtès
2021-03-03 14:40 ` [bug#46619] " Andrew Tropin
2021-02-18 18:22 ` Andrew Tropin
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.