* Re: branch master updated: services: cuirass: Add a no-publish argument.
[not found] <20210812110850.6645.33726@vcs0.savannah.gnu.org>
@ 2021-08-12 21:22 ` Ludovic Courtès
2021-08-13 11:48 ` Mathieu Othacehe
0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2021-08-12 21:22 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: guix-devel
Hi!
guix-commits@gnu.org skribis:
> commit d128c6fd33f46ec4e2d0ef352d20a858c377bf6f
> Author: Mathieu Othacehe <othacehe@gnu.org>
> AuthorDate: Thu Aug 12 12:58:34 2021 +0200
>
> services: cuirass: Add a no-publish argument.
>
> * gnu/services/cuirass.scm (<cuirass-remote-server-configuration>): Add a
> no-publish? field.
> (cuirass-shepherd-service): Honor it.
> * doc/guix.texi (Cuirass remote building): Document it.
[...]
> +++ b/gnu/services/cuirass.scm
> @@ -72,6 +72,8 @@
> (default "/var/log/cuirass-remote-server.log"))
> (cache cuirass-remote-server-configuration-cache ;string
> (default "/var/cache/cuirass/remote/"))
> + (no-publish? cuirass-remote-server-configuration-no-publish? ;boolean
> + (default #f))
Nitpick: as a rule of thumb, I personally avoid negative options,
otherwise discussions easily end up with phrases like “disable
no-publish” and then you have to think twice before you’re confident
about the meaning. :-)
So I’d suggest turning that into ‘publish?’, defaulting to #t.
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: branch master updated: services: cuirass: Add a no-publish argument.
2021-08-12 21:22 ` branch master updated: services: cuirass: Add a no-publish argument Ludovic Courtès
@ 2021-08-13 11:48 ` Mathieu Othacehe
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Othacehe @ 2021-08-13 11:48 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
Hey,
> So I’d suggest turning that into ‘publish?’, defaulting to #t.
Yeah, you're completely right, I reversed the logic with:
cfd2442488971420289a12d5ca8f07816e1149bf.
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-13 11:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210812110850.6645.33726@vcs0.savannah.gnu.org>
2021-08-12 21:22 ` branch master updated: services: cuirass: Add a no-publish argument Ludovic Courtès
2021-08-13 11:48 ` Mathieu Othacehe
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.