all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#60706] [PATCH] gnu: hwloc: Update to 2.9.0.
@ 2023-01-10  9:04 Ludovic Courtès
  2023-01-10 16:34 ` Maxim Cournoyer
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2023-01-10  9:04 UTC (permalink / raw)
  To: 60706; +Cc: Ludovic Courtès

From: Ludovic Courtès <ludovic.courtes@inria.fr>

* gnu/packages/mpi.scm (hwloc-2): Update to 2.9.0.
[arguments]: Add 'skip-test-that-requires-/sys' phase.
---
 gnu/packages/mpi.scm | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/mpi.scm b/gnu/packages/mpi.scm
index af2409aeab..56b7d04209 100644
--- a/gnu/packages/mpi.scm
+++ b/gnu/packages/mpi.scm
@@ -1,6 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2014, 2015, 2018, 2019 Eric Bavier <bavier@member.fsf.org>
-;;; Copyright © 2014-2022 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2014-2023 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2014 Ian Denhardt <ian@zenhack.net>
 ;;; Copyright © 2016 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2017 Dave Love <fx@gnu.org>
@@ -143,7 +143,7 @@ (define-public hwloc-2
   ;; Note: 2.x isn't the default yet, see above.
   (package
     (inherit hwloc-1)
-    (version "2.8.0")
+    (version "2.9.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://download.open-mpi.org/release/hwloc/v"
@@ -151,7 +151,7 @@ (define-public hwloc-2
                                   "/hwloc-" version ".tar.bz2"))
               (sha256
                (base32
-                "1ha23yqfx9kfxm5fcj9m0fnyf0r2k6p4k88xxqishclcsky752il"))))
+                "11v8hnl6fdsdbm3wnz5gg88f2ghixjyl7jlfmywj293ab5iyjw10"))))
 
     ;; libnuma is no longer needed.
     (inputs (modify-inputs (package-inputs hwloc-1)
@@ -167,6 +167,10 @@ (define-public hwloc-2
                (substitute* "tests/hwloc/linux-libnuma.c"
                  (("numa_available\\(\\)")
                   "-1"))))
+           (add-before 'check 'skip-test-that-requires-/sys
+             (lambda _
+               ;; 'test-gather-topology.sh' requires /sys as of 2.9.0; skip it.
+               (setenv "HWLOC_TEST_GATHER_TOPOLOGY" "0")))
            (add-before 'check 'skip-test-that-fails-on-qemu
              (lambda _
                ;; Skip test that fails on emulated hardware due to QEMU bug:

base-commit: 84f117f49587b608b287827793b1b8036d2cff7f
-- 
2.38.1





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#60706] [PATCH] gnu: hwloc: Update to 2.9.0.
  2023-01-10  9:04 [bug#60706] [PATCH] gnu: hwloc: Update to 2.9.0 Ludovic Courtès
@ 2023-01-10 16:34 ` Maxim Cournoyer
  2023-01-10 17:06   ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Maxim Cournoyer @ 2023-01-10 16:34 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 60706, Ludovic Courtès

Hi,

Ludovic Courtès <ludo@gnu.org> writes:

> From: Ludovic Courtès <ludovic.courtes@inria.fr>
>
> * gnu/packages/mpi.scm (hwloc-2): Update to 2.9.0.
> [arguments]: Add 'skip-test-that-requires-/sys' phase.
> ---
>  gnu/packages/mpi.scm | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/mpi.scm b/gnu/packages/mpi.scm
> index af2409aeab..56b7d04209 100644
> --- a/gnu/packages/mpi.scm
> +++ b/gnu/packages/mpi.scm
> @@ -1,6 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2014, 2015, 2018, 2019 Eric Bavier <bavier@member.fsf.org>
> -;;; Copyright © 2014-2022 Ludovic Courtès <ludo@gnu.org>
> +;;; Copyright © 2014-2023 Ludovic Courtès <ludo@gnu.org>
>  ;;; Copyright © 2014 Ian Denhardt <ian@zenhack.net>
>  ;;; Copyright © 2016 Andreas Enge <andreas@enge.fr>
>  ;;; Copyright © 2017 Dave Love <fx@gnu.org>

Nitpick: arguably not a copyrightable change (< 10 lines of additions).

> @@ -143,7 +143,7 @@ (define-public hwloc-2
>    ;; Note: 2.x isn't the default yet, see above.
>    (package
>      (inherit hwloc-1)
> -    (version "2.8.0")
> +    (version "2.9.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "https://download.open-mpi.org/release/hwloc/v"
> @@ -151,7 +151,7 @@ (define-public hwloc-2
>                                    "/hwloc-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "1ha23yqfx9kfxm5fcj9m0fnyf0r2k6p4k88xxqishclcsky752il"))))
> +                "11v8hnl6fdsdbm3wnz5gg88f2ghixjyl7jlfmywj293ab5iyjw10"))))
>  
>      ;; libnuma is no longer needed.
>      (inputs (modify-inputs (package-inputs hwloc-1)
> @@ -167,6 +167,10 @@ (define-public hwloc-2
>                 (substitute* "tests/hwloc/linux-libnuma.c"
>                   (("numa_available\\(\\)")
>                    "-1"))))
> +           (add-before 'check 'skip-test-that-requires-/sys
> +             (lambda _
> +               ;; 'test-gather-topology.sh' requires /sys as of 2.9.0; skip it.
> +               (setenv "HWLOC_TEST_GATHER_TOPOLOGY" "0")))
>             (add-before 'check 'skip-test-that-fails-on-qemu
>               (lambda _
>                 ;; Skip test that fails on emulated hardware due to QEMU bug:

Otherwise LGTM.

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#60706] [PATCH] gnu: hwloc: Update to 2.9.0.
  2023-01-10 16:34 ` Maxim Cournoyer
@ 2023-01-10 17:06   ` Ludovic Courtès
  2023-01-27 17:19     ` bug#60706: " Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2023-01-10 17:06 UTC (permalink / raw)
  To: Maxim Cournoyer; +Cc: 60706

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> From: Ludovic Courtès <ludovic.courtes@inria.fr>
>>
>> * gnu/packages/mpi.scm (hwloc-2): Update to 2.9.0.
>> [arguments]: Add 'skip-test-that-requires-/sys' phase.
>> ---
>>  gnu/packages/mpi.scm | 10 +++++++---
>>  1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/gnu/packages/mpi.scm b/gnu/packages/mpi.scm
>> index af2409aeab..56b7d04209 100644
>> --- a/gnu/packages/mpi.scm
>> +++ b/gnu/packages/mpi.scm
>> @@ -1,6 +1,6 @@
>>  ;;; GNU Guix --- Functional package management for GNU
>>  ;;; Copyright © 2014, 2015, 2018, 2019 Eric Bavier <bavier@member.fsf.org>
>> -;;; Copyright © 2014-2022 Ludovic Courtès <ludo@gnu.org>
>> +;;; Copyright © 2014-2023 Ludovic Courtès <ludo@gnu.org>
>>  ;;; Copyright © 2014 Ian Denhardt <ian@zenhack.net>
>>  ;;; Copyright © 2016 Andreas Enge <andreas@enge.fr>
>>  ;;; Copyright © 2017 Dave Love <fx@gnu.org>
>
> Nitpick: arguably not a copyrightable change (< 10 lines of additions).

Riiight.

> Otherwise LGTM.

Thanks for taking a look!

Let’s see if <https://qa.guix.gnu.org/issue/60706> can tell us more
about dependents and non-x86 architectures…

Ludo’.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#60706: [PATCH] gnu: hwloc: Update to 2.9.0.
  2023-01-10 17:06   ` Ludovic Courtès
@ 2023-01-27 17:19     ` Ludovic Courtès
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2023-01-27 17:19 UTC (permalink / raw)
  To: Maxim Cournoyer; +Cc: 60706-done

Ludovic Courtès <ludovic.courtes@inria.fr> skribis:

> Let’s see if <https://qa.guix.gnu.org/issue/60706> can tell us more
> about dependents and non-x86 architectures…

Pushed as 317ea0458927810754ab154228ace04ff7bab717 with a fix for the
issues qa.guix found in dependent packages.

Ludo’.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-01-27 17:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-10  9:04 [bug#60706] [PATCH] gnu: hwloc: Update to 2.9.0 Ludovic Courtès
2023-01-10 16:34 ` Maxim Cournoyer
2023-01-10 17:06   ` Ludovic Courtès
2023-01-27 17:19     ` bug#60706: " Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.