From: Tobias Geerinckx-Rice <me@tobias.gr>
To: 32055-done@debbugs.gnu.org
Subject: bug#32055: [PATCH 0/2] Add sqlcrush.
Date: Wed, 22 Aug 2018 00:53:56 +0200 [thread overview]
Message-ID: <87r2irqqkb.fsf@tobias.gr> (raw)
In-Reply-To: <87bmbmoghm.fsf@lapdog.tobias.gr>
Ludo',
This got buried after the holdays. Thanks for the review!
Ludovic Courtès wrote:
> Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:
[...]
>> + (propagated-inputs
>> + `(("python-cryptography" ,python-cryptography)
>> + ("python-psycopg2" ,python-psycopg2)
>> + ("python-pymysql" ,python-pymysql)
>> + ("python-sqlalchemy" ,python-sqlalchemy)))
[...]
> If it’s an application rather than a library, then perhaps we
> don’t need
> to propagate these?
Agreed.
>> + (synopsis "Pure-Python MySQL Driver")
>
> Nitpick: "driver" (lowercase).
>
> Otherwise LGTM, thanks!
Pushed with the suggested changes as 311f06c et al.
Kind regards,
T G-R
prev parent reply other threads:[~2018-08-21 22:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 21:09 [bug#32055] [PATCH 0/2] Add sqlcrush Tobias Geerinckx-Rice
2018-07-04 21:15 ` [bug#32055] [PATCH 1/2] gnu: Add python-pymysql Tobias Geerinckx-Rice
2018-07-04 21:15 ` [bug#32055] [PATCH 2/2] gnu: Add sqlcrush Tobias Geerinckx-Rice
2018-07-12 21:24 ` Ludovic Courtès
2018-07-12 21:23 ` [bug#32055] [PATCH 1/2] gnu: Add python-pymysql Ludovic Courtès
2018-08-21 22:53 ` Tobias Geerinckx-Rice [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2irqqkb.fsf@tobias.gr \
--to=me@tobias.gr \
--cc=32055-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.