From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41704)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fsFXM-0001p5-RQ
	for guix-patches@gnu.org; Tue, 21 Aug 2018 18:54:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fsFXJ-0003Wm-4g
	for guix-patches@gnu.org; Tue, 21 Aug 2018 18:54:08 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:52112)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fsFXG-0003WQ-8t
	for guix-patches@gnu.org; Tue, 21 Aug 2018 18:54:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fsFXG-0001F7-7C
	for guix-patches@gnu.org; Tue, 21 Aug 2018 18:54:02 -0400
Subject: bug#32055: [PATCH 0/2] Add sqlcrush.
References: <87bmbmoghm.fsf@lapdog.tobias.gr>
In-Reply-To: <87bmbmoghm.fsf@lapdog.tobias.gr>
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.32055.D32055.15348920234744.done@debbugs.gnu.org>
From: Tobias Geerinckx-Rice <me@tobias.gr>
Date: Wed, 22 Aug 2018 00:53:56 +0200
Message-ID: <87r2irqqkb.fsf@tobias.gr>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 32055-done@debbugs.gnu.org

Ludo',

This got buried after the holdays. Thanks for the review!

Ludovic Court=C3=A8s wrote:
> Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

[...]

>> +      (propagated-inputs
>> +       `(("python-cryptography" ,python-cryptography)
>> +         ("python-psycopg2" ,python-psycopg2)
>> +         ("python-pymysql" ,python-pymysql)
>> +         ("python-sqlalchemy" ,python-sqlalchemy)))

[...]

> If it=E2=80=99s an application rather than a library, then perhaps we=20
> don=E2=80=99t need
> to propagate these?

Agreed.

>> +    (synopsis "Pure-Python MySQL Driver")
>
> Nitpick: "driver" (lowercase).
>
> Otherwise LGTM, thanks!

Pushed with the suggested changes as 311f06c et al.

Kind regards,

T G-R