all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#36050] [PATCH] gnu: Add emacs-xterm-color
@ 2019-06-02  2:59 Jonathan Frederickson
  2019-06-05 15:27 ` Ludovic Courtès
  2019-06-07  3:40 ` Jonathan Frederickson
  0 siblings, 2 replies; 4+ messages in thread
From: Jonathan Frederickson @ 2019-06-02  2:59 UTC (permalink / raw)
  To: 36050; +Cc: Jonathan Frederickson

* gnu/packages/emacs-xyz.scm: (emacs-xterm-color) new variable.
---
 gnu/packages/emacs-xyz.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 9199b45e40..70dd9e599b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15620,3 +15620,21 @@ verb commands which would are normally destructive (such as deletion) are
 provided.  Those alternative commands are and bound by default to their
 corresponding Evil keys.")
       (license license:expat))))
+
+(define-public emacs-xterm-color
+  (package
+    (name "emacs-xterm-color")
+    (version "20190519.1243")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://melpa.org/packages/xterm-color-"
+                    version
+                    ".el"))
+              (sha256
+               (base32 "0cdl8cpqv3x23y4vpfib4kjncy9xslvka04gpszdnasf7av5g8g7"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/atomontage/xterm-color")
+    (synopsis "ANSI & xterm-256 color text property translator for Emacs")
+    (description "@code{xterm-color.el} is an ANSI control sequence to text-property translator")
+    (license license:bsd-2)))
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#36050] [PATCH] gnu: Add emacs-xterm-color
  2019-06-02  2:59 [bug#36050] [PATCH] gnu: Add emacs-xterm-color Jonathan Frederickson
@ 2019-06-05 15:27 ` Ludovic Courtès
  2019-06-07  3:40 ` Jonathan Frederickson
  1 sibling, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2019-06-05 15:27 UTC (permalink / raw)
  To: Jonathan Frederickson; +Cc: 36050

Hi Jonathan,

Jonathan Frederickson <jonathan@terracrypt.net> skribis:

> * gnu/packages/emacs-xyz.scm: (emacs-xterm-color) new variable.

[...]

> +              (uri (string-append
> +                    "https://melpa.org/packages/xterm-color-"
> +                    version
> +                    ".el"))

melpa.org URLs are not stable: files get modified in place.  For that
reason, we usually refer directly to upstream VCS repositories.

Could you modify the patch accordingly?

> +    (synopsis "ANSI & xterm-256 color text property translator for Emacs")
> +    (description "@code{xterm-color.el} is an ANSI control sequence to text-property translator")

Please add a period at the end of the sentence.  :-)

Thank you,
Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#36050] [PATCH] gnu: Add emacs-xterm-color
  2019-06-02  2:59 [bug#36050] [PATCH] gnu: Add emacs-xterm-color Jonathan Frederickson
  2019-06-05 15:27 ` Ludovic Courtès
@ 2019-06-07  3:40 ` Jonathan Frederickson
  2019-06-07  7:30   ` bug#36050: " Ludovic Courtès
  1 sibling, 1 reply; 4+ messages in thread
From: Jonathan Frederickson @ 2019-06-07  3:40 UTC (permalink / raw)
  To: 36050; +Cc: Jonathan Frederickson

* gnu/packages/emacs-xyz.scm: (emacs-xterm-color) new variable.
---
 gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 9199b45e40..3224883969 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15620,4 +15620,23 @@ verb commands which would are normally destructive (such as deletion) are
 provided.  Those alternative commands are and bound by default to their
 corresponding Evil keys.")
       (license license:expat))))
+
+(define-public emacs-xterm-color
+  (let ((commit "a452ab38a7cfae97078062ff8885b5d74fd1e5a6")
+        (version "1.8")
+        (revision "1"))
+    (package
+      (name "emacs-xterm-color")
+      (version (git-version version revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/atomontage/xterm-color.git")
+                      (commit commit)))
+                (sha256
+                 (base32 "02kpajb993yshhjhsizpfcbrcndyzkf4dqfipifhxxng50dhp95i"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/atomontage/xterm-color")
+      (synopsis "ANSI & xterm-256 color text property translator for Emacs")
+      (description "@code{xterm-color.el} is an ANSI control sequence to text-property translator.")
+      (license license:bsd-2))))
-- 

Here's a revised version - I saw there were a few different
conventions for packages with git sources, but I figured using both a
numeric version for the version I intended and a git hash for
stability would be desirable.

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#36050: [PATCH] gnu: Add emacs-xterm-color
  2019-06-07  3:40 ` Jonathan Frederickson
@ 2019-06-07  7:30   ` Ludovic Courtès
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2019-06-07  7:30 UTC (permalink / raw)
  To: Jonathan Frederickson; +Cc: 36050-done

Hi,

Jonathan Frederickson <jonathan@terracrypt.net> skribis:

> * gnu/packages/emacs-xyz.scm: (emacs-xterm-color) new variable.

Applied, thanks!

I followed up with a commit to address ‘guix lint’ warnings.

Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-06-07  7:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-02  2:59 [bug#36050] [PATCH] gnu: Add emacs-xterm-color Jonathan Frederickson
2019-06-05 15:27 ` Ludovic Courtès
2019-06-07  3:40 ` Jonathan Frederickson
2019-06-07  7:30   ` bug#36050: " Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.