all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: Cross-compilation broken on canonical packages.
Date: Mon, 24 Feb 2020 17:11:57 +0100	[thread overview]
Message-ID: <87r1ykj776.fsf@gnu.org> (raw)
In-Reply-To: <8736bg5coz.fsf@gmail.com> (Mathieu Othacehe's message of "Wed, 12 Feb 2020 11:20:44 +0100")

Hi!

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> I think you're right! Pushed it as
> f30d84d32db0f4f6cb84e139868e1727a7dc0a51 on core-updates.
>
> Now the good news is that we are one patch away from having core-updates
> to cross-compile bare-bones.tmpl system! This is the patch attached,
> we've been discussing it here[1] without reaching a conclusion.

Yay!

> From f5d773dc0a627ba6059f1025189d33a9e0d083b5 Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <m.othacehe@gmail.com>
> Date: Sat, 28 Dec 2019 21:29:06 +0100
> Subject: [PATCH 1/2] gexp: Default to current target.
>
> * guix/gexp.scm (lower-object): Set target argument to 'current by default and
> look for the current target system at bind time if needed,
> (gexp->file): ditto,
> (gexp->script): ditto.

Do we need to do it for ‘lower-object’?  I think that one is (almost)
always called from a gexp compiler where it’s explicitly passed ‘system’
and ‘target’.

Also, a test or two would be welcome as it’s easy to break it without
noticing.

Otherwise LGTM, thank you, and sorry for the delay!

Ludo’.

  reply	other threads:[~2020-02-24 16:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-14 11:49 Cross-compilation broken on canonical packages Mathieu Othacehe
2019-12-14 11:52 ` Mathieu Othacehe
2019-12-19 16:48   ` Ludovic Courtès
2019-12-22 16:31     ` Mathieu Othacehe
2019-12-30 18:48       ` Ludovic Courtès
2019-12-31  9:55         ` Mathieu Othacehe
2020-01-02 18:07           ` Ludovic Courtès
2020-01-02 22:00             ` Mathieu Othacehe
2020-01-03 12:03               ` Mathieu Othacehe
2020-02-11 13:01                 ` Mathieu Othacehe
2020-02-11 14:04                   ` Ludovic Courtès
2020-02-12 10:20                     ` Mathieu Othacehe
2020-02-24 16:11                       ` Ludovic Courtès [this message]
2020-03-06  9:19                         ` Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1ykj776.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=m.othacehe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.