From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: Re: Cross-compilation broken on canonical packages. Date: Mon, 24 Feb 2020 17:11:57 +0100 Message-ID: <87r1ykj776.fsf@gnu.org> References: <878snff7pv.fsf@gmail.com> <877e2zf7kv.fsf@gmail.com> <871rt0ntvy.fsf@gnu.org> <87fthc9vav.fsf@gmail.com> <87y2ut645u.fsf@gnu.org> <87tv5gbz0o.fsf@gmail.com> <87blrlu3zv.fsf@gnu.org> <877e29v7qu.fsf@gmail.com> <87tv5cwxv1.fsf@gmail.com> <87pnelmg5e.fsf@gmail.com> <878sl943uz.fsf@gnu.org> <8736bg5coz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:38440) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6GKt-0006xe-Cs for guix-devel@gnu.org; Mon, 24 Feb 2020 11:12:00 -0500 In-Reply-To: <8736bg5coz.fsf@gmail.com> (Mathieu Othacehe's message of "Wed, 12 Feb 2020 11:20:44 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Mathieu Othacehe Cc: guix-devel@gnu.org Hi! Mathieu Othacehe skribis: > I think you're right! Pushed it as > f30d84d32db0f4f6cb84e139868e1727a7dc0a51 on core-updates. > > Now the good news is that we are one patch away from having core-updates > to cross-compile bare-bones.tmpl system! This is the patch attached, > we've been discussing it here[1] without reaching a conclusion. Yay! > From f5d773dc0a627ba6059f1025189d33a9e0d083b5 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Sat, 28 Dec 2019 21:29:06 +0100 > Subject: [PATCH 1/2] gexp: Default to current target. > > * guix/gexp.scm (lower-object): Set target argument to 'current by defaul= t and > look for the current target system at bind time if needed, > (gexp->file): ditto, > (gexp->script): ditto. Do we need to do it for =E2=80=98lower-object=E2=80=99? I think that one i= s (almost) always called from a gexp compiler where it=E2=80=99s explicitly passed =E2= =80=98system=E2=80=99 and =E2=80=98target=E2=80=99. Also, a test or two would be welcome as it=E2=80=99s easy to break it witho= ut noticing. Otherwise LGTM, thank you, and sorry for the delay! Ludo=E2=80=99.