* [bug#46234] [PATCH] Add new gopkg.in/yaml.v3
@ 2021-02-01 12:46 Sharlatan Hellseher
[not found] ` <handler.46234.B.161218363110237.ack@debbugs.gnu.org>
2021-06-18 14:42 ` [bug#46234] [PATCH] Add new gopkg.in/yaml.v3 Xinglu Chen
0 siblings, 2 replies; 6+ messages in thread
From: Sharlatan Hellseher @ 2021-02-01 12:46 UTC (permalink / raw)
To: 46234
[-- Attachment #1: Type: text/plain, Size: 355 bytes --]
--
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.
[-- Attachment #2: 0001-gnu-Add-gopkg.in-yaml.v3.patch --]
[-- Type: text/x-patch, Size: 2541 bytes --]
From 31a174054c86fd51e81185d5b2bfcf2ab6bcf208 Mon Sep 17 00:00:00 2001
From: Sharlatan Hellseher <sharlatanus@gmail.com>
Date: Mon, 1 Feb 2021 12:44:15 +0000
Subject: [PATCH] gnu: Add gopkg.in/yaml.v3
* gnu/packages/golang.scm (go-gopkg-in-yml-v3): New variable
---
gnu/packages/golang.scm | 42 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index d34bb1acb7..56843820f0 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -23,6 +23,7 @@
;;; Copyright © 2020 Marius Bakke <marius@gnu.org>
;;; Copyright © 2020 raingloom <raingloom@riseup.net>
;;; Copyright © 2020 Martin Becze <mjbecze@riseup.net>
+;;; Copyright © 2021 Sharlatan Hellseher <sharlatanus@mgail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -2408,6 +2409,47 @@ which satisfies the cron expression.")
values.")
(license license:asl2.0)))
+(define-public go-gopkg-in-yaml-v3
+ (package
+ (name "go-gopkg-in-yaml-v3")
+ (version "3")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://gopkg.in/yaml.v3.git")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "06f4lnrp494wqaygv09dggr2dwf3z2bawqhnlnnwiamg5y787k4g"))))
+ (build-system go-build-system)
+ (arguments
+ '(#:import-path "gopkg.in/yaml.v3"))
+ (native-inputs
+ `(("go-gopkg-in-check-v1" ,go-gopkg-in-check-v1)))
+ (home-page "https://gopkg.in/yaml.v2")
+ (synopsis "YAML reader and writer for the Go language")
+ (description
+ "This package provides a Go library for encode and decode YAML
+values.
+
+v3 specification difference:
+@itemize
+@item YAML 1.1 bools (yes/no, on/off) are supported as long as they are
+being decoded into a typed bool value. Otherwise they behave as a string.
+Booleans in YAML 1.2 are true/false only.
+
+@item Octals encode and decode as 0777 per YAML 1.1, rather than 0o777 as
+specified in YAML 1.2, because most parsers still use the old format. Octals in
+the 0o777 format are supported though, so new files work.
+
+@item Does not support base-60 floats. These are gone from YAML 1.2, and were
+actually never supported by this package as it's clearly a poor choice.
+@end itemize\n")
+
+@end itemize\n")
+ (license license:asl2.0)))
+
(define-public go-github-com-mattn-go-isatty
(package
(name "go-github-com-mattn-go-isatty")
--
2.30.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <handler.46234.B.161218363110237.ack@debbugs.gnu.org>]
* [bug#46234] Acknowledgement ([PATCH] Add new gopkg.in/yaml.v3)
[not found] ` <handler.46234.B.161218363110237.ack@debbugs.gnu.org>
@ 2021-06-13 11:14 ` Sharlatan Hellseher
0 siblings, 0 replies; 6+ messages in thread
From: Sharlatan Hellseher @ 2021-06-13 11:14 UTC (permalink / raw)
To: 46234
Hi Guix team!
Is there anything I may fix in this patch?
go Yaml v3 goes as one of the dependencies of some good packages like
dive and lazygit.
Regards
On Mon, 1 Feb 2021 at 12:48, GNU bug Tracking System
<help-debbugs@gnu.org> wrote:
>
> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
> guix-patches@gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 46234@debbugs.gnu.org.
>
> Please do not send mail to help-debbugs@gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
> --
> 46234: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46234
> GNU Bug Tracking System
> Contact help-debbugs@gnu.org with problems
--
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#46234] [PATCH] Add new gopkg.in/yaml.v3
2021-02-01 12:46 [bug#46234] [PATCH] Add new gopkg.in/yaml.v3 Sharlatan Hellseher
[not found] ` <handler.46234.B.161218363110237.ack@debbugs.gnu.org>
@ 2021-06-18 14:42 ` Xinglu Chen
2021-06-18 19:29 ` Sharlatan Hellseher
1 sibling, 1 reply; 6+ messages in thread
From: Xinglu Chen @ 2021-06-18 14:42 UTC (permalink / raw)
To: Sharlatan Hellseher, 46234
[-- Attachment #1: Type: text/plain, Size: 1815 bytes --]
On Mon, Feb 01 2021, Sharlatan Hellseher wrote:
> +(define-public go-gopkg-in-yaml-v3
> + (package
> + (name "go-gopkg-in-yaml-v3")
> + (version "3")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://gopkg.in/yaml.v3.git")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "06f4lnrp494wqaygv09dggr2dwf3z2bawqhnlnnwiamg5y787k4g"))))
> + (build-system go-build-system)
> + (arguments
> + '(#:import-path "gopkg.in/yaml.v3"))
> + (native-inputs
> + `(("go-gopkg-in-check-v1" ,go-gopkg-in-check-v1)))
> + (home-page "https://gopkg.in/yaml.v2")
^^
Shouldn’t this be “https://gopkg.in/yaml.v3”?
> + (synopsis "YAML reader and writer for the Go language")
> + (description
> + "This package provides a Go library for encode and decode YAML
> +values.
> +
> +v3 specification difference:
> +@itemize
> +@item YAML 1.1 bools (yes/no, on/off) are supported as long as they are
> +being decoded into a typed bool value. Otherwise they behave as a string.
> +Booleans in YAML 1.2 are true/false only.
> +
> +@item Octals encode and decode as 0777 per YAML 1.1, rather than 0o777 as
> +specified in YAML 1.2, because most parsers still use the old format. Octals in
> +the 0o777 format are supported though, so new files work.
> +
> +@item Does not support base-60 floats. These are gone from YAML 1.2, and were
> +actually never supported by this package as it's clearly a poor choice.
> +@end itemize\n")
> +
> +@end itemize\n")
Duplicate lines/syntax error. I don’t think \n is needed either.
Otherwise, LGTM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#46234] [PATCH] Add new gopkg.in/yaml.v3
2021-06-18 14:42 ` [bug#46234] [PATCH] Add new gopkg.in/yaml.v3 Xinglu Chen
@ 2021-06-18 19:29 ` Sharlatan Hellseher
2021-06-19 8:31 ` Xinglu Chen
2021-06-22 8:53 ` bug#46234: " Nicolas Goaziou
0 siblings, 2 replies; 6+ messages in thread
From: Sharlatan Hellseher @ 2021-06-18 19:29 UTC (permalink / raw)
To: Xinglu Chen; +Cc: 46234
[-- Attachment #1: Type: text/plain, Size: 2437 bytes --]
Hi Xinglu,
I've reviewed your comments and updated the patch, thanks for your time!
On Fri, 18 Jun 2021 at 14:42, Xinglu Chen <public@yoctocell.xyz> wrote:
>
> On Mon, Feb 01 2021, Sharlatan Hellseher wrote:
>
> > +(define-public go-gopkg-in-yaml-v3
> > + (package
> > + (name "go-gopkg-in-yaml-v3")
> > + (version "3")
> > + (source
> > + (origin
> > + (method git-fetch)
> > + (uri (git-reference
> > + (url "https://gopkg.in/yaml.v3.git")
> > + (commit (string-append "v" version))))
> > + (file-name (git-file-name name version))
> > + (sha256
> > + (base32 "06f4lnrp494wqaygv09dggr2dwf3z2bawqhnlnnwiamg5y787k4g"))))
> > + (build-system go-build-system)
> > + (arguments
> > + '(#:import-path "gopkg.in/yaml.v3"))
> > + (native-inputs
> > + `(("go-gopkg-in-check-v1" ,go-gopkg-in-check-v1)))
> > + (home-page "https://gopkg.in/yaml.v2")
> ^^
> Shouldn’t this be “https://gopkg.in/yaml.v3”?
>
> > + (synopsis "YAML reader and writer for the Go language")
> > + (description
> > + "This package provides a Go library for encode and decode YAML
> > +values.
> > +
> > +v3 specification difference:
> > +@itemize
> > +@item YAML 1.1 bools (yes/no, on/off) are supported as long as they are
> > +being decoded into a typed bool value. Otherwise they behave as a string.
> > +Booleans in YAML 1.2 are true/false only.
> > +
> > +@item Octals encode and decode as 0777 per YAML 1.1, rather than 0o777 as
> > +specified in YAML 1.2, because most parsers still use the old format. Octals in
> > +the 0o777 format are supported though, so new files work.
> > +
> > +@item Does not support base-60 floats. These are gone from YAML 1.2, and were
> > +actually never supported by this package as it's clearly a poor choice.
> > +@end itemize\n")
> > +
> > +@end itemize\n")
>
> Duplicate lines/syntax error. I don’t think \n is needed either.
>
> Otherwise, LGTM.
--
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.
[-- Attachment #2: 0001-gnu-Add-gopkg.in-yaml.v3.patch --]
[-- Type: text/x-patch, Size: 2531 bytes --]
From 55ccab7fbbd5a1610ce630f17e79db8bdc6b4d79 Mon Sep 17 00:00:00 2001
From: Sharlatan Hellseher <sharlatanus@gmail.com>
Date: Fri, 18 Jun 2021 20:27:27 +0100
Subject: [PATCH] gnu: Add gopkg.in/yaml.v3
* gnu/packages/golang.scm (go-gopkg-in-yml-v3): New variable
---
gnu/packages/golang.scm | 40 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 8c3c81ceda..19a70c7a82 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -25,6 +25,7 @@
;;; Copyright © 2020 Martin Becze <mjbecze@riseup.net>
;;; Copyright © 2021 Ricardo Wurmus <rekado@elephly.net>
;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
+;;; Copyright © 2021 Sharlatan Hellseher <sharlatanus@mgail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -2413,6 +2414,45 @@ which satisfies the cron expression.")
values.")
(license license:asl2.0)))
+(define-public go-gopkg-in-yaml-v3
+ (package
+ (name "go-gopkg-in-yaml-v3")
+ (version "3")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://gopkg.in/yaml.v3.git")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "06f4lnrp494wqaygv09dggr2dwf3z2bawqhnlnnwiamg5y787k4g"))))
+ (build-system go-build-system)
+ (arguments
+ '(#:import-path "gopkg.in/yaml.v3"))
+ (native-inputs
+ `(("go-gopkg-in-check-v1" ,go-gopkg-in-check-v1)))
+ (home-page "https://gopkg.in/yaml.v3")
+ (synopsis "YAML reader and writer for the Go language")
+ (description
+ "This package provides a Go library for encode and decode YAML
+values.
+
+v3 specification difference:
+@itemize
+@item YAML 1.1 bools (yes/no, on/off) are supported as long as they are
+being decoded into a typed bool value. Otherwise they behave as a string.
+Booleans in YAML 1.2 are true/false only.
+
+@item Octals encode and decode as 0777 per YAML 1.1, rather than 0o777 as
+specified in YAML 1.2, because most parsers still use the old format. Octals in
+the 0o777 format are supported though, so new files work.
+
+@item Does not support base-60 floats. These are gone from YAML 1.2, and were
+actually never supported by this package as it's clearly a poor choice.
+@end itemize")
+ (license license:asl2.0)))
+
(define-public go-github-com-mattn-go-isatty
(package
(name "go-github-com-mattn-go-isatty")
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#46234] [PATCH] Add new gopkg.in/yaml.v3
2021-06-18 19:29 ` Sharlatan Hellseher
@ 2021-06-19 8:31 ` Xinglu Chen
2021-06-22 8:53 ` bug#46234: " Nicolas Goaziou
1 sibling, 0 replies; 6+ messages in thread
From: Xinglu Chen @ 2021-06-19 8:31 UTC (permalink / raw)
To: Sharlatan Hellseher; +Cc: 46234
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
On Fri, Jun 18 2021, Sharlatan Hellseher wrote:
> Hi Xinglu,
>
> I've reviewed your comments and updated the patch, thanks for your
> time!
You are welcome! The patch looks good to me, but you will have to wait
for someone with commit access to apply it :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#46234: [PATCH] Add new gopkg.in/yaml.v3
2021-06-18 19:29 ` Sharlatan Hellseher
2021-06-19 8:31 ` Xinglu Chen
@ 2021-06-22 8:53 ` Nicolas Goaziou
1 sibling, 0 replies; 6+ messages in thread
From: Nicolas Goaziou @ 2021-06-22 8:53 UTC (permalink / raw)
To: Sharlatan Hellseher; +Cc: Xinglu Chen, 46234-done
Hello,
Sharlatan Hellseher <sharlatanus@gmail.com> writes:
Thank you for the patch, and thanks Xinglu for the review.
I applied your patch with the following changes:
> gnu: Add gopkg.in/yaml.v3
I added a final full stop.
> + (uri (git-reference
> + (url "https://gopkg.in/yaml.v3.git")
I removed the ".git" suffix.
> + (description
> + "This package provides a Go library for encode and decode YAML
> +values.
> +
> +v3 specification difference:
> +@itemize
> +@item YAML 1.1 bools (yes/no, on/off) are supported as long as they are
> +being decoded into a typed bool value. Otherwise they behave as a string.
> +Booleans in YAML 1.2 are true/false only.
> +
> +@item Octals encode and decode as 0777 per YAML 1.1, rather than 0o777 as
> +specified in YAML 1.2, because most parsers still use the old format. Octals in
> +the 0o777 format are supported though, so new files work.
> +
> +@item Does not support base-60 floats. These are gone from YAML 1.2, and were
> +actually never supported by this package as it's clearly a poor choice.
> +@end itemize")
I shortened the description.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-22 8:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 12:46 [bug#46234] [PATCH] Add new gopkg.in/yaml.v3 Sharlatan Hellseher
[not found] ` <handler.46234.B.161218363110237.ack@debbugs.gnu.org>
2021-06-13 11:14 ` [bug#46234] Acknowledgement ([PATCH] Add new gopkg.in/yaml.v3) Sharlatan Hellseher
2021-06-18 14:42 ` [bug#46234] [PATCH] Add new gopkg.in/yaml.v3 Xinglu Chen
2021-06-18 19:29 ` Sharlatan Hellseher
2021-06-19 8:31 ` Xinglu Chen
2021-06-22 8:53 ` bug#46234: " Nicolas Goaziou
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.