all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: John Kehayias <john.kehayias@protonmail.com>,
	54069@debbugs.gnu.org, Brendan Tildesley <mail@brendan.scot>,
	Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: [bug#54069] [PATCH v2 3/4] gnu: libosinfo: Unbundle usb.ids, pci.ids.
Date: Sun, 27 Feb 2022 22:23:19 +0100	[thread overview]
Message-ID: <87r17ot35k.fsf@gnu.org> (raw)
In-Reply-To: <58cd826af583022698ee91d0c2a25526ccb27756.camel@telenet.be> (Maxime Devos's message of "Sun, 27 Feb 2022 11:56:28 +0100")

Hello!

Maxime Devos <maximedevos@telenet.be> skribis:

> (define libosinfo-new
>   (package
>     (inherit (specification->package "libosinfo"))
>     (arguments
>       (list #:configure-flags
>             #~(let* ((inputs #$this-package-native-input-list)
>                      (usb.ids (search-input-file inputs "/share/hwdata/usb.ids"))
>                      (pci.ids (search-input-file inputs "/share/hwdata/pci.ids")))
>                 (list (string-append "-Dwith-usb-ids-path=" usb.ids)
>                       (string-append "-Dwith-pci-ids-path=" pci.ids)))

I think this is equivalent to:

  #~(let* ((inputs #$(input-tuples->gexp (package-inputs this-package)))
           …)
      …)

Am I right?

However, that looks a bit far-fetched to me.

Can’t we instead do:

  #~(let* ((usb.ids (string-append #$hwdata:usb "/share/hwdata/usb.ids"))
           (pci.ids (string-append #$hwdata:pci "/share/hwdata/pci.ids")))
      …)

?

Ludo’.




  reply	other threads:[~2022-02-27 21:24 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-20  9:53 [bug#54069] [PATCH 0/2] gnu: pciutils: Unbundle pci.ids and use latest Brendan Tildesley
2022-02-20  9:55 ` [bug#54069] [PATCH 1/2] gnu: Add hwdata Brendan Tildesley
2022-02-20  9:55   ` [bug#54069] [PATCH 2/2] gnu: pciutils: Unbundle pci.ids and use latest Brendan Tildesley
2022-02-21 19:40     ` [bug#54069] [PATCH 0/2] " Maxim Cournoyer
2022-02-22  8:40       ` Brendan Tildesley
2022-02-24  3:32   ` Maxim Cournoyer
2022-02-25  4:44     ` Brendan Tildesley
2022-02-26  5:00       ` Maxim Cournoyer
2022-02-21 16:19 ` John Kehayias via Guix-patches via
2022-02-22 19:34   ` John Kehayias via Guix-patches via
2022-02-22 21:00     ` Maxim Cournoyer
2022-02-22 21:22       ` John Kehayias via Guix-patches via
2022-02-23  1:08         ` Maxim Cournoyer
2022-02-23  6:16           ` John Kehayias via Guix-patches via
2022-02-26  4:32 ` [bug#54069] [PATCH v2 1/4] gnu: Add hwdata Brendan Tildesley
2022-02-26  4:32   ` [bug#54069] [PATCH v2 2/4] gnu: pciutils: Unbundle pci.ids and use latest Brendan Tildesley
2022-02-26 14:19     ` Maxim Cournoyer
2022-02-26  4:32   ` [bug#54069] [PATCH v2 3/4] gnu: libosinfo: Unbundle usb.ids, pci.ids Brendan Tildesley
2022-02-26 11:21     ` Maxime Devos
2022-02-27  1:37       ` Brendan Tildesley
2022-02-27 10:46         ` Maxime Devos
2022-02-27 10:56           ` Maxime Devos
2022-02-27 21:23             ` Ludovic Courtès [this message]
2022-02-27 22:17               ` Maxime Devos
2022-02-28 11:48                 ` Ludovic Courtès
2022-02-27 22:18               ` Maxime Devos
2022-02-27 12:12     ` Maxime Devos
2022-02-26  4:32   ` [bug#54069] [PATCH v2 4/4] gnu: libpciaccess: Use hwdata for pci.ids Brendan Tildesley
2022-02-26 23:14   ` [bug#54069] [PATCH v2 1/4] gnu: Add hwdata Maxim Cournoyer
2022-02-27 12:08     ` Maxime Devos
2022-03-10  9:31 ` [bug#54069] [PATCHES v3 0/7]: Update and make use of hwdata Brendan Tildesley
2022-03-10  9:31   ` [bug#54069] [PATCH v3 1/7] gnu: hwdata: Set #:target #f Brendan Tildesley
2022-03-10  9:31   ` [bug#54069] [PATCH v3 2/7] gnu: hwdata: Remove unused gzip native-input Brendan Tildesley
2022-03-10  9:31   ` [bug#54069] [PATCH v3 3/7] gnu: hwdata: Update to 0.357 Brendan Tildesley
2022-03-10  9:31   ` [bug#54069] [PATCH v3 4/7] gnu: pciutils: Unbundle pci.ids and use latest Brendan Tildesley
2022-03-23  1:57     ` [bug#54069] [PATCH 0/2] " Maxim Cournoyer
2022-03-10  9:31   ` [bug#54069] [PATCH v3 5/7] gnu: libosinfo: Unbundle usb.ids, pci.ids Brendan Tildesley
2022-03-23  2:14     ` bug#54069: [PATCH 0/2] gnu: pciutils: Unbundle pci.ids and use latest Maxim Cournoyer
2022-03-10  9:31   ` [bug#54069] [PATCH v3 6/7] gnu: libosinfo: Use this-package-input Brendan Tildesley
2022-03-10  9:31   ` [bug#54069] [PATCH v3 7/7] gnu: libpciaccess: Use hwdata for pci.ids Brendan Tildesley
2022-03-22 22:02     ` [bug#54069] [PATCH 0/2] gnu: pciutils: Unbundle pci.ids and use latest Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r17ot35k.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=54069@debbugs.gnu.org \
    --cc=john.kehayias@protonmail.com \
    --cc=mail@brendan.scot \
    --cc=maxim.cournoyer@gmail.com \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.