From: Brendan Tildesley <mail@brendan.scot>
To: Maxime Devos <maximedevos@telenet.be>, 54069@debbugs.gnu.org
Cc: John Kehayias <john.kehayias@protonmail.com>,
Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: [bug#54069] [PATCH v2 3/4] gnu: libosinfo: Unbundle usb.ids, pci.ids.
Date: Sun, 27 Feb 2022 02:37:02 +0100 (CET) [thread overview]
Message-ID: <190017101.145924.1645925822107@office.mailbox.org> (raw)
In-Reply-To: <e9a32718adfd8feb2e9804b73c50953981cbaec0.camel@telenet.be>
> On 02/26/2022 12:21 PM Maxime Devos <maximedevos@telenet.be> wrote:
>
>
> Brendan Tildesley schreef op za 26-02-2022 om 15:32 [+1100]:
> > + (string-append "-Dwith-usb-ids-path=" #$hwdata:usb "/share/hwdata/usb.ids")
> > + (string-append "-Dwith-pci-ids-path=" #$hwdata:pci "/share/hwdata/pci.ids"))
>
> To allow for package transformations, I recommend using
> this-package-input or the like instead of hardcoding a particular
> package:
>
> #~(list
> (string-append
> "-Dwith-usb-ids-path="
> #$(this-package-input "hwdata:usb") "/share/hwdata/usb.ids"))
> [...])
>
> it might also be possible to use 'search-input-file' instead, avoiding
> input labels (untested):
>
> #~(let* ((inputs #$(input-tuples->gexp (package-inputs this-package)))
> (usb.ids (search-input-file inputs "/share/hwdata/usb.ids"))
> (pci.ids (search-input-file inputs "/share/hwdata/pci.ids")))
> (list (string-append "-Dwith-usb-ids-path=" usb.ids) [...]))
>
I got strange errors trying that and couldn't figure out how to make it work.
There are no examples of input-tuples->gexp being used in a package definition.
This works:
#~(list
(string-append "-Dwith-usb-ids-path="
(search-input-file %build-inputs "/share/hwdata/usb.ids"))
(string-append "-Dwith-pci-ids-path="
(search-input-file %build-inputs "/share/hwdata/pci.ids")))
I thought %build-inputs was not a recommended thing to use though?
> Greetings,
> Maxime.
Backtrace:
In guix/store.scm:
1385:9 19 (map/accumulate-builds #<store-connection 256.99 7f3a3…> …)
1320:8 18 (call-with-build-handler #<procedure 7f3a22f4b360 at g…> …)
In guix/scripts/build.scm:
582:16 17 (_ #<package libosinfo@1.9.0 /home/b/code/guix/gnu/pack…>)
571:24 16 (_ #<package libosinfo@1.9.0 /home/b/code/guix/gnu/pac…> …)
In guix/packages.scm:
1260:17 15 (supported-package? #<package libosinfo@1.9.0 /home/b/…> …)
In guix/memoization.scm:
101:0 14 (_ #<hash-table 7f3a2538e7a0 0/31> #<package libosinfo…> …)
In guix/packages.scm:
1238:37 13 (_)
1498:16 12 (package->bag _ _ _ #:graft? _)
1603:43 11 (thunk)
In ice-9/eval.scm:
191:35 10 (_ #(#(#<directory (gnu packages virtualization) 7f…>) …))
173:47 9 (_ #(#(#<directory (gnu packages virtualization) 7f…>) …))
213:29 8 (_ #(#(#<directory (gnu packages virtualization) 7f…>) …))
155:9 7 (_ #(#(#<directory (gnu packages virtualization) 7f…>) …))
202:35 6 (_ #(#(#<directory (gnu packages virtualization) 7f…>) …))
In guix/gexp.scm:
1886:4 5 (input-tuples->gexp (("glib" #<package glib@2.70…> …) …) …)
In srfi/srfi-1.scm:
586:17 4 (map1 (("glib" #<package glib@2.70.2 gnu/packages…> …) …))
In guix/gexp.scm:
1886:9 3 (_ _)
In ice-9/boot-9.scm:
1685:16 2 (raise-exception _ #:continuable? _)
1685:16 1 (raise-exception _ #:continuable? _)
1685:16 0 (raise-exception _ #:continuable? _)
ice-9/boot-9.scm:1685:16: In procedure raise-exception:
Throw to key `match-error' with args `("match" "no matching pattern" ("glib" #<package glib@2.70.2 gnu/packages/glib.scm:180 7f3a24fdbdc0> "bin"))'.
next prev parent reply other threads:[~2022-02-27 1:38 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 9:53 [bug#54069] [PATCH 0/2] gnu: pciutils: Unbundle pci.ids and use latest Brendan Tildesley
2022-02-20 9:55 ` [bug#54069] [PATCH 1/2] gnu: Add hwdata Brendan Tildesley
2022-02-20 9:55 ` [bug#54069] [PATCH 2/2] gnu: pciutils: Unbundle pci.ids and use latest Brendan Tildesley
2022-02-21 19:40 ` [bug#54069] [PATCH 0/2] " Maxim Cournoyer
2022-02-22 8:40 ` Brendan Tildesley
2022-02-24 3:32 ` Maxim Cournoyer
2022-02-25 4:44 ` Brendan Tildesley
2022-02-26 5:00 ` Maxim Cournoyer
2022-02-21 16:19 ` John Kehayias via Guix-patches via
2022-02-22 19:34 ` John Kehayias via Guix-patches via
2022-02-22 21:00 ` Maxim Cournoyer
2022-02-22 21:22 ` John Kehayias via Guix-patches via
2022-02-23 1:08 ` Maxim Cournoyer
2022-02-23 6:16 ` John Kehayias via Guix-patches via
2022-02-26 4:32 ` [bug#54069] [PATCH v2 1/4] gnu: Add hwdata Brendan Tildesley
2022-02-26 4:32 ` [bug#54069] [PATCH v2 2/4] gnu: pciutils: Unbundle pci.ids and use latest Brendan Tildesley
2022-02-26 14:19 ` Maxim Cournoyer
2022-02-26 4:32 ` [bug#54069] [PATCH v2 3/4] gnu: libosinfo: Unbundle usb.ids, pci.ids Brendan Tildesley
2022-02-26 11:21 ` Maxime Devos
2022-02-27 1:37 ` Brendan Tildesley [this message]
2022-02-27 10:46 ` Maxime Devos
2022-02-27 10:56 ` Maxime Devos
2022-02-27 21:23 ` Ludovic Courtès
2022-02-27 22:17 ` Maxime Devos
2022-02-28 11:48 ` Ludovic Courtès
2022-02-27 22:18 ` Maxime Devos
2022-02-27 12:12 ` Maxime Devos
2022-02-26 4:32 ` [bug#54069] [PATCH v2 4/4] gnu: libpciaccess: Use hwdata for pci.ids Brendan Tildesley
2022-02-26 23:14 ` [bug#54069] [PATCH v2 1/4] gnu: Add hwdata Maxim Cournoyer
2022-02-27 12:08 ` Maxime Devos
2022-03-10 9:31 ` [bug#54069] [PATCHES v3 0/7]: Update and make use of hwdata Brendan Tildesley
2022-03-10 9:31 ` [bug#54069] [PATCH v3 1/7] gnu: hwdata: Set #:target #f Brendan Tildesley
2022-03-10 9:31 ` [bug#54069] [PATCH v3 2/7] gnu: hwdata: Remove unused gzip native-input Brendan Tildesley
2022-03-10 9:31 ` [bug#54069] [PATCH v3 3/7] gnu: hwdata: Update to 0.357 Brendan Tildesley
2022-03-10 9:31 ` [bug#54069] [PATCH v3 4/7] gnu: pciutils: Unbundle pci.ids and use latest Brendan Tildesley
2022-03-23 1:57 ` [bug#54069] [PATCH 0/2] " Maxim Cournoyer
2022-03-10 9:31 ` [bug#54069] [PATCH v3 5/7] gnu: libosinfo: Unbundle usb.ids, pci.ids Brendan Tildesley
2022-03-23 2:14 ` bug#54069: [PATCH 0/2] gnu: pciutils: Unbundle pci.ids and use latest Maxim Cournoyer
2022-03-10 9:31 ` [bug#54069] [PATCH v3 6/7] gnu: libosinfo: Use this-package-input Brendan Tildesley
2022-03-10 9:31 ` [bug#54069] [PATCH v3 7/7] gnu: libpciaccess: Use hwdata for pci.ids Brendan Tildesley
2022-03-22 22:02 ` [bug#54069] [PATCH 0/2] gnu: pciutils: Unbundle pci.ids and use latest Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=190017101.145924.1645925822107@office.mailbox.org \
--to=mail@brendan.scot \
--cc=54069@debbugs.gnu.org \
--cc=john.kehayias@protonmail.com \
--cc=maxim.cournoyer@gmail.com \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.