all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: 54910@debbugs.gnu.org
Cc: kuba@kadziolka.net, Efraim Flashner <efraim@flashner.co.il>
Subject: [bug#54910] [PATCH] guix: import: Convert inputs to the new format.
Date: Thu, 14 Apr 2022 12:33:43 +0200	[thread overview]
Message-ID: <87r160vtjy.fsf@elephly.net> (raw)
In-Reply-To: <20220413123108.5902-1-attila@lendvai.name>

Thanks for the patch!

This looked good to me, so I applied it locally.  I then ran the test
suite and noticed that tests/go.scm and tests/crate.scm have failing
tests.

The failure in tests/go.scm is harmless and can easily be fixed.  But
the failure in tests/crate.scm indicates a real problem, I think.  The
build system expects that inputs are placed in the #:cargo-inputs field
in (arguments …), and this seems to expect old-style labelled inputs.

I don’t know if the build system would work with the new-style plain
lists in the arguments field, so I’m Cc-ing contributors to the build
system.

@Jakub and @Efraim: could you please comment on this?

Thanks in advance!

-- 
Ricardo




  reply	other threads:[~2022-04-14 10:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13 12:30 [bug#54910] [PATCH] guix: import: Convert inputs to the new format Attila Lendvai
2022-04-14 10:33 ` Ricardo Wurmus [this message]
2022-05-23 13:37   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r160vtjy.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=54910@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=kuba@kadziolka.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.