From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KNcFD875V2J1iAAAgWs5BA (envelope-from ) for ; Thu, 14 Apr 2022 12:39:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id eAaEDM75V2IRTgEA9RJhRA (envelope-from ) for ; Thu, 14 Apr 2022 12:39:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C7E644583 for ; Thu, 14 Apr 2022 12:39:09 +0200 (CEST) Received: from localhost ([::1]:42128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1newsW-0000hn-QI for larch@yhetil.org; Thu, 14 Apr 2022 06:39:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1newsQ-0000he-Ro for guix-patches@gnu.org; Thu, 14 Apr 2022 06:39:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33173) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1newsQ-00044V-IQ for guix-patches@gnu.org; Thu, 14 Apr 2022 06:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1newsQ-0004nM-EN for guix-patches@gnu.org; Thu, 14 Apr 2022 06:39:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54910] [PATCH] guix: import: Convert inputs to the new format. References: <20220413123108.5902-1-attila@lendvai.name> In-Reply-To: <20220413123108.5902-1-attila@lendvai.name> Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 14 Apr 2022 10:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54910 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 54910@debbugs.gnu.org Cc: kuba@kadziolka.net, Efraim Flashner Received: via spool by 54910-submit@debbugs.gnu.org id=B54910.164993271818395 (code B ref 54910); Thu, 14 Apr 2022 10:39:02 +0000 Received: (at 54910) by debbugs.gnu.org; 14 Apr 2022 10:38:38 +0000 Received: from localhost ([127.0.0.1]:55302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1news2-0004md-2u for submit@debbugs.gnu.org; Thu, 14 Apr 2022 06:38:38 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1newrz-0004mU-Bw for 54910@debbugs.gnu.org; Thu, 14 Apr 2022 06:38:36 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1649932713; cv=none; d=zohomail.com; s=zohoarc; b=EFy+LAAxv9mfvLhhMjEWVO8OzJ4cie0m4jMNwHUCsHLDu9AQh55uCm+wn6aEBywFDcPNZNHnThjS9DEp//Rb2TGVnl8PR2/TpvjbzKR2k8GWzOYq2OXqoRjXR91mvNEfwMQnYCE4E9fsTGPGgST6vpPYsxHhFjOwciYiTsfNna4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1649932713; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=Nf9SdhsQny/nSCgIECjyovzPcPBZytdRrhvudsfeJFc=; b=jw0/HYkf4NKb6PilfpGVfxHn/pZe/ig26suqt6owQAI9NgB1zVQD0jLI1dtP8J5kftvXEjFia8Iv2VjmzALxS2iOg/xWW2dJ9c8vnkjr9mjXtvF6yNeVVt8lTX+7s8LNoB14byrmpwdfssxUfTWUXY7usBj4EDkBFAd57rB7K98= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1649932713; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Nf9SdhsQny/nSCgIECjyovzPcPBZytdRrhvudsfeJFc=; b=f0SFnrvqmRP+XTJ4sLciTYMHjFChsvWUAaYHEiUct1tZs7WlaQsLwebjmNttiofh LqbDiK4gZ0Pqlq562XUsmAuvQcRFPD0DicFXTVM2STPiZLHrX+20NPayBc675dCKu1B QrFQ7Uc3YJlmKLeP+3nygUa4ucPcHnWc/UgypU6c= Received: from localhost (152-108-142-46.pool.kielnet.net [46.142.108.152]) by mx.zohomail.com with SMTPS id 1649932709422581.2433710727471; Thu, 14 Apr 2022 03:38:29 -0700 (PDT) User-agent: mu4e 1.6.10; emacs 28.0.50 From: Ricardo Wurmus Date: Thu, 14 Apr 2022 12:33:43 +0200 X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <87r160vtjy.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649932749; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Nf9SdhsQny/nSCgIECjyovzPcPBZytdRrhvudsfeJFc=; b=kdf2UsRej4p1S6YQge0ZLWHSMpNaF6EqgFr+Bzf8VM6CQQWshPQW5CMIj4sc01tOTo63Nj soej/nUVaY343MfyQ8t65dntx7y94s6hCppQjSC+JsHgEnUeAj+VZOTIP7OwmraJc1WxcQ p8xfEQTvKjyLvoldwUUPtbUvNSdjGf/HNOOwxonK6oIfZHflnBTOcgaGJm6T5azMKiex6G rJ/JwYelzxe5AYC2aR1X3qmn3XCT3ho217E9ZTk885hsT9tRqM69VntJKuCMXdOXqDUeKP oBixC6EVZ4Gaxn/eEYPClvxvyOwFUMLMa4vtnloQXIp3hy+yFUapVfXKl43gaQ== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1649932749; a=rsa-sha256; cv=fail; b=BVq92SSUc1dObzDTT1oGx6LKcnrTjajwASh2CYGQTOAPwXr2p9bLlQIxQ3TCHQDw5cSAq+ COUcWhFqJwcgbiA4bl68uzivkovwmZSz/E0u0DcEmIMnRq0DLB+Ar6O4G3GfwDGq2X97Fl ZjgAEORZ9AlzUc4uAFvnuX11FQssPAuoRQe1nyQdiRyJsu1VlUltAU9Uf5M2LP/19e5qyy AbJjUXinAKFA2JY2meLtmwRKA7xKz4LFJGYJc1FotsD58HkeLHbmQSlWf9kn86Fk/Eaqun AE8aAx7TpKyD/8I8GgZhXdBfg5M1CWkYKDFAkQ1ffQTQbao23x82+Ynr24jYQA== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=f0SFnrvq; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.95 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=f0SFnrvq; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C7E644583 X-Spam-Score: 1.95 X-Migadu-Scanner: scn1.migadu.com X-TUID: p0WB7diAR5V2 Thanks for the patch! This looked good to me, so I applied it locally. I then ran the test suite and noticed that tests/go.scm and tests/crate.scm have failing tests. The failure in tests/go.scm is harmless and can easily be fixed. But the failure in tests/crate.scm indicates a real problem, I think. The build system expects that inputs are placed in the #:cargo-inputs field in (arguments =E2=80=A6), and this seems to expect old-style labelled input= s. I don=E2=80=99t know if the build system would work with the new-style plain lists in the arguments field, so I=E2=80=99m Cc-ing contributors to the bui= ld system. @Jakub and @Efraim: could you please comment on this? Thanks in advance! --=20 Ricardo