Re: [PATCH] gnu: Add ola

[John J Foerch <jjfoerch@earthlink.net>]

Alex Vong <alexvong1995@gmail.com> writes:

> Hi,
>
> The patch builds on my machine and lgtm. I make some minor changes (in
> diff format):
>
> 1. Add ola.scm to gnu/local.mk, so that the build system knows the
>    presence of gnu/package/ola.scm. The commit message should say this
>    as well.
>
> 2. Move protobuf from propagated-inputs to inputs. I don't know if this
>    is right. But usually library depedencies don't need to be propagated
>    (?), only command line tools needed at run-time need to be
>    propagated, right?
>
> 3. Remove make-flags and phases. %standard-phases is the implicit
>    phases, so there is no need to specify it. I think PREFIX is already
>    handled by gnu-build-system. So it is not needed.
>
>
> 2 files changed, 4 insertions(+), 6 deletions(-)
> gnu/local.mk         | 1 +
> gnu/packages/ola.scm | 9 +++------
>
> modified   gnu/local.mk
> @@ -261,6 +261,7 @@ GNU_SYSTEM_MODULES =				\
>    %D%/packages/nvi.scm				\
>    %D%/packages/ocaml.scm			\
>    %D%/packages/ocr.scm				\
> +  %D%/packages/ola.scm				\
>    %D%/packages/onc-rpc.scm			\
>    %D%/packages/openbox.scm			\
>    %D%/packages/openldap.scm			\
> modified   gnu/packages/ola.scm
> @@ -55,16 +55,13 @@
>         ("libmicrohttpd" ,libmicrohttpd)
>         ("libusb" ,libusb)
>         ("libuuid" ,util-linux)
> -       ("zlib" ,zlib)))
> -    (propagated-inputs
> -     `(("protobuf" ,protobuf)))
> +       ("zlib" ,zlib)
> +       ("protobuf" ,protobuf)))
>      (arguments
>       `(;; G++ >= 4.8 macro expansion tracking requires lots of memory, causing
>         ;; build to fail on low memory systems.  We disable that with the
>         ;; following configure flags.
> -       #:configure-flags (list "CXXFLAGS=-ftrack-macro-expansion=0")
> -       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> -       #:phases %standard-phases))
> +       #:configure-flags (list "CXXFLAGS=-ftrack-macro-expansion=0")))
>      (synopsis "Framework for controlling entertainment lighting equipment")
>      (description "The Open Lighting Architecture is a framework for lighting
>  control information.  It supports a range of protocols and over a dozen USB
>
>
> Thanks for the patch. How do the others think?
>
> Cheers,
> Alex


Hello,

Thank you for taking a look and for catching those details.  Protobuf as
a propagated input is correct however - it is needed for 'pkg-config
--libs libola'.

--
John Foerch