From mboxrd@z Thu Jan 1 00:00:00 1970 From: John J Foerch Subject: Re: [PATCH] gnu: Add ola Date: Fri, 26 Aug 2016 08:10:59 -0400 Message-ID: <87poovrar0.fsf@hecubus.retroj.net> References: <87twe8qu86.fsf@hecubus.retroj.net> <871t1cl1su.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdGmQ-00066n-T8 for guix-devel@gnu.org; Fri, 26 Aug 2016 09:02:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdGmL-0003Tr-CD for guix-devel@gnu.org; Fri, 26 Aug 2016 09:02:43 -0400 Received: from [195.159.176.226] (port=47528 helo=blaine.gmane.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdGmL-0003SP-5S for guix-devel@gnu.org; Fri, 26 Aug 2016 09:02:37 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1bdFyV-00039r-8l for guix-devel@gnu.org; Fri, 26 Aug 2016 14:11:07 +0200 List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Alex Vong writes: > Hi, > > The patch builds on my machine and lgtm. I make some minor changes (in > diff format): > > 1. Add ola.scm to gnu/local.mk, so that the build system knows the > presence of gnu/package/ola.scm. The commit message should say this > as well. > > 2. Move protobuf from propagated-inputs to inputs. I don't know if this > is right. But usually library depedencies don't need to be propagated > (?), only command line tools needed at run-time need to be > propagated, right? > > 3. Remove make-flags and phases. %standard-phases is the implicit > phases, so there is no need to specify it. I think PREFIX is already > handled by gnu-build-system. So it is not needed. > > > 2 files changed, 4 insertions(+), 6 deletions(-) > gnu/local.mk | 1 + > gnu/packages/ola.scm | 9 +++------ > > modified gnu/local.mk > @@ -261,6 +261,7 @@ GNU_SYSTEM_MODULES = \ > %D%/packages/nvi.scm \ > %D%/packages/ocaml.scm \ > %D%/packages/ocr.scm \ > + %D%/packages/ola.scm \ > %D%/packages/onc-rpc.scm \ > %D%/packages/openbox.scm \ > %D%/packages/openldap.scm \ > modified gnu/packages/ola.scm > @@ -55,16 +55,13 @@ > ("libmicrohttpd" ,libmicrohttpd) > ("libusb" ,libusb) > ("libuuid" ,util-linux) > - ("zlib" ,zlib))) > - (propagated-inputs > - `(("protobuf" ,protobuf))) > + ("zlib" ,zlib) > + ("protobuf" ,protobuf))) > (arguments > `(;; G++ >= 4.8 macro expansion tracking requires lots of memory, causing > ;; build to fail on low memory systems. We disable that with the > ;; following configure flags. > - #:configure-flags (list "CXXFLAGS=-ftrack-macro-expansion=0") > - #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out"))) > - #:phases %standard-phases)) > + #:configure-flags (list "CXXFLAGS=-ftrack-macro-expansion=0"))) > (synopsis "Framework for controlling entertainment lighting equipment") > (description "The Open Lighting Architecture is a framework for lighting > control information. It supports a range of protocols and over a dozen USB > > > Thanks for the patch. How do the others think? > > Cheers, > Alex Hello, Thank you for taking a look and for catching those details. Protobuf as a propagated input is correct however - it is needed for 'pkg-config --libs libola'. -- John Foerch