From: Marius Bakke <mbakke@fastmail.com>
To: Arun Isaac <arunisaac@systemreboot.net>, 30390@debbugs.gnu.org
Subject: [bug#30390] [PATCH 1/3] gnu: Add rhash.
Date: Tue, 20 Feb 2018 18:44:45 +0100 [thread overview]
Message-ID: <87po4zblo2.fsf@fastmail.com> (raw)
In-Reply-To: <20180208121747.15072-1-arunisaac@systemreboot.net>
[-- Attachment #1: Type: text/plain, Size: 2667 bytes --]
Arun Isaac <arunisaac@systemreboot.net> writes:
> * gnu/packages/crypto.scm (rhash): New variable.
[...]
> +(define-public rhash
> + (package
> + (name "rhash")
> + (version "1.3.5")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/rhash/RHash/archive/v"
> + version ".tar.gz"))
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "0bhz3xdl6r06k1bqigdjz42l31iqz2qdpg7zk316i7p2ra56iq4q"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:make-flags (list "CC=gcc"
> + (string-append "PREFIX=" %output))
> + #:test-target "test"
> + #:phases
> + (modify-phases %standard-phases
> + (replace 'configure
> + (lambda* (#:key outputs #:allow-other-keys)
> + (substitute* "Makefile"
> + (("\\$\\(DESTDIR\\)/etc")
> + (string-append (assoc-ref outputs "out") "/etc")))
> + #t))
> + (add-after 'build 'build-library
> + (lambda* (#:key outputs make-flags #:allow-other-keys)
> + (apply invoke "make" "lib-shared" make-flags)
> + #t))
> + (add-after 'install 'install-library
> + (lambda* (#:key outputs make-flags #:allow-other-keys)
> + (apply invoke "make" "install-lib-shared" make-flags)
> + (apply invoke
> + "make" "-C" "librhash" "install-headers"
> + "install-so-link" make-flags)
> + #t))
> + (add-after 'check 'check-library
> + (lambda* (#:key outputs make-flags #:allow-other-keys)
> + (apply invoke "make" "test-shared-lib" make-flags)
> + #t)))))
I think the "outputs" key is unnecessary in all these phases.
Also, (invoke ...) returns #t on successful execution, so no need to add
an extra #t at the end.
> + (home-page "https://sourceforge.net/projects/rhash/")
> + (synopsis "Utility for computing hash sums")
> + (description "RHash is a console utility for calculation and verification
> +of magnet links and a wide range of hash sums like CRC32, MD4, MD5, SHA1,
> +SHA256, SHA512, SHA3, AICH, ED2K, Tiger, DC++ TTH, BitTorrent BTIH, GOST R
> +34.11-94, RIPEMD-160, HAS-160, EDON-R, Whirlpool and Snefru.")
> + (license (license:fsf-free "file://COPYING"))))
Has this license been approved by the FSF? If so please add a URL.
Otherwise I'd go with "non-copyleft" here.
Otherwise this LGTM. I guess this can go to "master" in case it's
needed before the CMake update.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2018-02-20 17:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 12:13 [bug#30390] [PATCH 0/3] Update cmake to 3.10.2 Arun Isaac
2018-02-08 12:17 ` [bug#30390] [PATCH 1/3] gnu: Add rhash Arun Isaac
2018-02-08 12:17 ` [bug#30390] [PATCH 2/3] gnu: libuv: Update to 1.19.1 Arun Isaac
2018-02-20 17:46 ` Marius Bakke
2018-02-08 12:17 ` [bug#30390] [PATCH 3/3] gnu: cmake: Update to 3.10.2 Arun Isaac
2018-02-20 17:54 ` Marius Bakke
2018-02-20 17:44 ` Marius Bakke [this message]
2018-02-22 14:42 ` [bug#30390] [PATCH 1/3] gnu: Add rhash Arun Isaac
2018-02-22 14:48 ` Marius Bakke
2018-02-24 13:08 ` [bug#30390] [PATCH 0/3] Update cmake Arun Isaac
2018-02-24 13:08 ` [bug#30390] [PATCH 1/3] gnu: sqlite: Fix source URI Arun Isaac
2018-02-24 13:08 ` [bug#30390] [PATCH 2/3] gnu: cmake: Update to 3.10.2 Arun Isaac
2018-02-24 13:08 ` [bug#30390] [PATCH 3/3] gnu: cmake: Re-indent Arun Isaac
2018-02-24 15:16 ` [bug#30390] [PATCH 0/3] Update cmake Marius Bakke
2018-02-24 19:06 ` Arun Isaac
2018-02-24 21:17 ` Marius Bakke
2018-02-27 17:20 ` Ludovic Courtès
2018-02-24 15:19 ` Marius Bakke
2018-03-20 10:41 ` Marius Bakke
2018-03-21 21:38 ` Arun Isaac
2018-03-23 6:25 ` bug#30390: " Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po4zblo2.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=30390@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.