From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoByT-0006T5-TI for guix-patches@gnu.org; Tue, 20 Feb 2018 12:45:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoByQ-0003kT-Nv for guix-patches@gnu.org; Tue, 20 Feb 2018 12:45:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:45225) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eoByQ-0003k2-FZ for guix-patches@gnu.org; Tue, 20 Feb 2018 12:45:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eoByQ-0006el-9P for guix-patches@gnu.org; Tue, 20 Feb 2018 12:45:02 -0500 Subject: [bug#30390] [PATCH 1/3] gnu: Add rhash. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180208121747.15072-1-arunisaac@systemreboot.net> References: <20180208121323.14840-1-arunisaac@systemreboot.net> <20180208121747.15072-1-arunisaac@systemreboot.net> Date: Tue, 20 Feb 2018 18:44:45 +0100 Message-ID: <87po4zblo2.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac , 30390@debbugs.gnu.org --=-=-= Content-Type: text/plain Arun Isaac writes: > * gnu/packages/crypto.scm (rhash): New variable. [...] > +(define-public rhash > + (package > + (name "rhash") > + (version "1.3.5") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://github.com/rhash/RHash/archive/v" > + version ".tar.gz")) > + (file-name (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "0bhz3xdl6r06k1bqigdjz42l31iqz2qdpg7zk316i7p2ra56iq4q")))) > + (build-system gnu-build-system) > + (arguments > + `(#:make-flags (list "CC=gcc" > + (string-append "PREFIX=" %output)) > + #:test-target "test" > + #:phases > + (modify-phases %standard-phases > + (replace 'configure > + (lambda* (#:key outputs #:allow-other-keys) > + (substitute* "Makefile" > + (("\\$\\(DESTDIR\\)/etc") > + (string-append (assoc-ref outputs "out") "/etc"))) > + #t)) > + (add-after 'build 'build-library > + (lambda* (#:key outputs make-flags #:allow-other-keys) > + (apply invoke "make" "lib-shared" make-flags) > + #t)) > + (add-after 'install 'install-library > + (lambda* (#:key outputs make-flags #:allow-other-keys) > + (apply invoke "make" "install-lib-shared" make-flags) > + (apply invoke > + "make" "-C" "librhash" "install-headers" > + "install-so-link" make-flags) > + #t)) > + (add-after 'check 'check-library > + (lambda* (#:key outputs make-flags #:allow-other-keys) > + (apply invoke "make" "test-shared-lib" make-flags) > + #t))))) I think the "outputs" key is unnecessary in all these phases. Also, (invoke ...) returns #t on successful execution, so no need to add an extra #t at the end. > + (home-page "https://sourceforge.net/projects/rhash/") > + (synopsis "Utility for computing hash sums") > + (description "RHash is a console utility for calculation and verification > +of magnet links and a wide range of hash sums like CRC32, MD4, MD5, SHA1, > +SHA256, SHA512, SHA3, AICH, ED2K, Tiger, DC++ TTH, BitTorrent BTIH, GOST R > +34.11-94, RIPEMD-160, HAS-160, EDON-R, Whirlpool and Snefru.") > + (license (license:fsf-free "file://COPYING")))) Has this license been approved by the FSF? If so please add a URL. Otherwise I'd go with "non-copyleft" here. Otherwise this LGTM. I guess this can go to "master" in case it's needed before the CMake update. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqMXo0ACgkQoqBt8qM6 VPpohwgAobqwHWyj4o06IsMHo8Th7z7RSqO/I/2gymxYy13auhmrS/7PhumNu4OF CbobSvl6a3JrJqm0ecXuNGS2O/wYddvypch7Bc7jgSNhJTDoHUxn36KAhqlPVXr9 vVzogKgkgtRFP+WFBTTzbKpb2kg1hoBxJ/M0I/Y153QsmZdT748XSNSYhvUDRFbX guaRILOr4ZIsodlrbu9iRiVmLcd4iRYI2IeCgO90efERWiJv1wY3NzwERDzLpOV/ cvxGzmDIt2fAfiDmnp5W4gGSU+vc0uK2kpRZyaStmV2C4NstI9uaDa5LFJeOzfq3 aiVUVyzQK6ZVPb7HQ2JpkjndnVvMTw== =aoV/ -----END PGP SIGNATURE----- --=-=-=--