From: ludo@gnu.org (Ludovic Courtès)
To: "Gábor Boskovits" <boskovits@gmail.com>
Cc: 31911@debbugs.gnu.org
Subject: [bug#31911] [PATCH] services: Add prometheus-node-exporter-service-type.
Date: Sat, 23 Jun 2018 23:51:43 +0200 [thread overview]
Message-ID: <87po0hw4r4.fsf@gnu.org> (raw)
In-Reply-To: <20180620125946.7264-1-boskovits@gmail.com> ("Gábor Boskovits"'s message of "Wed, 20 Jun 2018 14:59:46 +0200")
Hello Gábor!
Gábor Boskovits <boskovits@gmail.com> skribis:
> * gnu/services/monitoring.scm (prometheus-node-exporter-service-type):
> New variable.
> (<prometheus-node-exporter-configuration>): New record type.
> (prometheus-node-exporter-shepherd-service): New procedure.
> * gnu/doc/guix.texi (Monitoring Services): Document it.
That’s very useful! Hopefully we can start using it on our build farm,
though we’ll need Grafena (?) or something to visualize those stats,
right? OTOH apparently it already provides a web interface, so…?
It would be nice to add a system test for this service. It could ensure
that representative URLs return 200 or 404, for instance (see the
hpcguix-web test in (gnu tests web) as an example.)
WDYT?
Minor comments:
> +@subsubheading Prometheus Node Exporter Service
Leave a newline here.
> +@cindex prometheus-node-exporter
> +Prometheus node exporter is a Prometheus exporter. It makes hardware and
> +operating system statistics provided by *NIX kernels available for the
The first sentence looks like a tautology. :-)
I’m also unconvinced by the “*NIX” notation.
What about:
The Prometheus ``node exporter'' makes hardware and operating system
statistics available for the…
Please leave two spaces after end-of-sentence periods.
> +@defvar {Scheme variable} prometheus-node-exporter-service-type
Should be @defvr instead of @defvar.
> +@deftp {Data Type} prometheus-node-exporter-configuration
> +Data type representing the configuration of @command{node_exporter}.
> +
> +@table @asis
> +@item @code{package} (default: @code{go-github-com-prometheus-node-exporter})
> +The prometheus-node-exporter package to use.
> +@item @code{web-listen-address} (default: @code{":9100"})
> +Bind the web interface to the specified address.
Please add a newline before the second @item.
With these changes and ideally a simple test, this is ready to go IMO!
Thanks,
Ludo’.
next prev parent reply other threads:[~2018-06-23 21:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 12:59 [bug#31911] [PATCH] services: Add prometheus-node-exporter-service-type Gábor Boskovits
2018-06-23 21:51 ` Ludovic Courtès [this message]
2018-06-25 8:31 ` Gábor Boskovits
2018-06-25 8:56 ` Ludovic Courtès
2018-07-07 15:54 ` Ludovic Courtès
2018-07-07 18:14 ` Gábor Boskovits
2018-07-09 8:43 ` bug#31911: " Gábor Boskovits
2018-07-09 9:17 ` [bug#31911] " Clément Lassieur
2018-07-09 14:12 ` Gábor Boskovits
2018-07-09 14:21 ` Clément Lassieur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po0hw4r4.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=31911@debbugs.gnu.org \
--cc=boskovits@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.