From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWqRv-0005e9-LW for guix-patches@gnu.org; Sat, 23 Jun 2018 17:52:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWqRu-00006o-Q1 for guix-patches@gnu.org; Sat, 23 Jun 2018 17:52:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53820) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWqRu-00006V-MW for guix-patches@gnu.org; Sat, 23 Jun 2018 17:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fWqRu-0000Ld-EU for guix-patches@gnu.org; Sat, 23 Jun 2018 17:52:02 -0400 Subject: [bug#31911] [PATCH] services: Add prometheus-node-exporter-service-type. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180620125946.7264-1-boskovits@gmail.com> Date: Sat, 23 Jun 2018 23:51:43 +0200 In-Reply-To: <20180620125946.7264-1-boskovits@gmail.com> ("=?UTF-8?Q?G=C3=A1bor?= Boskovits"'s message of "Wed, 20 Jun 2018 14:59:46 +0200") Message-ID: <87po0hw4r4.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?G=C3=A1bor?= Boskovits Cc: 31911@debbugs.gnu.org Hello G=C3=A1bor! G=C3=A1bor Boskovits skribis: > * gnu/services/monitoring.scm (prometheus-node-exporter-service-type): > New variable. > (): New record type. > (prometheus-node-exporter-shepherd-service): New procedure. > * gnu/doc/guix.texi (Monitoring Services): Document it. That=E2=80=99s very useful! Hopefully we can start using it on our build f= arm, though we=E2=80=99ll need Grafena (?) or something to visualize those stats, right? OTOH apparently it already provides a web interface, so=E2=80=A6? It would be nice to add a system test for this service. It could ensure that representative URLs return 200 or 404, for instance (see the hpcguix-web test in (gnu tests web) as an example.) WDYT? Minor comments: > +@subsubheading Prometheus Node Exporter Service Leave a newline here. > +@cindex prometheus-node-exporter > +Prometheus node exporter is a Prometheus exporter. It makes hardware and > +operating system statistics provided by *NIX kernels available for the The first sentence looks like a tautology. :-) I=E2=80=99m also unconvinced by the =E2=80=9C*NIX=E2=80=9D notation. What about: The Prometheus ``node exporter'' makes hardware and operating system statistics available for the=E2=80=A6 Please leave two spaces after end-of-sentence periods. > +@defvar {Scheme variable} prometheus-node-exporter-service-type Should be @defvr instead of @defvar. > +@deftp {Data Type} prometheus-node-exporter-configuration > +Data type representing the configuration of @command{node_exporter}. > + > +@table @asis > +@item @code{package} (default: @code{go-github-com-prometheus-node-expor= ter}) > +The prometheus-node-exporter package to use. > +@item @code{web-listen-address} (default: @code{":9100"}) > +Bind the web interface to the specified address. Please add a newline before the second @item. With these changes and ideally a simple test, this is ready to go IMO! Thanks, Ludo=E2=80=99.