From: Marius Bakke <mbakke@fastmail.com>
To: Pierre Neidhardt <ambrevar@gmail.com>, 31999@debbugs.gnu.org
Subject: [bug#31999] [PATCH 4/7] gnu: lvm2: Add device-mapper-event support.
Date: Mon, 30 Jul 2018 00:33:34 +0200 [thread overview]
Message-ID: <87pnz53c5d.fsf@fastmail.com> (raw)
In-Reply-To: <20180728220927.14031-1-ambrevar@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2016 bytes --]
Pierre Neidhardt <ambrevar@gmail.com> writes:
> * GNU/packages/linux.scm (lvm2)[configure-flags]: Build device-mapper-event.
This changes more than just configure-flags, can you update the commit
message accordingly?
[...]
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 70615df93..e27c9b475 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -2127,12 +2127,24 @@ time.")
> "--enable-udev_sync"
> "--enable-udev_rules"
> "--enable-pkgconfig"
> + "--enable-cmdlib"
> + "--enable-dmeventd" ; Requires '--enable-cmdlib'.
>
> ;; Make sure programs such as 'dmsetup' can
> ;; find libdevmapper.so.
> (string-append "LDFLAGS=-Wl,-rpath="
> (assoc-ref %outputs "out")
> - "/lib"))
> + "/lib,-rpath="
> + (assoc-ref %outputs "out")
> + "/lib/device-mapper")
> + ;; TODO: Patch make.tmpl.in to take LDFLAGS
> + ;; into account so that we don't need to also
> + ;; set CLDFLAGS.
> + (string-append "CLDFLAGS=-Wl,-rpath="
> + (assoc-ref %outputs "out")
> + "/lib,-rpath="
> + (assoc-ref %outputs "out")
> + "/lib/device-mapper"))
Did you try patching the Make template?
I suppose this is okay, though I'm curious about the LDFLAGS/CLDFLAGS
distinction.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2018-07-29 22:34 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 21:32 [bug#31999] [PATCH 1/7] gnu: Add volume-key Pierre Neidhardt
2018-06-28 21:35 ` [bug#31999] [PATCH 2/7] gnu: Add ndctl Pierre Neidhardt
2018-06-28 21:35 ` [bug#31999] [PATCH 3/7] gnu: Add libbytesize Pierre Neidhardt
2018-07-12 20:20 ` Marius Bakke
2018-07-28 22:07 ` Pierre Neidhardt
2018-07-29 22:10 ` Marius Bakke
2018-07-30 9:59 ` Pierre Neidhardt
2018-07-30 13:36 ` Pierre Neidhardt
2018-07-30 18:42 ` Marius Bakke
2018-06-28 21:35 ` [bug#31999] [PATCH 4/7] gnu: lvm2: Add device-mapper-event support Pierre Neidhardt
2018-07-12 21:26 ` Marius Bakke
2018-07-28 22:09 ` Pierre Neidhardt
2018-07-29 22:33 ` Marius Bakke [this message]
2018-07-30 10:10 ` Pierre Neidhardt
2018-07-30 10:12 ` Pierre Neidhardt
2018-07-30 12:50 ` Marius Bakke
2018-07-30 13:36 ` Pierre Neidhardt
2018-07-30 18:43 ` Marius Bakke
2018-06-28 21:35 ` [bug#31999] [PATCH 5/7] gnu: Add dmraid Pierre Neidhardt
2018-07-12 21:28 ` Marius Bakke
2018-07-28 15:32 ` Pierre Neidhardt
2018-07-28 22:10 ` Pierre Neidhardt
2018-07-29 22:42 ` Marius Bakke
2018-07-30 10:23 ` Pierre Neidhardt
2018-07-30 13:37 ` Pierre Neidhardt
2018-07-30 18:44 ` Marius Bakke
2018-08-01 3:21 ` [bug#31999] [PATCH 5/7] gnu: Add dmraid. --- Failed to build from master Brendan Tildesley
2018-08-01 11:37 ` Marius Bakke
2018-06-28 21:35 ` [bug#31999] [PATCH 6/7] gnu: Add libblockdev Pierre Neidhardt
2018-07-12 20:24 ` Marius Bakke
2018-07-28 22:10 ` Pierre Neidhardt
2018-07-29 22:56 ` Marius Bakke
2018-07-30 9:14 ` Pierre Neidhardt
2018-07-30 12:52 ` Marius Bakke
2018-07-30 13:37 ` Pierre Neidhardt
2018-07-30 18:48 ` Marius Bakke
2018-06-28 21:35 ` [bug#31999] [PATCH 7/7] gnu: Update udisk to 2.7.6 Pierre Neidhardt
2018-06-28 21:40 ` Pierre Neidhardt
2018-07-12 21:34 ` Marius Bakke
2018-07-28 22:11 ` Pierre Neidhardt
2018-07-28 22:17 ` Pierre Neidhardt
2018-07-29 23:01 ` Marius Bakke
2018-07-30 13:38 ` [bug#31999] [PATCH 7/7] gnu: Update udisks to 2.7.7 Pierre Neidhardt
2018-07-30 18:54 ` Marius Bakke
2018-07-30 19:20 ` Pierre Neidhardt
2018-07-30 19:36 ` Pierre Neidhardt
2018-07-30 19:39 ` Marius Bakke
2018-07-30 19:50 ` Pierre Neidhardt
2018-07-30 20:59 ` Marius Bakke
2018-07-12 20:12 ` [bug#31999] [PATCH 2/7] gnu: Add ndctl Marius Bakke
2018-07-28 22:05 ` Pierre Neidhardt
2018-07-29 22:23 ` Marius Bakke
2018-07-30 9:47 ` Pierre Neidhardt
2018-07-30 12:54 ` Marius Bakke
2018-07-30 13:35 ` Pierre Neidhardt
2018-07-30 18:56 ` Marius Bakke
2018-07-12 20:04 ` [bug#31999] [PATCH 1/7] gnu: Add volume-key Marius Bakke
2018-07-28 21:58 ` [bug#32299] " Pierre Neidhardt
2018-07-28 22:02 ` bug#32299: " Pierre Neidhardt
2018-07-29 22:28 ` [bug#32299] " Marius Bakke
2018-07-30 9:19 ` [bug#31999] " Pierre Neidhardt
2018-07-30 13:16 ` [bug#31999] " Pierre Neidhardt
2018-07-30 19:01 ` Marius Bakke
2018-07-28 22:04 ` Pierre Neidhardt
2018-07-30 19:53 ` bug#31999: [PATCH 7/7] gnu: Update udisks to 2.7.7 Pierre Neidhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnz53c5d.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=31999@debbugs.gnu.org \
--cc=ambrevar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.