From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjuGL-0004EY-0E for guix-patches@gnu.org; Sun, 29 Jul 2018 18:34:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjuGH-0005xi-SV for guix-patches@gnu.org; Sun, 29 Jul 2018 18:34:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57390) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fjuGH-0005xc-Ni for guix-patches@gnu.org; Sun, 29 Jul 2018 18:34:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fjuGH-0003BG-Gx for guix-patches@gnu.org; Sun, 29 Jul 2018 18:34:01 -0400 Subject: [bug#31999] [PATCH 4/7] gnu: lvm2: Add device-mapper-event support. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180728220927.14031-1-ambrevar@gmail.com> References: <87fu0o6t7q.fsf@fastmail.com> <20180728220927.14031-1-ambrevar@gmail.com> Date: Mon, 30 Jul 2018 00:33:34 +0200 Message-ID: <87pnz53c5d.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt , 31999@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Pierre Neidhardt writes: > * GNU/packages/linux.scm (lvm2)[configure-flags]: Build device-mapper-eve= nt. This changes more than just configure-flags, can you update the commit message accordingly? [...] > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm > index 70615df93..e27c9b475 100644 > --- a/gnu/packages/linux.scm > +++ b/gnu/packages/linux.scm > @@ -2127,12 +2127,24 @@ time.") > "--enable-udev_sync" > "--enable-udev_rules" > "--enable-pkgconfig" > + "--enable-cmdlib" > + "--enable-dmeventd" ; Requires '--enable-= cmdlib'. >=20=20 > ;; Make sure programs such as 'dmsetup' c= an > ;; find libdevmapper.so. > (string-append "LDFLAGS=3D-Wl,-rpath=3D" > (assoc-ref %outputs "out") > - "/lib")) > + "/lib,-rpath=3D" > + (assoc-ref %outputs "out") > + "/lib/device-mapper") > + ;; TODO: Patch make.tmpl.in to take LDFLA= GS > + ;; into account so that we don't need to = also > + ;; set CLDFLAGS. > + (string-append "CLDFLAGS=3D-Wl,-rpath=3D" > + (assoc-ref %outputs "out") > + "/lib,-rpath=3D" > + (assoc-ref %outputs "out") > + "/lib/device-mapper")) Did you try patching the Make template? I suppose this is okay, though I'm curious about the LDFLAGS/CLDFLAGS distinction. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlteQL4ACgkQoqBt8qM6 VPortAf/QuAAK80erjajTEn6M+BFzmKIW4ds2Dv5UonJN29zS9Ls9vFGw14wxGjb s6gt40DJkXwraxFqAMkLaTu74aZZZArkpOtnY/iH0xbvzemBnzZ9Ob9HkiZzK15b j6D31jFiSTRuvyeIMJ/hcw9fY0rAVePCK60qYOkAUJ1avSrJbXj5a11v0TdDQJ2K I0GebzCH/WW24lhCqLEvxN/wRa/noKGobqoDGX8RZkkkWbghvPsSdaucCMP+U4Fe QjjZDaI06iFuSkWda8zhczfIX50wGMZpfuaoLqEYzkb81u5DJZRWAEpyhhpAmqFt DYCcniMqBA3gAYsaO4i/qshC4DyJuA== =QA3u -----END PGP SIGNATURE----- --=-=-=--