[bug#34971] [PATCH] gnu: Add mako.

[bug#34971] [PATCH] gnu: Add mako.

[Meiyo Peng]

* gnu/packages/wm.scm (mako): New variable.
---
 gnu/packages/wm.scm | 31 ++++++++++++++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 0a05ff4ae4..cc7cd56d66 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -17,7 +17,7 @@
 ;;; Copyright © 2017 Oleg Pykhalov <go.wigust@gmail.com>
 ;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2018 Pierre-Antoine Rouby <contact@parouby.fr>
-;;; Copyright © 2018 Meiyo Peng <meiyo.peng@gmail.com>
+;;; Copyright © 2018, 2019 Meiyo Peng <meiyo@riseup.net>
 ;;; Copyright © 2019 Rutger Helling <rhelling@mykolab.com>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -1228,3 +1228,32 @@ modules for building a Wayland compositor.")
     (synopsis "Screen locking utility for Wayland compositors")
     (description "Swaylock is a screen locking utility for Wayland compositors.")
     (license license:expat))) ; MIT license
+
+(define-public mako
+  (package
+    (name "mako")
+    (version "1.2")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/emersion/mako")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "112b7s5bkvwlgsm2kng2vh8mn6wr3a6c7n1arl9adxlghdym449h"))))
+    (build-system meson-build-system)
+    (inputs
+     `(("cairo" ,cairo)
+       ("elogind" ,elogind)
+       ("pango" ,pango)
+       ("wayland" ,wayland)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("scdoc" ,scdoc)
+       ("wayland-protocols" ,wayland-protocols)))
+    (home-page "https://github.com/emersion/mako")
+    (synopsis "Lightweight Wayland notification daemon")
+    (description "@code{mako} is a lightweight notification daemon for
+Wayland.")
+    (license license:expat)))
-- 
2.21.0

[bug#34971] [PATCH] gnu: Add mako.

[Meiyo Peng]

Hi everyone,

If you have trouble running mako and mako gives you an error message
like:

#+begin_example
  Failed to connect to user bus: No such file or directory
#+end_example

The problem is caused by that $DBUS_SESSION_BUS_ADDRESS is not set in
your GUI session.  You can start mako with this command:

#+begin_src sh
  dbus-launch --autolaunch=$(dbus-uuidgen --get) mako
#+end_src

I run mako with Sway.  And I put this line in Sway config file:

#+begin_src conf
  exec sh -c 'dbus-launch --autolaunch=$(dbus-uuidgen --get) mako'
#+end_src


--
Meiyo Peng
https://www.pengmeiyu.com/

[bug#34971] [PATCH] gnu: Add mako.

[Ludovic Courtès]

Hello,

Meiyo Peng <meiyo@riseup.net> skribis:

> If you have trouble running mako and mako gives you an error message
> like:
>
> #+begin_example
>   Failed to connect to user bus: No such file or directory
> #+end_example

I would expect Mako to automatically spawn the D-Bus user bus if it’s
not already needed, no?  We don’t need to do anything special with other
D-Bus applications AFAIK.

Thanks,
Ludo’.

[bug#34971] [PATCH] gnu: Add mako.

[Ricardo Wurmus]

Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> Meiyo Peng <meiyo@riseup.net> skribis:
>
>> If you have trouble running mako and mako gives you an error message
>> like:
>>
>> #+begin_example
>>   Failed to connect to user bus: No such file or directory
>> #+end_example
>
> I would expect Mako to automatically spawn the D-Bus user bus if it’s
> not already needed, no?  We don’t need to do anything special with other
> D-Bus applications AFAIK.

When the desktop environment has a D-Bus session daemon, this should
just work.  I suppose using dbus-lauch is necessary in cases where a
minimalist desktop environment is used that does not take steps to
launch/configure the D-Bus daemon.

In that sense I think mako behaves like any other D-Bus application.

-- 
Ricardo

[bug#34971] [PATCH] gnu: Add mako.

[Ludovic Courtès]

Ricardo Wurmus <rekado@elephly.net> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hello,
>>
>> Meiyo Peng <meiyo@riseup.net> skribis:
>>
>>> If you have trouble running mako and mako gives you an error message
>>> like:
>>>
>>> #+begin_example
>>>   Failed to connect to user bus: No such file or directory
>>> #+end_example
>>
>> I would expect Mako to automatically spawn the D-Bus user bus if it’s
>> not already needed, no?  We don’t need to do anything special with other
>> D-Bus applications AFAIK.
>
> When the desktop environment has a D-Bus session daemon, this should
> just work.  I suppose using dbus-lauch is necessary in cases where a
> minimalist desktop environment is used that does not take steps to
> launch/configure the D-Bus daemon.

I thought along these lines, but then I use Ratpoison and D-Bus programs
“just work” for me.  There’s no DBUS_SESSION_BUS_whatever environment
variable set for me.  I’m curious!

Ludo’.

[bug#34971] [PATCH] gnu: Add mako.

[Meiyo Peng]

Hi Ludovic,

Ludovic Courtès writes:

> Meiyo Peng <meiyo@riseup.net> skribis:
>
>> If you have trouble running mako and mako gives you an error message
>> like:
>>
>> #+begin_example
>>   Failed to connect to user bus: No such file or directory
>> #+end_example
>
> I would expect Mako to automatically spawn the D-Bus user bus if it’s
> not already needed, no?  We don’t need to do anything special with other
> D-Bus applications AFAIK.

Yeah.  I expect that too.  I am not sure why mako is so special.  mako
uses the sd-bus library of systemd/elogind instead of libdbus.  Do you
think that could be the cause?

I don't know much about D-Bus.  Maybe it's just because of mako's bad
program design.  I used dunst as my notification daemon and dunst did
just works.  dunst provides a D-Bus service file.  I don't even have to
manually start dunst.


--
Meiyo Peng

[bug#34971] [PATCH] gnu: Add mako.

[Ludovic Courtès]

Hi Meiyo,

Meiyo Peng <meiyo@riseup.net> skribis:

> Ludovic Courtès writes:
>
>> Meiyo Peng <meiyo@riseup.net> skribis:
>>
>>> If you have trouble running mako and mako gives you an error message
>>> like:
>>>
>>> #+begin_example
>>>   Failed to connect to user bus: No such file or directory
>>> #+end_example
>>
>> I would expect Mako to automatically spawn the D-Bus user bus if it’s
>> not already needed, no?  We don’t need to do anything special with other
>> D-Bus applications AFAIK.
>
> Yeah.  I expect that too.  I am not sure why mako is so special.  mako
> uses the sd-bus library of systemd/elogind instead of libdbus.  Do you
> think that could be the cause?

Could you check with ‘strace’ whether it tries to connect to
/run/dbus/system_bus_socket instead of /var/run/dbus/system_bus_socket?

Thanks,
Ludo’.

[bug#34971] [PATCH] gnu: Add mako.

[Meiyo Peng]

Hi Ludovic,

Ludovic Courtès writes:

> Meiyo Peng <meiyo@riseup.net> skribis:
>
>> Ludovic Courtès writes:
>>
>>> Meiyo Peng <meiyo@riseup.net> skribis:
>>>
>>>> If you have trouble running mako and mako gives you an error message
>>>> like:
>>>>
>>>> #+begin_example
>>>>   Failed to connect to user bus: No such file or directory
>>>> #+end_example
>>>
>>> I would expect Mako to automatically spawn the D-Bus user bus if it’s
>>> not already needed, no?  We don’t need to do anything special with other
>>> D-Bus applications AFAIK.
>>
>> Yeah.  I expect that too.  I am not sure why mako is so special.  mako
>> uses the sd-bus library of systemd/elogind instead of libdbus.  Do you
>> think that could be the cause?
>
> Could you check with ‘strace’ whether it tries to connect to
> /run/dbus/system_bus_socket instead of /var/run/dbus/system_bus_socket?

I get this output from `strace mako`:

#+begin_example
  ...
  socket(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, 0) = 3
  getsockopt(3, SOL_SOCKET, SO_RCVBUF, [212992], [4]) = 0
  setsockopt(3, SOL_SOCKET, SO_RCVBUF, [8388608], 4) = 0
  getsockopt(3, SOL_SOCKET, SO_SNDBUF, [212992], [4]) = 0
  setsockopt(3, SOL_SOCKET, SO_SNDBUF, [8388608], 4) = 0
  connect(3, {sa_family=AF_UNIX, sun_path="/run/user/1000/bus"}, 21) = -1 ENOENT (No such file or directory)
  close(3)                                = 0
  write(2, "Failed to connect to user bus: N"..., 57Failed to connect to user bus: No such file or directory
  ) = 57
  exit_group(1)                           = ?
  +++ exited with 1 +++
#+end_example

It tries to connect to /run/user/1000/bus.

And that error message is from
https://github.com/emersion/mako/blob/master/dbus/dbus.c:

#+begin_src c
  ret = sd_bus_open_user(&state->bus);
  if (ret < 0) {
      fprintf(stderr, "Failed to connect to user bus: %s\n", strerror(-ret));
      goto error;
  }
#+end_src

--
Meiyo Peng
https://www.pengmeiyu.com/

[bug#34971] [PATCH] gnu: Add mako.

[Ludovic Courtès]

Hi,

Meiyo Peng <meiyo@riseup.net> skribis:

> I get this output from `strace mako`:
>
> #+begin_example
>   ...
>   socket(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, 0) = 3
>   getsockopt(3, SOL_SOCKET, SO_RCVBUF, [212992], [4]) = 0
>   setsockopt(3, SOL_SOCKET, SO_RCVBUF, [8388608], 4) = 0
>   getsockopt(3, SOL_SOCKET, SO_SNDBUF, [212992], [4]) = 0
>   setsockopt(3, SOL_SOCKET, SO_SNDBUF, [8388608], 4) = 0
>   connect(3, {sa_family=AF_UNIX, sun_path="/run/user/1000/bus"}, 21) = -1 ENOENT (No such file or directory)

So I’m a bit at loss but what I can say is that /run/user/UID/bus
doesn’t seem to exist in practice.

For example, if I strace “dbus-monitor --session”, I see this:

  connect(3, {sa_family=AF_UNIX, sun_path=@"/tmp/dbus-ktJE8…"}, 23) = 0

I have no idea where this file name comes from but it seems to be
deterministic.

So… more investigation needed!

Ludo’.

[bug#34971] [PATCH] gnu: Add mako.

[Ludovic Courtès]

Hi Meiyo,

Did you make any progress on this front?

Thanks,
Ludo’.

Ludovic Courtès <ludo@gnu.org> skribis:

> Hi,
>
> Meiyo Peng <meiyo@riseup.net> skribis:
>
>> I get this output from `strace mako`:
>>
>> #+begin_example
>>   ...
>>   socket(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, 0) = 3
>>   getsockopt(3, SOL_SOCKET, SO_RCVBUF, [212992], [4]) = 0
>>   setsockopt(3, SOL_SOCKET, SO_RCVBUF, [8388608], 4) = 0
>>   getsockopt(3, SOL_SOCKET, SO_SNDBUF, [212992], [4]) = 0
>>   setsockopt(3, SOL_SOCKET, SO_SNDBUF, [8388608], 4) = 0
>>   connect(3, {sa_family=AF_UNIX, sun_path="/run/user/1000/bus"}, 21) = -1 ENOENT (No such file or directory)
>
> So I’m a bit at loss but what I can say is that /run/user/UID/bus
> doesn’t seem to exist in practice.
>
> For example, if I strace “dbus-monitor --session”, I see this:
>
>   connect(3, {sa_family=AF_UNIX, sun_path=@"/tmp/dbus-ktJE8…"}, 23) = 0
>
> I have no idea where this file name comes from but it seems to be
> deterministic.
>
> So… more investigation needed!
>
> Ludo’.

[bug#34971] [PATCH] gnu: Add mako.

[Meiyo Peng]

Hi Ludovic,

Ludovic Courtès writes:

> Did you make any progress on this front?

I have discussed with the author of mako.  He agreed to add a D-Bus
service file for mako.  That will solve this issue here.  I have tested
it on my computer.  The D-Bus service file will cause mako to be
automatically started when needed.  mako will work out of the box after
installation.  No user action is required.

Link:
1. https://github.com/emersion/mako/issues/155
2. https://github.com/emersion/mako/pull/156

When that pull request is merged, I will send a new package definition
for mako.

> Ludovic Courtès <ludo@gnu.org> skribis:
>
>> Hi,
>>
>> Meiyo Peng <meiyo@riseup.net> skribis:
>>
>>> I get this output from `strace mako`:
>>>
>>> #+begin_example
>>>   ...
>>>   socket(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, 0) = 3
>>>   getsockopt(3, SOL_SOCKET, SO_RCVBUF, [212992], [4]) = 0
>>>   setsockopt(3, SOL_SOCKET, SO_RCVBUF, [8388608], 4) = 0
>>>   getsockopt(3, SOL_SOCKET, SO_SNDBUF, [212992], [4]) = 0
>>>   setsockopt(3, SOL_SOCKET, SO_SNDBUF, [8388608], 4) = 0
>>>   connect(3, {sa_family=AF_UNIX, sun_path="/run/user/1000/bus"}, 21) = -1 ENOENT (No such file or directory)
>>
>> So I’m a bit at loss but what I can say is that /run/user/UID/bus
>> doesn’t seem to exist in practice.
>>
>> For example, if I strace “dbus-monitor --session”, I see this:
>>
>>   connect(3, {sa_family=AF_UNIX, sun_path=@"/tmp/dbus-ktJE8…"}, 23) = 0
>>
>> I have no idea where this file name comes from but it seems to be
>> deterministic.
>>
>> So… more investigation needed!
>>
>> Ludo’.


--
Meiyo Peng
https://www.pengmeiyu.com/

[bug#34971] [PATCH] gnu: Add mako.

[Ludovic Courtès]

Hi Meiyo,

Meiyo Peng <meiyo@riseup.net> skribis:

> I have discussed with the author of mako.  He agreed to add a D-Bus
> service file for mako.  That will solve this issue here.  I have tested
> it on my computer.  The D-Bus service file will cause mako to be
> automatically started when needed.  mako will work out of the box after
> installation.  No user action is required.
>
> Link:
> 1. https://github.com/emersion/mako/issues/155
> 2. https://github.com/emersion/mako/pull/156
>
> When that pull request is merged, I will send a new package definition
> for mako.

Alright, sounds good to me.  Thanks for the update!

Ludo’.

[bug#34971] [PATCH] gnu: Add mako.

[Stefan Stefanović]

Hello.

AFAIK mako relies on elogind to access user DBus session daemon.

elogind relies on environment variable DBUS_SESSION_BUS_ADDRESS.
In my case DBUS_SESSION_BUS_ADDRESS is set to
"unix:path=/run/user/1000/dbus-1/session_bus_socket".

DBUS_SESSION_BUS_ADDRESS is created by user session manager.
In my case it is set in a shell script by executing:
echo "Starting user DBus session daemon."
dbus-daemon \
  --syslog --fork \
  --address="${DBUS_SESSION_BUS_ADDRESS}" \
  --print-pid --session

This is not perfect solution but it works, for now.

Please take a look at relevant elogind issue:
https://github.com/elogind/elogind/issues/87

Stefan.

[bug#34971] [PATCH v2] gnu: Add mako.

[Meiyo Peng]

* gnu/packages/notification.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
---
 gnu/local.mk                  |  1 +
 gnu/packages/notification.scm | 59 +++++++++++++++++++++++++++++++++++
 2 files changed, 60 insertions(+)
 create mode 100644 gnu/packages/notification.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 3a199f82f8..fb02c8aa8c 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -342,6 +342,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/nim.scm  			\
   %D%/packages/ninja.scm			\
   %D%/packages/node.scm				\
+  %D%/packages/notification.scm			\
   %D%/packages/noweb.scm			\
   %D%/packages/nss.scm				\
   %D%/packages/ntp.scm				\
diff --git a/gnu/packages/notification.scm b/gnu/packages/notification.scm
new file mode 100644
index 0000000000..0e7abb8693
--- /dev/null
+++ b/gnu/packages/notification.scm
@@ -0,0 +1,59 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2019 Meiyo Peng <meiyo@riseup.net>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages notification)
+  #:use-module (gnu packages freedesktop)
+  #:use-module (gnu packages gtk)
+  #:use-module (gnu packages man)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (guix build-system meson)
+  #:use-module (guix git-download)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages))
+
+(define-public mako
+  (let ((commit "ca8e763f06756136c534b1bbd2e5b536be6b1995")
+        (revision "1"))
+    (package
+      (name "mako")
+      (version (string-append "1.3-" revision "."
+                              (string-take commit 7)))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/emersion/mako.git")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1w16n58xj4ncaqjlwczq7i8kpxi05hjp2dqkqhajd9dzk0bd77qy"))))
+      (build-system meson-build-system)
+      (inputs
+       `(("cairo" ,cairo)
+         ("elogind" ,elogind)
+         ("pango" ,pango)
+         ("wayland" ,wayland)
+         ("wayland-protocols" ,wayland-protocols)))
+      (native-inputs
+       `(("pkg-config" ,pkg-config)
+         ("scdoc" ,scdoc)))
+      (home-page "https://github.com/emersion/mako")
+      (synopsis "Lightweight Wayland notification daemon")
+      (description "@code{mako} is a lightweight notification daemon for
+Wayland.")
+      (license license:expat))))
-- 
2.21.0

bug#34971: [PATCH v2] gnu: Add mako.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

Meiyo Peng <meiyo@riseup.net> writes:

> * gnu/packages/notification.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

Looks like Gábor committed a version of this in
46dc940c9af3d8b48966d16e52273ba88e92f946.

Sorry for the duplicate work!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]