From: "LaFreniere\, Joseph" <joseph@lafreniere.xyz>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 39384@debbugs.gnu.org
Subject: [bug#39384] [PATCH] gnu: Add emacs-rg.
Date: Sun, 02 Feb 2020 08:21:52 -0600 [thread overview]
Message-ID: <87pnexrrwf.fsf@lafreniere.xyz> (raw)
In-Reply-To: <878slmc640.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]
Thank you for the fast feedback!
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Nitpick: I think the trend is to align `base32' with the string.
> You may want to lint your package. In particular, the synopsis
> should be
> akin to "Search tool based ..."
> The description must start with a full sentence, e.g., "rg.el"
> is an
> Emacs search package...
> Texinfo requires two spaces after the full stop.
> Ditto. Besides, the quote after "users" looks suspicious. You
> should use
> a regular quote.
A patch file is attached that addresses all of the above feedback.
The output of `guix lint emacs-rg` is now clean on my system;
thank you for making me aware of that utility.
The only part of the package I'm uncertain about is declaring
ripgrep as a propagated dependency. ripgrep is not needed for
this Emacs package to be able to byte-compile successfully, but
`rg` does not need to be on PATH for the package to be useful at
all. So while I imagine the majority of the uses-cases would want
to have ripgrep installed locally, it's definitely plausible that
one could only ever want to use emacs-rg via TRAMP in which case
pulling in ripgrep would be completely unnecessary.
Please let me know what you think.
--
Joseph LaFreniere
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-rg.patch --]
[-- Type: text/x-patch, Size: 2015 bytes --]
From 9a17c333ceee4bb72dcb1ee36aaf45a7d2ce4276 Mon Sep 17 00:00:00 2001
From: Joseph LaFreniere <joseph@lafreniere.xyz>
Date: Sat, 1 Feb 2020 14:23:36 -0600
Subject: [PATCH] gnu: Add emacs-rg.
* gnu/packages/emacs-xyz.scm (emacs-rg): New variable.
---
gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f95ad26e4b..29928364e0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -134,6 +134,7 @@
#:use-module (gnu packages package-management)
#:use-module (gnu packages perl)
#:use-module (gnu packages pdf)
+ #:use-module (gnu packages rust-apps)
#:use-module (gnu packages scheme)
#:use-module (gnu packages speech)
#:use-module (gnu packages xiph)
@@ -2751,6 +2752,32 @@ column by drawing a thin line down the length of the editing window.")
"This Emacs package allows managing multiple grep buffers.")
(license license:gpl3+)))
+(define-public emacs-rg
+ (package
+ (name "emacs-rg")
+ (version "1.8.1")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/dajva/rg.el.git")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "0k7x5z7mh9flwih35cqy8chs54rack3nswdcpw5wcpgv6xim227y"))))
+ (build-system emacs-build-system)
+ (propagated-inputs
+ `(("emacs-s" ,emacs-s)
+ ("emacs-wgrep" ,emacs-wgrep)
+ ("ripgrep" ,ripgrep)))
+ (home-page "https://rgel.readthedocs.io/en/latest/")
+ (synopsis "Search tool based on @code{ripgrep}")
+ (description
+ "@code{rg} is an Emacs search package based on the @code{ripgrep} command
+line tool. It allows one to interactively search based on the editing context
+then refine or modify the search results.")
+ (license license:gpl3+)))
+
(define-public emacs-inf-ruby
(package
(name "emacs-inf-ruby")
--
2.25.0
next prev parent reply other threads:[~2020-02-02 14:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 20:28 [bug#39384] [PATCH] gnu: Add emacs-rg LaFreniere, Joseph
2020-02-01 22:09 ` Nicolas Goaziou
2020-02-02 14:21 ` LaFreniere, Joseph [this message]
2020-02-02 18:47 ` Efraim Flashner
2020-02-03 3:41 ` LaFreniere, Joseph
2020-02-04 9:58 ` Efraim Flashner
2020-02-05 3:08 ` LaFreniere, Joseph
2020-02-05 7:13 ` Efraim Flashner
2020-02-05 21:33 ` Marius Bakke
2020-02-07 0:47 ` LaFreniere, Joseph
2020-02-07 10:54 ` Efraim Flashner
2020-02-08 22:23 ` LaFreniere, Joseph
2020-02-09 13:28 ` Efraim Flashner
2020-02-22 23:08 ` LaFreniere, Joseph
2020-02-23 11:17 ` bug#39384: " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnexrrwf.fsf@lafreniere.xyz \
--to=joseph@lafreniere.xyz \
--cc=39384@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.