From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:60498) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyG9Q-00014V-1t for guix-patches@gnu.org; Sun, 02 Feb 2020 09:23:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iyG9O-0002ni-S1 for guix-patches@gnu.org; Sun, 02 Feb 2020 09:23:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:33704) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iyG9O-0002mr-Js for guix-patches@gnu.org; Sun, 02 Feb 2020 09:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iyG9O-0002j3-H3 for guix-patches@gnu.org; Sun, 02 Feb 2020 09:23:02 -0500 Subject: [bug#39384] [PATCH] gnu: Add emacs-rg. Resent-Message-ID: References: <87v9oqrr0q.fsf@lafreniere.xyz> <878slmc640.fsf@nicolasgoaziou.fr> From: "LaFreniere\, Joseph" In-reply-to: <878slmc640.fsf@nicolasgoaziou.fr> Date: Sun, 02 Feb 2020 08:21:52 -0600 Message-ID: <87pnexrrwf.fsf@lafreniere.xyz> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Nicolas Goaziou Cc: 39384@debbugs.gnu.org --=-=-= Content-Type: text/plain; format=flowed Thank you for the fast feedback! Nicolas Goaziou writes: > Nitpick: I think the trend is to align `base32' with the string. > You may want to lint your package. In particular, the synopsis > should be > akin to "Search tool based ..." > The description must start with a full sentence, e.g., "rg.el" > is an > Emacs search package... > Texinfo requires two spaces after the full stop. > Ditto. Besides, the quote after "users" looks suspicious. You > should use > a regular quote. A patch file is attached that addresses all of the above feedback. The output of `guix lint emacs-rg` is now clean on my system; thank you for making me aware of that utility. The only part of the package I'm uncertain about is declaring ripgrep as a propagated dependency. ripgrep is not needed for this Emacs package to be able to byte-compile successfully, but `rg` does not need to be on PATH for the package to be useful at all. So while I imagine the majority of the uses-cases would want to have ripgrep installed locally, it's definitely plausible that one could only ever want to use emacs-rg via TRAMP in which case pulling in ripgrep would be completely unnecessary. Please let me know what you think. -- Joseph LaFreniere --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Add-emacs-rg.patch >From 9a17c333ceee4bb72dcb1ee36aaf45a7d2ce4276 Mon Sep 17 00:00:00 2001 From: Joseph LaFreniere Date: Sat, 1 Feb 2020 14:23:36 -0600 Subject: [PATCH] gnu: Add emacs-rg. * gnu/packages/emacs-xyz.scm (emacs-rg): New variable. --- gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index f95ad26e4b..29928364e0 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -134,6 +134,7 @@ #:use-module (gnu packages package-management) #:use-module (gnu packages perl) #:use-module (gnu packages pdf) + #:use-module (gnu packages rust-apps) #:use-module (gnu packages scheme) #:use-module (gnu packages speech) #:use-module (gnu packages xiph) @@ -2751,6 +2752,32 @@ column by drawing a thin line down the length of the editing window.") "This Emacs package allows managing multiple grep buffers.") (license license:gpl3+))) +(define-public emacs-rg + (package + (name "emacs-rg") + (version "1.8.1") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/dajva/rg.el.git") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0k7x5z7mh9flwih35cqy8chs54rack3nswdcpw5wcpgv6xim227y")))) + (build-system emacs-build-system) + (propagated-inputs + `(("emacs-s" ,emacs-s) + ("emacs-wgrep" ,emacs-wgrep) + ("ripgrep" ,ripgrep))) + (home-page "https://rgel.readthedocs.io/en/latest/") + (synopsis "Search tool based on @code{ripgrep}") + (description + "@code{rg} is an Emacs search package based on the @code{ripgrep} command +line tool. It allows one to interactively search based on the editing context +then refine or modify the search results.") + (license license:gpl3+))) + (define-public emacs-inf-ruby (package (name "emacs-inf-ruby") -- 2.25.0 --=-=-=--