bug#46737: Services breakage from the PostgreSQL socket-directory configuration change

bug#46737: Services breakage from the PostgreSQL socket-directory configuration change

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

Hey,

When reconfiguring recently, I ran in to issues with the Guix Data
Service and probably the Patchwork service too.

Looking at the change, I think it's clear there's a problem, because
some system tests were changed, and I'm guessing they were changed so
that they passed [1].

1: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6c0679215f4ffa534c1eb2e8c8a6e043a0c993fe

Passing tests are good, but working around real issues in tests is not,
because that means that the situation outside of the tests can break and
if it does, the test result is misleading.

Patchwork, the Guix Data Service and maybe other things currently depend
on the default behaviour of PostgreSQL to find the socket. Given that
the service now uses a different (non-default) value, they don't
work.

One workaround, the one employed in the tests is to revert to the old
behaviour for the PostgreSQL service by setting socket-directory to #f.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

bug#46737: Services breakage from the PostgreSQL socket-directory configuration change

[Mathieu Othacehe]

Hello Chris,

> One workaround, the one employed in the tests is to revert to the old
> behaviour for the PostgreSQL service by setting socket-directory to #f.

You're right, sorry about the breakage. As you noticed we are in an
in-between situation where the patch updating Postgresql package to use
"/var/run/postgresql" by default is only on core-updates, but the
service is already using it as a default on master.

This means that "createdb", "dropdb" and other Postgresql user tools
need to have an explicit "-h /var/run/postgresql" argument for now.

Until the package patch gets merged in the master branch, we could set
the "socket-directory" field of <postgresql-config-file> record to #f to
restore an acceptable default behaviour.

WDYT?

Sorry again for breaking things,

Mathieu

bug#46737: Services breakage from the PostgreSQL socket-directory configuration change

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]


Mathieu Othacehe <othacehe@gnu.org> writes:

>> One workaround, the one employed in the tests is to revert to the old
>> behaviour for the PostgreSQL service by setting socket-directory to #f.
>
> You're right, sorry about the breakage. As you noticed we are in an
> in-between situation where the patch updating Postgresql package to use
> "/var/run/postgresql" by default is only on core-updates, but the
> service is already using it as a default on master.
>
> This means that "createdb", "dropdb" and other Postgresql user tools
> need to have an explicit "-h /var/run/postgresql" argument for now.
>
> Until the package patch gets merged in the master branch, we could set
> the "socket-directory" field of <postgresql-config-file> record to #f to
> restore an acceptable default behaviour.
>
> WDYT?

I think that would be good. It's unfortunate that the package change is
stuck on core-updates for now, but configuring the service on master to
keep the old behaviour until core-updates is merged sounds sensible.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

bug#46737: Services breakage from the PostgreSQL socket-directory configuration change

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 1287 bytes --]


Christopher Baines <mail@cbaines.net> writes:

> Mathieu Othacehe <othacehe@gnu.org> writes:
>
>>> One workaround, the one employed in the tests is to revert to the old
>>> behaviour for the PostgreSQL service by setting socket-directory to #f.
>>
>> You're right, sorry about the breakage. As you noticed we are in an
>> in-between situation where the patch updating Postgresql package to use
>> "/var/run/postgresql" by default is only on core-updates, but the
>> service is already using it as a default on master.
>>
>> This means that "createdb", "dropdb" and other Postgresql user tools
>> need to have an explicit "-h /var/run/postgresql" argument for now.
>>
>> Until the package patch gets merged in the master branch, we could set
>> the "socket-directory" field of <postgresql-config-file> record to #f to
>> restore an acceptable default behaviour.
>>
>> WDYT?
>
> I think that would be good. It's unfortunate that the package change is
> stuck on core-updates for now, but configuring the service on master to
> keep the old behaviour until core-updates is merged sounds sensible.

I don't know if the expectation was that I was going to fix this, but
since it seems there's a release coming up, I went ahead and prepared a
patch [1].

1: https://issues.guix.gnu.org/47736

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

bug#46737: Services breakage from the PostgreSQL socket-directory configuration change

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1516 bytes --]

On Mon, Apr 12, 2021 at 09:47:45PM +0100, Christopher Baines wrote:
> 
> Christopher Baines <mail@cbaines.net> writes:
> 
> > Mathieu Othacehe <othacehe@gnu.org> writes:
> >
> >>> One workaround, the one employed in the tests is to revert to the old
> >>> behaviour for the PostgreSQL service by setting socket-directory to #f.
> >>
> >> You're right, sorry about the breakage. As you noticed we are in an
> >> in-between situation where the patch updating Postgresql package to use
> >> "/var/run/postgresql" by default is only on core-updates, but the
> >> service is already using it as a default on master.
> >>
> >> This means that "createdb", "dropdb" and other Postgresql user tools
> >> need to have an explicit "-h /var/run/postgresql" argument for now.
> >>
> >> Until the package patch gets merged in the master branch, we could set
> >> the "socket-directory" field of <postgresql-config-file> record to #f to
> >> restore an acceptable default behaviour.
> >>
> >> WDYT?
> >
> > I think that would be good. It's unfortunate that the package change is
> > stuck on core-updates for now, but configuring the service on master to
> > keep the old behaviour until core-updates is merged sounds sensible.
> 
> I don't know if the expectation was that I was going to fix this, but
> since it seems there's a release coming up, I went ahead and prepared a
> patch [1].
> 
> 1: https://issues.guix.gnu.org/47736

I pushed your patch as c311147bd16aa0e5746d9cbf31502f5fd61e470c

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]