* Introduce packages/chess.el
@ 2017-01-07 19:37 Stefan Reichör
2017-01-11 21:29 ` Stefan Reichör
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Reichör @ 2017-01-07 19:37 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 307 bytes --]
Hi there,
I would like to add some chess related packages to GUIX.
I found the packages xboard and chess that are already covered by GUIX.
The attached patch moves these two packages to a new file named chess.scm
I would like to add some more chess related packages to chess.scm in the future.
Stefan.
[-- Attachment #2: 0001-gnu-chess-xboard-Move-to-gnu-packages-chess.patch --]
[-- Type: text/x-diff, Size: 6527 bytes --]
From 7fb3eba51f0919a2e1c9b13ecb4ff77757bf4267 Mon Sep 17 00:00:00 2001
From: Stefan Reichoer <stefan@xsteve.at>
Date: Sat, 7 Jan 2017 20:30:14 +0100
Subject: [PATCH] gnu: chess, xboard: Move to (gnu packages chess).
* gnu/packages/games.scm: Move 'chess', 'xboard' to...
* gnu/packages/chess.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add chess.scm.
---
gnu/local.mk | 1 +
gnu/packages/chess.scm | 77 ++++++++++++++++++++++++++++++++++++++++++++++++++
gnu/packages/games.scm | 49 --------------------------------
3 files changed, 78 insertions(+), 49 deletions(-)
create mode 100644 gnu/packages/chess.scm
diff --git a/gnu/local.mk b/gnu/local.mk
index 1889a0e..b043f41 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -69,6 +69,7 @@ GNU_SYSTEM_MODULES = \
%D%/packages/c.scm \
%D%/packages/calcurse.scm \
%D%/packages/ccache.scm \
+ %D%/packages/chess.scm \
%D%/packages/cdrom.scm \
%D%/packages/certs.scm \
%D%/packages/check.scm \
diff --git a/gnu/packages/chess.scm b/gnu/packages/chess.scm
new file mode 100644
index 0000000..28383c8
--- /dev/null
+++ b/gnu/packages/chess.scm
@@ -0,0 +1,77 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2013 John Darrington <jmd@gnu.org>
+;;; Copyright © 2016 Sou Bunnbu <iyzsong@gmail.com>
+;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages chess)
+ #:use-module ((guix licenses) #:prefix license:)
+ #:use-module (guix packages)
+ #:use-module (guix download)
+ #:use-module (gnu packages)
+ #:use-module (gnu packages gtk)
+ #:use-module (gnu packages pkg-config)
+ #:use-module (gnu packages texinfo)
+ #:use-module (guix build-system gnu))
+
+(define-public chess
+ (package
+ (name "chess")
+ (version "6.2.4")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnu/chess/gnuchess-" version
+ ".tar.gz"))
+ (sha256
+ (base32
+ "1vw2w3jwnmn44d5vsw47f8y70xvxcsz9m5msq9fgqlzjch15qhiw"))))
+ (build-system gnu-build-system)
+ (home-page "https://www.gnu.org/software/chess")
+ (synopsis "Full chess implementation")
+ (description "GNU Chess is a chess engine. It allows you to compete
+against the computer in a game of chess, either through the default terminal
+interface or via an external visual interface such as GNU XBoard.")
+ (license license:gpl3+)))
+
+(define-public xboard
+ (package
+ (name "xboard")
+ (version "4.9.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnu/xboard/xboard-" version
+ ".tar.gz"))
+ (sha256
+ (base32
+ "1mkh36xnnacnz9r00b5f9ld9309k32jv6mcavklbdnca8bl56bib"))))
+ (build-system gnu-build-system)
+ (inputs
+ `(("gtk+" ,gtk+-2)
+ ("librsvg" ,librsvg)))
+ (native-inputs
+ `(("texinfo" ,texinfo)
+ ("pkg-config" ,pkg-config)))
+ (home-page "https://www.gnu.org/software/xboard")
+ (synopsis "Graphical user interface for chess programs")
+ (description "GNU XBoard is a graphical board for all varieties of chess,
+including international chess, xiangqi (Chinese chess), shogi (Japanese chess)
+and Makruk. Several lesser-known variants are also supported. It presents a
+fully interactive graphical interface and it can load and save games in the
+Portable Game Notation.")
+ (license license:gpl3+)))
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index c449f59..2b260ca 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -327,26 +327,6 @@ settings up to 132x300 and can scroll lines all at the same rate or
asynchronously and at a user-defined speed.")
(license license:gpl2+)))
-(define-public chess
- (package
- (name "chess")
- (version "6.2.4")
- (source
- (origin
- (method url-fetch)
- (uri (string-append "mirror://gnu/chess/gnuchess-" version
- ".tar.gz"))
- (sha256
- (base32
- "1vw2w3jwnmn44d5vsw47f8y70xvxcsz9m5msq9fgqlzjch15qhiw"))))
- (build-system gnu-build-system)
- (home-page "https://www.gnu.org/software/chess")
- (synopsis "Full chess implementation")
- (description "GNU Chess is a chess engine. It allows you to compete
-against the computer in a game of chess, either through the default terminal
-interface or via an external visual interface such as GNU XBoard.")
- (license license:gpl3+)))
-
(define freedink-engine
(package
(name "freedink-engine")
@@ -428,35 +408,6 @@ exec ~a/bin/freedink -refdir ~a/share/dink\n"
("bash" ,bash)))
(native-inputs '())))
-(define-public xboard
- (package
- (name "xboard")
- (version "4.9.1")
- (source
- (origin
- (method url-fetch)
- (uri (string-append "mirror://gnu/xboard/xboard-" version
- ".tar.gz"))
- (sha256
- (base32
- "1mkh36xnnacnz9r00b5f9ld9309k32jv6mcavklbdnca8bl56bib"))))
- (build-system gnu-build-system)
- (inputs
- `(("gtk+" ,gtk+-2)
- ("librsvg" ,librsvg)))
- (native-inputs
- `(("texinfo" ,texinfo)
- ("pkg-config" ,pkg-config)))
- (home-page "https://www.gnu.org/software/xboard")
- (synopsis "Graphical user interface for chess programs")
- (description "GNU XBoard is a graphical board for all varieties of chess,
-including international chess, xiangqi (Chinese chess), shogi (Japanese chess)
-and Makruk. Several lesser-known variants are also supported. It presents a
-fully interactive graphical interface and it can load and save games in the
-Portable Game Notation.")
- (license license:gpl3+)))
-
-
(define-public xboing
(package
(name "xboing")
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: Introduce packages/chess.el
2017-01-07 19:37 Introduce packages/chess.el Stefan Reichör
@ 2017-01-11 21:29 ` Stefan Reichör
2017-01-11 23:09 ` Ricardo Wurmus
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Reichör @ 2017-01-11 21:29 UTC (permalink / raw)
To: guix-devel
Hi again!
Does someone provide feedback for this patch?
Is it useful or is increasing the number of .scm files a bad thing?
Thanks,
Stefan.
> Hi there,
>
> I would like to add some chess related packages to GUIX.
> I found the packages xboard and chess that are already covered by GUIX.
>
> The attached patch moves these two packages to a new file named chess.scm
>
> I would like to add some more chess related packages to chess.scm in the future.
>
> Stefan.
>
>
> From 7fb3eba51f0919a2e1c9b13ecb4ff77757bf4267 Mon Sep 17 00:00:00 2001
> From: Stefan Reichoer <stefan@xsteve.at>
> Date: Sat, 7 Jan 2017 20:30:14 +0100
> Subject: [PATCH] gnu: chess, xboard: Move to (gnu packages chess).
>
> * gnu/packages/games.scm: Move 'chess', 'xboard' to...
>
> * gnu/packages/chess.scm: New file.
>
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add chess.scm.
> ---
> gnu/local.mk | 1 +
> gnu/packages/chess.scm | 77 ++++++++++++++++++++++++++++++++++++++++++++++++++
> gnu/packages/games.scm | 49 --------------------------------
> 3 files changed, 78 insertions(+), 49 deletions(-)
> create mode 100644 gnu/packages/chess.scm
>
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 1889a0e..b043f41 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -69,6 +69,7 @@ GNU_SYSTEM_MODULES = \
> %D%/packages/c.scm \
> %D%/packages/calcurse.scm \
> %D%/packages/ccache.scm \
> + %D%/packages/chess.scm \
> %D%/packages/cdrom.scm \
> %D%/packages/certs.scm \
> %D%/packages/check.scm \
> diff --git a/gnu/packages/chess.scm b/gnu/packages/chess.scm
> new file mode 100644
> index 0000000..28383c8
> --- /dev/null
> +++ b/gnu/packages/chess.scm
> @@ -0,0 +1,77 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2013 John Darrington <jmd@gnu.org>
> +;;; Copyright © 2016 Sou Bunnbu <iyzsong@gmail.com>
> +;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages chess)
> + #:use-module ((guix licenses) #:prefix license:)
> + #:use-module (guix packages)
> + #:use-module (guix download)
> + #:use-module (gnu packages)
> + #:use-module (gnu packages gtk)
> + #:use-module (gnu packages pkg-config)
> + #:use-module (gnu packages texinfo)
> + #:use-module (guix build-system gnu))
> +
> +(define-public chess
> + (package
> + (name "chess")
> + (version "6.2.4")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "mirror://gnu/chess/gnuchess-" version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "1vw2w3jwnmn44d5vsw47f8y70xvxcsz9m5msq9fgqlzjch15qhiw"))))
> + (build-system gnu-build-system)
> + (home-page "https://www.gnu.org/software/chess")
> + (synopsis "Full chess implementation")
> + (description "GNU Chess is a chess engine. It allows you to compete
> +against the computer in a game of chess, either through the default terminal
> +interface or via an external visual interface such as GNU XBoard.")
> + (license license:gpl3+)))
> +
> +(define-public xboard
> + (package
> + (name "xboard")
> + (version "4.9.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "mirror://gnu/xboard/xboard-" version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "1mkh36xnnacnz9r00b5f9ld9309k32jv6mcavklbdnca8bl56bib"))))
> + (build-system gnu-build-system)
> + (inputs
> + `(("gtk+" ,gtk+-2)
> + ("librsvg" ,librsvg)))
> + (native-inputs
> + `(("texinfo" ,texinfo)
> + ("pkg-config" ,pkg-config)))
> + (home-page "https://www.gnu.org/software/xboard")
> + (synopsis "Graphical user interface for chess programs")
> + (description "GNU XBoard is a graphical board for all varieties of chess,
> +including international chess, xiangqi (Chinese chess), shogi (Japanese chess)
> +and Makruk. Several lesser-known variants are also supported. It presents a
> +fully interactive graphical interface and it can load and save games in the
> +Portable Game Notation.")
> + (license license:gpl3+)))
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index c449f59..2b260ca 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -327,26 +327,6 @@ settings up to 132x300 and can scroll lines all at the same rate or
> asynchronously and at a user-defined speed.")
> (license license:gpl2+)))
>
> -(define-public chess
> - (package
> - (name "chess")
> - (version "6.2.4")
> - (source
> - (origin
> - (method url-fetch)
> - (uri (string-append "mirror://gnu/chess/gnuchess-" version
> - ".tar.gz"))
> - (sha256
> - (base32
> - "1vw2w3jwnmn44d5vsw47f8y70xvxcsz9m5msq9fgqlzjch15qhiw"))))
> - (build-system gnu-build-system)
> - (home-page "https://www.gnu.org/software/chess")
> - (synopsis "Full chess implementation")
> - (description "GNU Chess is a chess engine. It allows you to compete
> -against the computer in a game of chess, either through the default terminal
> -interface or via an external visual interface such as GNU XBoard.")
> - (license license:gpl3+)))
> -
> (define freedink-engine
> (package
> (name "freedink-engine")
> @@ -428,35 +408,6 @@ exec ~a/bin/freedink -refdir ~a/share/dink\n"
> ("bash" ,bash)))
> (native-inputs '())))
>
> -(define-public xboard
> - (package
> - (name "xboard")
> - (version "4.9.1")
> - (source
> - (origin
> - (method url-fetch)
> - (uri (string-append "mirror://gnu/xboard/xboard-" version
> - ".tar.gz"))
> - (sha256
> - (base32
> - "1mkh36xnnacnz9r00b5f9ld9309k32jv6mcavklbdnca8bl56bib"))))
> - (build-system gnu-build-system)
> - (inputs
> - `(("gtk+" ,gtk+-2)
> - ("librsvg" ,librsvg)))
> - (native-inputs
> - `(("texinfo" ,texinfo)
> - ("pkg-config" ,pkg-config)))
> - (home-page "https://www.gnu.org/software/xboard")
> - (synopsis "Graphical user interface for chess programs")
> - (description "GNU XBoard is a graphical board for all varieties of chess,
> -including international chess, xiangqi (Chinese chess), shogi (Japanese chess)
> -and Makruk. Several lesser-known variants are also supported. It presents a
> -fully interactive graphical interface and it can load and save games in the
> -Portable Game Notation.")
> - (license license:gpl3+)))
> -
> -
> (define-public xboing
> (package
> (name "xboing")
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Introduce packages/chess.el
2017-01-11 21:29 ` Stefan Reichör
@ 2017-01-11 23:09 ` Ricardo Wurmus
2017-01-12 19:59 ` Stefan Reichör
0 siblings, 1 reply; 4+ messages in thread
From: Ricardo Wurmus @ 2017-01-11 23:09 UTC (permalink / raw)
To: Stefan Reichör; +Cc: guix-devel
Stefan Reichör <stefan@xsteve.at> writes:
> Does someone provide feedback for this patch?
> Is it useful or is increasing the number of .scm files a bad thing?
We usually avoid moving around packages unless there’s a very good
reason for it. One of the disadvantages of moving package expressions
is that it breaks existing manifest.
Could your new chess-related packages be added to games.scm instead?
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
http://elephly.net
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Introduce packages/chess.el
2017-01-11 23:09 ` Ricardo Wurmus
@ 2017-01-12 19:59 ` Stefan Reichör
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Reichör @ 2017-01-12 19:59 UTC (permalink / raw)
To: guix-devel
Ricardo Wurmus <rekado@elephly.net> writes:
> Stefan Reichör <stefan@xsteve.at> writes:
>
>> Does someone provide feedback for this patch?
>> Is it useful or is increasing the number of .scm files a bad thing?
>
> We usually avoid moving around packages unless there’s a very good
> reason for it. One of the disadvantages of moving package expressions
> is that it breaks existing manifest.
>
> Could your new chess-related packages be added to games.scm instead?
>
Thanks for your feedback.
I had serveral reasons why I started this way:
* I guessed it would be easier to do a split before adding more packages
* Classifying packages in .scm files makes them easier to find
* And it would be a commitment from me to provide these packages
However - of course I have no problem in adding them to games.scm
Stefan.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-12 20:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-07 19:37 Introduce packages/chess.el Stefan Reichör
2017-01-11 21:29 ` Stefan Reichör
2017-01-11 23:09 ` Ricardo Wurmus
2017-01-12 19:59 ` Stefan Reichör
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.