all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Oleg Pykhalov <go.wigust@gmail.com>, 30940@debbugs.gnu.org
Subject: [bug#30940] [PATCH] gnu: Add twitchy.
Date: Mon, 26 Mar 2018 20:06:17 +0200	[thread overview]
Message-ID: <87o9jaiuee.fsf@fastmail.com> (raw)
In-Reply-To: <20180325184125.17406-1-go.wigust@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

Oleg Pykhalov <go.wigust@gmail.com> writes:

> * gnu/packages/video.scm (twitchy): New public variable.

[...]
  
> +(define-public twitchy
> +  (let ((commit "0c0f925b9c7ff2aed4a3b0046561cb794143c398"))
> +    (package
> +      (name "twitchy")
> +      (version (git-version "3.2" "1" commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/BasioMeusPuga/twitchy.git")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> +           "02aizvsr744sh8bdqvwwsmp2qpczlzn8fy76h5dyd3517n9nlcz9"))))

Can you add a comment about why a git checkout is necessary?

Apart from that LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2018-03-26 18:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-25 18:41 [bug#30940] [PATCH] gnu: Add twitchy Oleg Pykhalov
2018-03-26 18:06 ` Marius Bakke [this message]
2018-03-26 19:50   ` Oleg Pykhalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9jaiuee.fsf@fastmail.com \
    --to=mbakke@fastmail.com \
    --cc=30940@debbugs.gnu.org \
    --cc=go.wigust@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.