From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35825)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f0WWP-0006Yv-AC
	for guix-patches@gnu.org; Mon, 26 Mar 2018 14:07:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f0WWM-0002W3-69
	for guix-patches@gnu.org; Mon, 26 Mar 2018 14:07:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:46818)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1f0WWM-0002Vl-2F
	for guix-patches@gnu.org; Mon, 26 Mar 2018 14:07:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f0WWL-00054K-RY
	for guix-patches@gnu.org; Mon, 26 Mar 2018 14:07:01 -0400
Subject: [bug#30940] [PATCH] gnu: Add twitchy.
Resent-Message-ID: <handler.30940.B30940.152208758119437@debbugs.gnu.org>
From: Marius Bakke <mbakke@fastmail.com>
In-Reply-To: <20180325184125.17406-1-go.wigust@gmail.com>
References: <20180325184125.17406-1-go.wigust@gmail.com>
Date: Mon, 26 Mar 2018 20:06:17 +0200
Message-ID: <87o9jaiuee.fsf@fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Oleg Pykhalov <go.wigust@gmail.com>, 30940@debbugs.gnu.org

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Oleg Pykhalov <go.wigust@gmail.com> writes:

> * gnu/packages/video.scm (twitchy): New public variable.

[...]
=20=20
> +(define-public twitchy
> +  (let ((commit "0c0f925b9c7ff2aed4a3b0046561cb794143c398"))
> +    (package
> +      (name "twitchy")
> +      (version (git-version "3.2" "1" commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/BasioMeusPuga/twitchy.git")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> +           "02aizvsr744sh8bdqvwwsmp2qpczlzn8fy76h5dyd3517n9nlcz9"))))

Can you add a comment about why a git checkout is necessary?

Apart from that LGTM.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlq5NpkACgkQoqBt8qM6
VPoa9Af/fUHY7xOk6YJGt6RanyCxBE9/m/iYQCTL7CspHbUNIY7VikYa4yPMk8Ma
Np7gEjEm/aIUd/VsO25dGwm1liBLKBjHKzDWZazWjG0F8EzTpeXqziWCkgH0ZbMh
E4hoXhwswyAAJgVvJdvlJ8riNIhzy6noneYTEp/zYA7X7ovosktz2M5LGUBiAAPd
nVG9xVNEBhmnp5BfCWM0eqkNP7Abypb2g6ER5YtJCkhenDRIzmYztDHfTegC4FUc
xf5lWAHR5TQBjMejaO6QZ4jHALg8oqzOn+pUpUgcRniT1zBBrRj9/IyoNhvJnEPI
p5kjhgvIAOtNvHsrzJHFKoFZEUkfEg==
=VtH8
-----END PGP SIGNATURE-----
--=-=-=--