From: Christopher Baines <mail@cbaines.net>
To: Leo Famulari <leo@famulari.name>
Cc: 33042@debbugs.gnu.org
Subject: [bug#33042] [PATCH] gnu: Add soundconverter.
Date: Fri, 19 Oct 2018 15:05:35 +0100 [thread overview]
Message-ID: <87o9bqav68.fsf@cbaines.net> (raw)
In-Reply-To: <20181016164327.GC25057@jasmine.lan>
[-- Attachment #1: Type: text/plain, Size: 2652 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Sun, Oct 14, 2018 at 09:18:10PM +0100, Christopher Baines wrote:
>> * gnu/packages/gnome.scm (soundconverter): New variable.
>
> Thanks, it's nice to have graphical programs for this sort of task :)
Yeah, thanks for taking a look. I've sent an updated patch :)
>> + (patches
>> + (list
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://salsa.debian.org/multimedia-team/soundconverter"
>> + "/raw/master/debian/patches/"
>> + "0002-Only-fetch-profiles-if-GConf-is-still-available.patch"))
>> + (sha256
>> + (base32
>> + "00nxpbkz7ihzrbz91ms7bd2mjgyhkbxpaa8zxj4xnkv4pjmg61hh")))))))
>
> I think it's better if we include this file in our source code, since
> it's not very big and Debian's code infrastructure URLs seem to change
> every few years. Also, the URL is not versioned, so maybe the patch
> would change in the future.
Sure, I've included the file now. This patch has been merged upstream,
so hopefully it can be removed here when the next release comes out.
>> + (add-after 'unpack 'fix-POTFILES.in
>> + (lambda _
>> + (substitute* "po/POTFILES.in"
>> + (("soundconverter/gconfstore\\.py") ""))))
>
> Please add an explanatory comment for this.
I have done. This has also been fixed upstream, so hopefully can also be
removed on the next release.
>> + (add-after 'install 'wrap-rhythmbox
>> + (lambda* (#:key inputs outputs #:allow-other-keys)
>> + (let ((out (assoc-ref outputs "out"))
>> + (python-path (getenv "PYTHONPATH"))
>> + (gi-typelib-path (getenv "GI_TYPELIB_PATH"))
>> + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
>> + (wrap-program (string-append out "/bin/soundconverter")
>> + `("PYTHONPATH" ":" prefix (,python-path))
>> + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))
>> + `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path))))
>> + #t)))))
>
> If possible, I think it's better to use the python-build-system's wrap
> phase for PYTHONPATH. The hplip package has an example.
I've changed this now.
>> + (synopsis "Audio file converter for the GNOME Desktop")
>
> It works in i3, too :)
I couldn't quite work out how better to get across that it's a graphical
application, as compared to a command line tool. But, as you say, it's
not specific to GNOME.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
next prev parent reply other threads:[~2018-10-19 14:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-14 20:18 [bug#33042] [PATCH] gnu: Add soundconverter Christopher Baines
2018-10-16 16:43 ` Leo Famulari
2018-10-19 14:05 ` Christopher Baines [this message]
2018-10-19 20:08 ` Leo Famulari
2018-10-20 11:31 ` bug#33042: " Christopher Baines
2018-10-21 19:20 ` [bug#33042] " Leo Famulari
2018-10-19 13:43 ` Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9bqav68.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=33042@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.