From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDVPi-0000DW-RA for guix-patches@gnu.org; Fri, 19 Oct 2018 10:06:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDVPe-000514-P3 for guix-patches@gnu.org; Fri, 19 Oct 2018 10:06:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55376) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gDVPe-00050h-JR for guix-patches@gnu.org; Fri, 19 Oct 2018 10:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gDVPe-0002PB-9S for guix-patches@gnu.org; Fri, 19 Oct 2018 10:06:02 -0400 Subject: [bug#33042] [PATCH] gnu: Add soundconverter. Resent-Message-ID: References: <20181014201810.619-1-mail@cbaines.net> <20181016164327.GC25057@jasmine.lan> From: Christopher Baines In-reply-to: <20181016164327.GC25057@jasmine.lan> Date: Fri, 19 Oct 2018 15:05:35 +0100 Message-ID: <87o9bqav68.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 33042@debbugs.gnu.org --=-=-= Content-Type: text/plain Leo Famulari writes: > On Sun, Oct 14, 2018 at 09:18:10PM +0100, Christopher Baines wrote: >> * gnu/packages/gnome.scm (soundconverter): New variable. > > Thanks, it's nice to have graphical programs for this sort of task :) Yeah, thanks for taking a look. I've sent an updated patch :) >> + (patches >> + (list >> + (origin >> + (method url-fetch) >> + (uri (string-append >> + "https://salsa.debian.org/multimedia-team/soundconverter" >> + "/raw/master/debian/patches/" >> + "0002-Only-fetch-profiles-if-GConf-is-still-available.patch")) >> + (sha256 >> + (base32 >> + "00nxpbkz7ihzrbz91ms7bd2mjgyhkbxpaa8zxj4xnkv4pjmg61hh"))))))) > > I think it's better if we include this file in our source code, since > it's not very big and Debian's code infrastructure URLs seem to change > every few years. Also, the URL is not versioned, so maybe the patch > would change in the future. Sure, I've included the file now. This patch has been merged upstream, so hopefully it can be removed here when the next release comes out. >> + (add-after 'unpack 'fix-POTFILES.in >> + (lambda _ >> + (substitute* "po/POTFILES.in" >> + (("soundconverter/gconfstore\\.py") "")))) > > Please add an explanatory comment for this. I have done. This has also been fixed upstream, so hopefully can also be removed on the next release. >> + (add-after 'install 'wrap-rhythmbox >> + (lambda* (#:key inputs outputs #:allow-other-keys) >> + (let ((out (assoc-ref outputs "out")) >> + (python-path (getenv "PYTHONPATH")) >> + (gi-typelib-path (getenv "GI_TYPELIB_PATH")) >> + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH"))) >> + (wrap-program (string-append out "/bin/soundconverter") >> + `("PYTHONPATH" ":" prefix (,python-path)) >> + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)) >> + `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))) >> + #t))))) > > If possible, I think it's better to use the python-build-system's wrap > phase for PYTHONPATH. The hplip package has an example. I've changed this now. >> + (synopsis "Audio file converter for the GNOME Desktop") > > It works in i3, too :) I couldn't quite work out how better to get across that it's a graphical application, as compared to a command line tool. But, as you say, it's not specific to GNOME. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlvJ5K9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdYuxAAseLAJfzRvqU8g6SBmPNZghA9J49cf1mfqzFw+KerEqKkDE/TtC+iyTEQ 8F9gkqxT2YZIpG0sIoqv/FK+6RJ4+q+9RUN+G33uul5rTp56YEjDuHT2Hc+pmIR2 xQei5eJZE6ccIH8P2RzEbHUHKvuzBQB6iaCgmO3v0CPXsQTN6qwv3I+Ap1rYl0aW HYijzgXfBX0ddgmlOqf8cmlkmTmpK8WoI9BS9imLSM+4S0r8y0x0876+RygOgtEq J8f3MyVlbIiXOdDNk0iuiplzIn4dJ1TlOwFfzSdqiDg42loyHP3YO6zdrcKK+u1E nypkiQ3TIEfoCjDzIDadSrxTIcP3cKTanfMeAJXSxvp71W4OEMKK1gtD9ZK4G+YA mrEEerTZza616KiU/wi1Tdc0VQOm8eNqu+JUnvC+fi4eBZjUDrWQM4cZ0nvWqToS ZbyAhB1kboBdDpFvS6h1HMonSVY67h1Y4rdo4n4bq2rbyCp89d1ldlsaG3h/W7z5 1P3PnM6IS5Su8bQZrzGKnY775zC2JY5afntN6bs2YclD7YwZN3Svs0tX/Cn3RDJ6 ODXnIlvuDKrNcEzpE/VpDcNvQl+CCullbU660p1x6sPJZHJLyZLPbLapu40sEdBc Tg+RoURke9dTcwdAAakgKQv8uqooM/qfSU2YCUiAX4SAh24tRSs= =jlYA -----END PGP SIGNATURE----- --=-=-=--