From: "Clément Lassieur" <clement@lassieur.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 33386-done@debbugs.gnu.org
Subject: bug#33386: [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugins.
Date: Tue, 11 Dec 2018 11:22:14 +0100 [thread overview]
Message-ID: <87o99s8isp.fsf@lassieur.org> (raw)
In-Reply-To: <878t1pjbs3.fsf@lassieur.org>
Clément Lassieur <clement@lassieur.org> writes:
> Danny Milosavljevic <dannym@scratchpost.org> writes:
>
>> Hi Clément,
>>
>>> I don't understand what this means.
>>> > I thought one can use any number of profiles - and this patch could
>>> > definitely pick from the wrong one.
>>>
>>> What do you mean? This patch just adds the Guix packaged plugins to the
>>> list of plugin dirs.
>>
>> guix supports any number of profiles as one user, the ~/.guix-profile one is just
>> the default, you can create and select profiles at will.
>>
>> You can specify any profile you want using the option "-p" to "guix package" -
>> also, "guix environment" will create a custom profile.
>>
>> However, your patch hardcodes ~/.guix-profile which is in general not what a user
>> using "-p" would want. I agree that it makes sense to search for the plugins in
>> the current profile, but it's not clear to me that ~/.guix-profile is always
>> guaranteed to BE the current profile. Is it?
>>
>> According to https://www.gnu.org/software/guix/manual/en/html_node/Invoking-guix-environment.html#FOOT16 ,
>> fontconfig already hardcodes ~/.guix-profile and "guix environment" has a
>> special flag to fake it, so maybe (probably?) it's OK to use it after all.
>>
>> I hope someone else can chime in - but this is what immediately caught my
>> eye because what's the use of all these environment variables if one
>> hard-codes ~/.guix-profile anyway - could have hard-coded it in all packages,
>> then...
>
> Understood, thanks for this nice explanation!
>
> I attached a new patch. What do you think?
I pushed it. I'll be happy to improve it if you have other comments.
Thanks,
Clément
next prev parent reply other threads:[~2018-12-11 10:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 19:54 [bug#33386] Gajim plugins Clément Lassieur
2018-11-14 19:55 ` [bug#33386] [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugins Clément Lassieur
2018-11-14 19:55 ` [bug#33386] [PATCH 2/2] gnu: Add gajim-omemo Clément Lassieur
2018-11-15 18:19 ` [bug#33386] [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugins Danny Milosavljevic
2018-11-16 10:13 ` Clément Lassieur
2018-11-18 23:15 ` Danny Milosavljevic
2018-11-19 16:01 ` [bug#33386] [PATCH] " Clément Lassieur
2018-11-19 16:02 ` [bug#33386] [PATCH 1/2] " Clément Lassieur
2018-12-11 10:22 ` Clément Lassieur [this message]
2018-11-14 19:57 ` [bug#33386] Gajim plugins Clément Lassieur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o99s8isp.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=33386-done@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.