From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gWfBz-00046f-6j for guix-patches@gnu.org; Tue, 11 Dec 2018 05:23:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gWfBv-00072X-8d for guix-patches@gnu.org; Tue, 11 Dec 2018 05:23:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:38564) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gWfBu-00071W-5I for guix-patches@gnu.org; Tue, 11 Dec 2018 05:23:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gWfBu-0004As-0u for guix-patches@gnu.org; Tue, 11 Dec 2018 05:23:02 -0500 Subject: bug#33386: [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugins. Resent-To: guix-patches@gnu.org Resent-Message-ID: References: <87d0r7e8ox.fsf@lassieur.org> <20181114195553.27293-1-clement@lassieur.org> <20181115191903.7f3db09b@scratchpost.org> <87efblz5w9.fsf@lassieur.org> <20181119001555.2a18946d@scratchpost.org> <878t1pjbs3.fsf@lassieur.org> From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-reply-to: <878t1pjbs3.fsf@lassieur.org> Date: Tue, 11 Dec 2018 11:22:14 +0100 Message-ID: <87o99s8isp.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 33386-done@debbugs.gnu.org Cl=C3=A9ment Lassieur writes: > Danny Milosavljevic writes: > >> Hi Cl=C3=A9ment, >> >>> I don't understand what this means. >>> > I thought one can use any number of profiles - and this patch could >>> > definitely pick from the wrong one.=20=20 >>>=20 >>> What do you mean? This patch just adds the Guix packaged plugins to the >>> list of plugin dirs. >> >> guix supports any number of profiles as one user, the ~/.guix-profile on= e is just >> the default, you can create and select profiles at will. >> >> You can specify any profile you want using the option "-p" to "guix pack= age" - >> also, "guix environment" will create a custom profile. >> >> However, your patch hardcodes ~/.guix-profile which is in general not wh= at a user >> using "-p" would want. I agree that it makes sense to search for the pl= ugins in >> the current profile, but it's not clear to me that ~/.guix-profile is al= ways >> guaranteed to BE the current profile. Is it? >> >> According to https://www.gnu.org/software/guix/manual/en/html_node/Invok= ing-guix-environment.html#FOOT16 , >> fontconfig already hardcodes ~/.guix-profile and "guix environment" has a >> special flag to fake it, so maybe (probably?) it's OK to use it after al= l. >> >> I hope someone else can chime in - but this is what immediately caught my >> eye because what's the use of all these environment variables if one >> hard-codes ~/.guix-profile anyway - could have hard-coded it in all pack= ages, >> then... > > Understood, thanks for this nice explanation! > > I attached a new patch. What do you think? I pushed it. I'll be happy to improve it if you have other comments. Thanks, Cl=C3=A9ment