Re: Guile-Git & delayed ‘dynamic-link’ calls

Re: Guile-Git & delayed ‘dynamic-link’ calls

[Mathieu Othacehe]

Hey,

I noticed a regression with the patch da54721b1bd221. When using
set-fetch-auth-with-ssh-agent! function, I have the following error:

--8<---------------cut here---------------start------------->8---
ERROR: Wrong type (expecting exact integer): 0
--8<---------------cut here---------------end--------------->8---

Applying the following patch:

--8<---------------cut here---------------start------------->8---
diff --git a/git/fetch.scm b/git/fetch.scm
index da18bbe..a213859 100644
--- a/git/fetch.scm
+++ b/git/fetch.scm
@@ -52,8 +52,8 @@
    fetch-options
    (cred-acquire-cb
     (lambda (cred url username allowed payload)
-      (cred-ssh-key-from-agent cred
-                               (pointer->string username))))))
+      (+ 0 (cred-ssh-key-from-agent cred
+                                    (pointer->string username)))))))
--8<---------------cut here---------------end--------------->8---

the problem is fixed. It seems that the return of
cred-ssh-key-from-agent is not detected as an integer (because of
"catch" function used in libgit2->procedure?). Doing something like:

--8<---------------cut here---------------start------------->8---
diff --git a/git/bindings.scm b/git/bindings.scm
index 88be550..8e15715 100644
--- a/git/bindings.scm
+++ b/git/bindings.scm
@@ -56,16 +56,18 @@
                (list ENOSYS))))))
 
 (define (libgit2->procedure return name params)
+  (define res 0)
   (catch #t
     (lambda ()
       (let ((ptr (dynamic-func name (dynamic-link %libgit2))))
         ;; The #:return-errno? facility was introduced in Guile 2.0.12.
-        (pointer->procedure return ptr params
-                            #:return-errno? #t)))
+        (set! res (pointer->procedure return ptr params
+                                      #:return-errno? #t))))
     (lambda args
       (lambda _
         (throw 'system-error name  "~A" (list (strerror ENOSYS))
-               (list ENOSYS))))))
+               (list ENOSYS)))))
+  res)
--8<---------------cut here---------------end--------------->8---

also fixes the problem.

Does anywone understands what's going on here?

Thanks,

Mathieu
 

Re: Guile-Git & delayed ‘dynamic-link’ calls

[Mathieu Othacehe]

> Does anywone understands what's going on here?

Found it! It's the #:return-errno passed to pointer->procedure that
makes every call to libgit2->procedure return two values.

The second one (the errno) was silently ignored. I'll propose a patch
soon.

Mathieu

Re: Guile-Git & delayed ‘dynamic-link’ calls

[Ludovic Courtès]

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

>> Does anywone understands what's going on here?
>
> Found it! It's the #:return-errno passed to pointer->procedure that
> makes every call to libgit2->procedure return two values.
>
> The second one (the errno) was silently ignored. I'll propose a patch
> soon.

Oh, great that you found it!

Ludo’.