From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 53060@debbugs.gnu.org
Subject: [bug#53060] [PATCH 0/2] Allow the github updater to update git sources
Date: Mon, 17 Jan 2022 14:13:11 +0100 [thread overview]
Message-ID: <87o84apkt4.fsf@gnu.org> (raw)
In-Reply-To: <92f867a635d71b427a97012e308ed6578b3db4f4.camel@telenet.be> (Maxime Devos's message of "Mon, 17 Jan 2022 10:12:46 +0000")
Hi,
Maxime Devos <maximedevos@telenet.be> skribis:
> tests/cpan.scm uses 'with-http-server', which I do not find ideal
> because the answers the HTTP server gives depend on the order the
> HTTP server was queried, without verifying the URI. Mocking
> 'http-fetch' allows me not to worry about ordering and allows verifying
> the URI.
Good point.
> It might be possible to modify 'with-http-server' into something
> (with-http-server*?) that allows looking at the HTTP headers and URI
> and dynamically generate a response based on that.
Yes, that’d be great.
> Due to the mocking, %github-api isn't truly necessary, but having
> "https://api.github.com" in a single location helps avoiding typos
> like writing "http://" instead of "https://" somewhere, or adjusting
> the domain name if GitHub decided to change it for whatever reason
> (hopefully unlikely?), or if Tor becomes very popular among the general
> public and GitHub has an ".onion" address, then it could be changed to
> the ".onion" address easily, ...
Yes, and also, setting ‘%github-api’ makes sure we don’t inadvertently
talk to the real GitHub (there was a bug along these lines in the tests
of one of the importers a while back.)
Thanks,
Ludo’.
prev parent reply other threads:[~2022-01-17 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 20:48 [bug#53060] [PATCH 0/2] Allow the github updater to update git sources Maxime Devos
2022-01-06 20:50 ` [bug#53060] [PATCH 1/2] import/github: Return <git-reference> objects for git-fetch origins Maxime Devos
2022-01-06 20:50 ` [bug#53060] [PATCH 2/2] import/github: Test it Maxime Devos
2022-01-16 22:19 ` [bug#53060] [PATCH 0/2] Allow the github updater to update git sources Ludovic Courtès
2022-01-17 10:12 ` Maxime Devos
2022-01-17 13:13 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o84apkt4.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=53060@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.