From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WNAgB31y5WFEAAEAgWs5BA (envelope-from ) for ; Mon, 17 Jan 2022 14:43:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6OtoBH1y5WHKNAEA9RJhRA (envelope-from ) for ; Mon, 17 Jan 2022 14:43:25 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BC0983BB7F for ; Mon, 17 Jan 2022 14:43:24 +0100 (CET) Received: from localhost ([::1]:58618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9SI7-0001mC-US for larch@yhetil.org; Mon, 17 Jan 2022 08:43:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9Rpi-0002Je-GL for guix-patches@gnu.org; Mon, 17 Jan 2022 08:14:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:52229) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n9Rph-0006jR-Mm for guix-patches@gnu.org; Mon, 17 Jan 2022 08:14:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n9Rph-0004ZG-JM for guix-patches@gnu.org; Mon, 17 Jan 2022 08:14:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53060] [PATCH 0/2] Allow the github updater to update git sources Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 17 Jan 2022 13:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 53060@debbugs.gnu.org Received: via spool by 53060-submit@debbugs.gnu.org id=B53060.164242520017459 (code B ref 53060); Mon, 17 Jan 2022 13:14:01 +0000 Received: (at 53060) by debbugs.gnu.org; 17 Jan 2022 13:13:20 +0000 Received: from localhost ([127.0.0.1]:45123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9Rp1-0004XX-Ma for submit@debbugs.gnu.org; Mon, 17 Jan 2022 08:13:19 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:43430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9Roz-0004XF-LY for 53060@debbugs.gnu.org; Mon, 17 Jan 2022 08:13:18 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 448A552F; Mon, 17 Jan 2022 14:13:12 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lC-1nE73ZeKf; Mon, 17 Jan 2022 14:13:11 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 7B9504C4; Mon, 17 Jan 2022 14:13:11 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <538acb9dc52f6992a5a65846db48f8b7382fb1be.camel@telenet.be> <87wnizz5kr.fsf@gnu.org> <92f867a635d71b427a97012e308ed6578b3db4f4.camel@telenet.be> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 =?UTF-8?Q?Niv=C3=B4se?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 17 Jan 2022 14:13:11 +0100 In-Reply-To: <92f867a635d71b427a97012e308ed6578b3db4f4.camel@telenet.be> (Maxime Devos's message of "Mon, 17 Jan 2022 10:12:46 +0000") Message-ID: <87o84apkt4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: 448A552F X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642427004; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=XedCs0TUP+gqJbVggwj4T4tdE3uISN3fu3YAknAJjFY=; b=YejwZe/v2jDDm3tGdZT0HqgwCEPUcZcwLCUN68NHE7bpIh3N5eM7Y7SR8GirAAIXnmXmiF sKFPkEbXc2AyZtxtTBgRRc6Yh3ML1YRNNJ2Arv9yNjCRKOGuCVCHJprqIwXxpEx+tABIxc +HNifVhc3wLWewDVz1cqAgytD5YuTNx2LrPSa7/JYzkn+//X+KBZQLTLl1u63mejZMDDmH tGdMaAbizmqcBsCBYM/ql22daOjoBGTIscu1xFiHjC7QRwAZD2t5/SwW4NaA3sTKvjOwo9 1tmEhra50CCx0nUDhERIclAZJBdKye7e0Eyher0qjEuA3aqjG5yR0uty1pn5WQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642427004; a=rsa-sha256; cv=none; b=kipnI3YZALff+QHgoXL2YvEldZBekR2sRjglQZ0rTy9htCG83kPu3biBo8ANX9BQrWMVKP 05z1q2Ojlu4fwn2zJ/1nC2SfB5ECXfhOw5GIUQj3Mpal7tKjvUSxXLmx5gRg/MHGvo8f2T brt7qG8KBxtROOfD6ruawURNcwkH4IT0e9GdusYEDMw6dz2cIbFVpRa3o2fb5DZM7Kwv/W tUpPLahXl2KPUUNHPZ50GAk6ZKhAVSub3uRV2J2ijNnI21383bewgMNybQ/+WPtwcLxGZ0 T7NaVwS46LJgO2aiqQjGSgMurTe+OHCn9SSNOitI5gdgPCnoaPeYziNThZS0kQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.62 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BC0983BB7F X-Spam-Score: -3.62 X-Migadu-Scanner: scn1.migadu.com X-TUID: +PwajXKx4RNA Hi, Maxime Devos skribis: > tests/cpan.scm uses 'with-http-server', which I do not find ideal > because the answers the HTTP server gives depend on the order the > HTTP server was queried, without verifying the URI. Mocking > 'http-fetch' allows me not to worry about ordering and allows verifying > the URI. Good point. > It might be possible to modify 'with-http-server' into something > (with-http-server*?) that allows looking at the HTTP headers and URI > and dynamically generate a response based on that. Yes, that=E2=80=99d be great. > Due to the mocking, %github-api isn't truly necessary, but having > "https://api.github.com" in a single location helps avoiding typos > like writing "http://" instead of "https://" somewhere, or adjusting > the domain name if GitHub decided to change it for whatever reason > (hopefully unlikely?), or if Tor becomes very popular among the general > public and GitHub has an ".onion" address, then it could be changed to > the ".onion" address easily, ... Yes, and also, setting =E2=80=98%github-api=E2=80=99 makes sure we don=E2= =80=99t inadvertently talk to the real GitHub (there was a bug along these lines in the tests of one of the importers a while back.) Thanks, Ludo=E2=80=99.