From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Mathieu Othacehe <othacehe@gnu.org>, guix-devel <guix-devel@gnu.org>
Subject: Re: configurable guile backtrace in builder
Date: Wed, 08 Feb 2023 11:09:57 -0500 [thread overview]
Message-ID: <87o7q4jfze.fsf@gmail.com> (raw)
In-Reply-To: <87357gzebc.fsf@gnu.org> ("Ludovic Courtès"'s message of "Wed, 08 Feb 2023 10:39:19 +0100")
Hello,
Ludovic Courtès <ludo@gnu.org> writes:
> Hi Maxim,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>
> [...]
>
>>> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>>>
>>>> Side topic: I wonder if (with some changes to the daemon -- perhaps in
>>>> DerivationGoal::startBuilder) in nix/libstore/build.cc we could leak the
>>>> COLUMNS variable to be able to control the Guile builder backtrace
>>>> width.
>>>
>>> As a rule of thumb, I think we should keep the build environment
>>> unchanged forever—no changes to the set of environment variables and
>>> files/directories present in the build environment.
>>>
>>> It’s important because the whole reproducibile-by-construction approach
>>> depends on that.
>>
>> I understand it can be risky to change anything on the builder side for
>> reproducibility.
>
> It’s not that it’s risky, it’s something we should never do; it’s crucial.
Okay.
>> Would you have an idea of the angle this problem should be approached
>> from, where the goal is to have a configurable Guile backtrace width
>> in the builder?
>
> How about passing #:env-vars '(("COLUMNS" . "200")) to
> ‘gexp->derivation’ (in the build system), or adding a phase that sets
> that environment variable?
That sounds like a reasonable solution to me! It's pretty "fixed" while
I would have preferred a user-configurable value, but it's better than
the current situation, so I'd say let's go for it on core-updates!
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-02-08 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 18:19 [bug#60632] [PATCH 1/1] services: base: Add extra-env support to guix-configuration Mathieu Othacehe
2023-01-11 19:38 ` Maxim Cournoyer
2023-01-31 22:18 ` Ludovic Courtès
2023-02-01 18:31 ` configurable guile backtrace in builder (was: services: base: Add extra-env support to guix-configuration) Maxim Cournoyer
2023-02-08 9:39 ` configurable guile backtrace in builder Ludovic Courtès
2023-02-08 16:09 ` Maxim Cournoyer [this message]
2023-02-09 9:24 ` Attila Lendvai
2023-10-14 19:54 ` bug#60632: [PATCH 1/1] services: base: Add extra-env support to guix-configuration Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7q4jfze.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.