From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id IMUME3vJ42PDggEAbAwnHQ (envelope-from ) for ; Wed, 08 Feb 2023 17:10:35 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GKkDE3vJ42MVfgEA9RJhRA (envelope-from ) for ; Wed, 08 Feb 2023 17:10:35 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0E293188E8 for ; Wed, 8 Feb 2023 17:10:34 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPn1K-0002iR-PT; Wed, 08 Feb 2023 11:10:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPn1I-0002hP-O6 for guix-devel@gnu.org; Wed, 08 Feb 2023 11:10:04 -0500 Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPn1G-0004na-83; Wed, 08 Feb 2023 11:10:03 -0500 Received: by mail-qt1-x830.google.com with SMTP id c2so21249686qtw.5; Wed, 08 Feb 2023 08:10:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=nZ84uqkCZQgh1h8Qj+35cdMhc58bFw/6qS3C1QMB174=; b=X9gzX9MmLx4we6rSOp5e1n08ArWIfbd/ydZC4cbYR3/Xcibxv9YrJD7G3zjU1fKnMp bSDU9bRLfT+zOJP/q6mqwTo+ccAY5XT42GFR1QFZlkgjOInGpVIuX7E3VE42xcGsX7E8 QnKra1+yr+FDK4Jx/oAYvWiwYLb+h25dIThqvuJhiYEzYQidjp1qaQ+Rh689BHjz4kdk KMesvhQkib2T6cIyhJ4lRd6hveGecxeGWVPdFQbqevQA1EcI5O3yqNmokNGhx8ZyBeHf oDAQPPq+AfmQJkZzyH8rEK9anP3NG6IvHf0/Mhyd+7K89GlKUPh5138YZTJPQxc9gygZ 0vYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nZ84uqkCZQgh1h8Qj+35cdMhc58bFw/6qS3C1QMB174=; b=tJxQk+BONG6CTmYFMZDZVuk9FZ+VFQ0AzvuNworMSV6Jj819y6/cc4hBF/z/pqifFD Q45cVJQonCOWrvgdQVvjG5Xhyeb74anaN6fQ5v7+IKgoVWDAyrR7bIyyQtV4Xrqs4rs9 O+K1nquhCgbmHLFrDj/u1vGxznO0N8kArhld7vjRg2wHXjwUhQ7Z6QPC+tM5Usq54M43 guh8DpJkxaV2b5WQjVTJO8UAXyALbgSIY8LQGaGLgcOq83naSxrOyWctvufq2DD3iRoQ TJZvRgwXqmX0TRe9WcdLvS1bae50NeVOH7oLtWbyBUfEzhpysWTWNZ3B0PEteHJodl3O ZIDA== X-Gm-Message-State: AO0yUKXkX8ZCLil5Ti0m0tP9beOy5y3d+cNkaTMBXoxGM0dIz+NZZShi YT4LAeIXgm3JPQlw9Xzwy0l8ETZl5072+A== X-Google-Smtp-Source: AK7set8aeBkfZg/ks9GKcUFiyzuDy/OFbciDR734YpFwx13NY+qIEXjTSgN7mDVlGa/LEwRALbCKhA== X-Received: by 2002:ac8:5b03:0:b0:3b8:6ae9:b107 with SMTP id m3-20020ac85b03000000b003b86ae9b107mr13405265qtw.17.1675872599017; Wed, 08 Feb 2023 08:09:59 -0800 (PST) Received: from hurd (dsl-151-105.b2b2c.ca. [66.158.151.105]) by smtp.gmail.com with ESMTPSA id br15-20020a05620a460f00b00706bc44fda8sm11827977qkb.79.2023.02.08.08.09.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 08:09:58 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: Mathieu Othacehe , guix-devel Subject: Re: configurable guile backtrace in builder References: <20230107181938.14334-1-othacehe@gnu.org> <871qo0j1zn.fsf@gmail.com> <87r0vas5zx.fsf_-_@gnu.org> <87zg9xutik.fsf_-_@gmail.com> <87357gzebc.fsf@gnu.org> Date: Wed, 08 Feb 2023 11:09:57 -0500 In-Reply-To: <87357gzebc.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Wed, 08 Feb 2023 10:39:19 +0100") Message-ID: <87o7q4jfze.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::830; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x830.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=X9gzX9Mm; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675872635; a=rsa-sha256; cv=none; b=TOEuos3g/pvEd7rbk3JS/5+aJ8exIYZpVtJ3HBNlSIOh0dWND4FcyhqDyajXyTBoShN5ZX eGGg4zkufyPyc/jkRmdn3LyL/f9azpZC0HlcRSYVTTRn6zS7UckJLqH/ha58sYPQ+4zk3G VfFgRgYWRRQiWn0uMlbco38Nfu0oH+FPHJW6BHEk+sPajdCPmHLAReWcn/ADwb7MYRX92o BiXZs+Pn+SRUqwc873IPSHFRidm+Rin7qgH2+GjB0VrVScz3ixapZrfUc9wLoMrFiw6nvJ aJ8SDGFsO47EqdGITG0UfDjBCOzwZgxT0YW1n6CXR77yJR4Br3EsdFhuUIr5XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675872635; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=nZ84uqkCZQgh1h8Qj+35cdMhc58bFw/6qS3C1QMB174=; b=QdOMrYoq1B7SAmO5bzHFERKEd/q6dczEj0DW0O+BIjeSaB9Z43rcY68Z1SKExx25HnUh0i 6f0CEO72B9n61rNgWvXL7pdHKruhisGAPV/c94ilQMbOPPKyM3b9Z7nNwWyd7noFuy+W7L QHpMrGbTDC9m1zEj+PCc3Pwz9EYstmpdj2X3lrLe+I9flYdhVklOuGdtNLtBQnYbFbYOyG dr6hKCApZEZ3zwtaI+Mem19iHk4zkJQSbcUh9UXrlHEUFzZfF3Ozmhn6ak9s4wu6o805c2 LHiHm5sby1HAiSQ/qNXh6oUhqnea+DxUD46jfrKjqofVZ815QhinN59f1pdkTQ== X-Migadu-Queue-Id: 0E293188E8 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=X9gzX9Mm; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com X-Migadu-Spam-Score: -9.80 X-Spam-Score: -9.80 X-TUID: qX57ehjOvort Hello, Ludovic Court=C3=A8s writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> Ludovic Court=C3=A8s writes: > > [...] > >>> Maxim Cournoyer skribis: >>> >>>> Side topic: I wonder if (with some changes to the daemon -- perhaps in >>>> DerivationGoal::startBuilder) in nix/libstore/build.cc we could leak t= he >>>> COLUMNS variable to be able to control the Guile builder backtrace >>>> width. >>> >>> As a rule of thumb, I think we should keep the build environment >>> unchanged forever=E2=80=94no changes to the set of environment variable= s and >>> files/directories present in the build environment. >>> >>> It=E2=80=99s important because the whole reproducibile-by-construction = approach >>> depends on that. >> >> I understand it can be risky to change anything on the builder side for >> reproducibility. > > It=E2=80=99s not that it=E2=80=99s risky, it=E2=80=99s something we shoul= d never do; it=E2=80=99s crucial. Okay. >> Would you have an idea of the angle this problem should be approached >> from, where the goal is to have a configurable Guile backtrace width >> in the builder? > > How about passing #:env-vars '(("COLUMNS" . "200")) to > =E2=80=98gexp->derivation=E2=80=99 (in the build system), or adding a pha= se that sets > that environment variable? That sounds like a reasonable solution to me! It's pretty "fixed" while I would have preferred a user-configurable value, but it's better than the current situation, so I'd say let's go for it on core-updates! --=20 Thanks, Maxim