From: "Ludovic Courtès" <ludovic.courtes@inria.fr>
To: Timothy Sample <samplet@ngyro.com>
Cc: 68769@debbugs.gnu.org
Subject: [bug#68769] [PATCH 0/2] Update Disarchive to 0.6.0
Date: Mon, 12 Feb 2024 22:43:59 +0100 [thread overview]
Message-ID: <87o7clbbog.fsf@gnu.org> (raw)
In-Reply-To: <20240128060701.845-2-samplet@ngyro.com> (Timothy Sample's message of "Sun, 28 Jan 2024 00:05:22 -0600")
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
Hi Timothy,
I thought I had replied but apparently not (?).
Timothy Sample <samplet@ngyro.com> skribis:
> This small series updates Disarchive to 0.6.0, bringing in support for bzip2.
> I would appreciate someone giving it a once over, since the Guix package
> depends on the Disarchive package. Fortunately, we have the existing XZ
> support, so I just followed that example. :)
>
> I ran tests and made sure that I could ‘guix pull’ from my checkout. I even
> tested that Disarchive from the resulting profile could be used on bzip2 and
> XZ files. I did a similar test of the Guix package. Everything looks pretty
> good.
This is excellent news! LGTM!
I applied the patches and built Disarchive + guile-bzip2 on
x86_64-linux. ‘make as-derivation’ also gives me a valid ‘guix’.
So green lights from me.
One change that’s missing is this, used for
<https://ci.guix.gnu.org/jobset/disarchive>:
[-- Attachment #2: Type: text/x-patch, Size: 798 bytes --]
diff --git a/etc/disarchive-manifest.scm b/etc/disarchive-manifest.scm
index 41f64eae4f..3dbfa356df 100644
--- a/etc/disarchive-manifest.scm
+++ b/etc/disarchive-manifest.scm
@@ -1,5 +1,5 @@
;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2021-2023 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2021-2024 Ludovic Courtès <ludo@gnu.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -35,6 +35,8 @@ (define (tarball-origin? origin)
(and (origin-hash origin)
(or (string-suffix? ".tar.gz" file)
(string-suffix? ".tgz" file)
+ (string-suffix? ".tar.bz2" file)
+ (string-suffix? ".tbz2" file)
(string-suffix? ".tar.xz" file)
(string-suffix? ".tar" file))))))
[-- Attachment #3: Type: text/plain, Size: 26 bytes --]
Go for it!
Ludo’.
next prev parent reply other threads:[~2024-02-12 21:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 6:05 [bug#68769] [PATCH 0/2] Update Disarchive to 0.6.0 Timothy Sample
2024-01-28 6:12 ` [bug#68769] [PATCH 1/2] gnu: Add guile-bzip2 Timothy Sample
2024-01-28 6:12 ` [bug#68769] [PATCH 2/2] gnu: disarchive: Update to 0.6.0 Timothy Sample
2024-02-12 21:43 ` Ludovic Courtès [this message]
2024-02-13 15:43 ` bug#68769: [PATCH 0/2] Update Disarchive " Timothy Sample
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7clbbog.fsf@gnu.org \
--to=ludovic.courtes@inria.fr \
--cc=68769@debbugs.gnu.org \
--cc=samplet@ngyro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.