* [PATCH] gnu: Add myrepos.
@ 2015-12-01 5:32 Kyle Meyer
2015-12-01 10:25 ` Ricardo Wurmus
0 siblings, 1 reply; 5+ messages in thread
From: Kyle Meyer @ 2015-12-01 5:32 UTC (permalink / raw)
To: guix-devel; +Cc: Kyle Meyer
* gnu/packages/version-control.scm (myrepos): New variable.
---
gnu/packages/version-control.scm | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index b132663..d7c4f8c 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -7,6 +7,7 @@
;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2015 Kyle Meyer <kyle@kyleam.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -925,3 +926,32 @@ any project with more than one developer, is one of Aegis's major functions.")
a history browser. It can also stage hunks for commit, or colorize the
output of the 'git' command.")
(license gpl2+)))
+
+(define-public myrepos
+ (package
+ (name "myrepos")
+ (version "1.20151022")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://github.com/joeyh/myrepos/archive/"
+ version ".tar.gz"))
+ (sha256
+ (base32 "0c93lqsngpsxsca7nygk4qhidr40ijgih86q81x1mfcwbs0gbds8"))))
+ (build-system gnu-build-system)
+ (inputs
+ `(("perl" ,perl)))
+ (arguments
+ `(#:test-target "test"
+ #:phases (alist-delete 'configure %standard-phases)
+ #:make-flags (list (string-append "DESTDIR=" (assoc-ref %outputs "out"))
+ "PREFIX=")))
+ (home-page "http://myrepos.branchable.com/")
+ (synopsis "Multiple repository management tool")
+ (description
+ "Myrepos provides the @code{mr} command, which maps an operation (e.g.,
+fetching updates) over a collection of version control repositories. It
+supports a large number of version control systems: git, svn, mercurial, bzr,
+darcs, cvs, fossil and veracity.")
+ (license gpl2+)))
--
2.6.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] gnu: Add myrepos.
2015-12-01 5:32 [PATCH] gnu: Add myrepos Kyle Meyer
@ 2015-12-01 10:25 ` Ricardo Wurmus
2015-12-01 17:26 ` Kyle Meyer
2015-12-01 17:29 ` [PATCH v2] " Kyle Meyer
0 siblings, 2 replies; 5+ messages in thread
From: Ricardo Wurmus @ 2015-12-01 10:25 UTC (permalink / raw)
To: Kyle Meyer; +Cc: guix-devel
Hi Kyle,
thanks for the patch!
> * gnu/packages/version-control.scm (myrepos): New variable.
> ---
> gnu/packages/version-control.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
> index b132663..d7c4f8c 100644
> --- a/gnu/packages/version-control.scm
> +++ b/gnu/packages/version-control.scm
> @@ -7,6 +7,7 @@
> ;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
> ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
> ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
> +;;; Copyright © 2015 Kyle Meyer <kyle@kyleam.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -925,3 +926,32 @@ any project with more than one developer, is one of Aegis's major functions.")
> a history browser. It can also stage hunks for commit, or colorize the
> output of the 'git' command.")
> (license gpl2+)))
> +
> +(define-public myrepos
> + (package
> + (name "myrepos")
> + (version "1.20151022")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/joeyh/myrepos/archive/"
> + version ".tar.gz"))
You should add a ‘(file-name ...)’ expression here, because the tarball
does not include the name of the package:
(file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32 "0c93lqsngpsxsca7nygk4qhidr40ijgih86q81x1mfcwbs0gbds8"))))
> + (build-system gnu-build-system)
> + (inputs
> + `(("perl" ,perl)))
> + (arguments
> + `(#:test-target "test"
> + #:phases (alist-delete 'configure %standard-phases)
> + #:make-flags (list (string-append "DESTDIR=" (assoc-ref %outputs "out"))
> + "PREFIX=")))
Is it really correct to set DESTDIR and unset PREFIX? I thought setting
PREFIX would be sufficient.
> + (home-page "http://myrepos.branchable.com/")
> + (synopsis "Multiple repository management tool")
> + (description
> + "Myrepos provides the @code{mr} command, which maps an operation (e.g.,
> +fetching updates) over a collection of version control repositories. It
> +supports a large number of version control systems: git, svn, mercurial, bzr,
> +darcs, cvs, fossil and veracity.")
> + (license gpl2+)))
The rest looks fine to me. Thanks!
~~ Ricardo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gnu: Add myrepos.
2015-12-01 10:25 ` Ricardo Wurmus
@ 2015-12-01 17:26 ` Kyle Meyer
2015-12-01 17:29 ` [PATCH v2] " Kyle Meyer
1 sibling, 0 replies; 5+ messages in thread
From: Kyle Meyer @ 2015-12-01 17:26 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
[...]
> You should add a ‘(file-name ...)’ expression here, because the tarball
> does not include the name of the package:
>
> (file-name (string-append name "-" version ".tar.gz"))
OK.
>> + #:make-flags (list (string-append "DESTDIR=" (assoc-ref %outputs "out"))
>> + "PREFIX=")))
>
> Is it really correct to set DESTDIR and unset PREFIX? I thought setting
> PREFIX would be sufficient.
Right, setting PREFIX works fine. Myrepo's Makefile forms the path as
"${DESTDIR}${PREFIX}", so the end result should be the same. I'm not
sure why I decided setting DESTDIR would be better.
Sending an updated patch. Thanks for the comments.
--
Kyle
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] gnu: Add myrepos.
2015-12-01 10:25 ` Ricardo Wurmus
2015-12-01 17:26 ` Kyle Meyer
@ 2015-12-01 17:29 ` Kyle Meyer
2015-12-06 21:45 ` Ludovic Courtès
1 sibling, 1 reply; 5+ messages in thread
From: Kyle Meyer @ 2015-12-01 17:29 UTC (permalink / raw)
To: guix-devel; +Cc: Kyle Meyer
* gnu/packages/version-control.scm (myrepos): New variable.
---
gnu/packages/version-control.scm | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index b132663..548fb7f 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -7,6 +7,7 @@
;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2015 Kyle Meyer <kyle@kyleam.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -925,3 +926,32 @@ any project with more than one developer, is one of Aegis's major functions.")
a history browser. It can also stage hunks for commit, or colorize the
output of the 'git' command.")
(license gpl2+)))
+
+(define-public myrepos
+ (package
+ (name "myrepos")
+ (version "1.20151022")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://github.com/joeyh/myrepos/archive/"
+ version ".tar.gz"))
+ (file-name (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32 "0c93lqsngpsxsca7nygk4qhidr40ijgih86q81x1mfcwbs0gbds8"))))
+ (build-system gnu-build-system)
+ (inputs
+ `(("perl" ,perl)))
+ (arguments
+ `(#:test-target "test"
+ #:phases (alist-delete 'configure %standard-phases)
+ #:make-flags (list (string-append "PREFIX=" %output))))
+ (home-page "http://myrepos.branchable.com/")
+ (synopsis "Multiple repository management tool")
+ (description
+ "Myrepos provides the @code{mr} command, which maps an operation (e.g.,
+fetching updates) over a collection of version control repositories. It
+supports a large number of version control systems: git, svn, mercurial, bzr,
+darcs, cvs, fossil and veracity.")
+ (license gpl2+)))
--
2.6.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] gnu: Add myrepos.
2015-12-01 17:29 ` [PATCH v2] " Kyle Meyer
@ 2015-12-06 21:45 ` Ludovic Courtès
0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2015-12-06 21:45 UTC (permalink / raw)
To: Kyle Meyer; +Cc: guix-devel
Kyle Meyer <kyle@kyleam.com> skribis:
> * gnu/packages/version-control.scm (myrepos): New variable.
[...]
> +supports a large number of version control systems: git, svn, mercurial, bzr,
> +darcs, cvs, fossil and veracity.")
I capitalized the VCS names and applied it.
Thank you!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-12-06 21:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-01 5:32 [PATCH] gnu: Add myrepos Kyle Meyer
2015-12-01 10:25 ` Ricardo Wurmus
2015-12-01 17:26 ` Kyle Meyer
2015-12-01 17:29 ` [PATCH v2] " Kyle Meyer
2015-12-06 21:45 ` Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.