all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 34165@debbugs.gnu.org, Carl Dong <contact@carldong.me>
Subject: [bug#34165] [PATCH] gnu: bitcoin-core: Make bitcoin-qt deterministic.
Date: Mon, 28 Jan 2019 14:39:35 +0100	[thread overview]
Message-ID: <87munkrje0.fsf@gnu.org> (raw)
In-Reply-To: <20190128120720.094dd8be@scratchpost.org> (Danny Milosavljevic's message of "Mon, 28 Jan 2019 12:07:20 +0100")

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> [1] https://github.com/qt/qtbase/commit/38271e9298dcf48652a6e2e08414a940a97867fa#commitcomment-32085478
>
> https://codereview.qt-project.org/#/c/243636/4/src/tools/rcc/rcc.cpp,unified contains the following patch:
>
> ...
> 228	228	         const QDateTime lastModified = m_fileInfo.lastModified();
> 	229	229	         quint64 lastmod = quint64(lastModified.isValid() ? lastModified.toMSecsSinceEpoch() : 0);
> 	230	230	         static const quint64 sourceDate = 1000 * qgetenv("QT_RCC_SOURCE_DATE_OVERRIDE").toULongLong(
> );
> 	231	231	         if (sourceDate != 0)
> 	232	232	             lastmod = sourceDate;
> 		233	+        static const quint64 sourceDate2 = 1000 * qgetenv("SOURCE_DATE_EPOCH").toULongLong();
> 		234	+        if (sourceDate2 != 0)
> 		235	+            lastmod = sourceDate2;

Nice, so maybe we don’t need to change anything and just wait for the
next Qt version?

Ludo’.

      reply	other threads:[~2019-01-28 13:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21 19:55 [bug#34165] [PATCH] gnu: bitcoin-core: Make bitcoin-qt deterministic Carl Dong
2019-01-22 14:28 ` bug#34165: " Danny Milosavljevic
2019-01-23  9:07 ` [bug#34165] " Ludovic Courtès
2019-01-23 14:41   ` Ricardo Wurmus
2019-01-26 18:07     ` Efraim Flashner
2019-01-27 22:39       ` Ludovic Courtès
2019-01-28 11:07     ` Danny Milosavljevic
2019-01-28 13:39       ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87munkrje0.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=34165@debbugs.gnu.org \
    --cc=contact@carldong.me \
    --cc=dannym@scratchpost.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.