From: Ricardo Wurmus <rekado@elephly.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 34165@debbugs.gnu.org, Carl Dong <contact@carldong.me>
Subject: [bug#34165] [PATCH] gnu: bitcoin-core: Make bitcoin-qt deterministic.
Date: Wed, 23 Jan 2019 15:41:43 +0100 [thread overview]
Message-ID: <8736pj77x4.fsf@elephly.net> (raw)
In-Reply-To: <87munrivyd.fsf@gnu.org>
Ludovic Courtès <ludo@gnu.org> writes:
> Hi!
>
> Carl Dong <contact@carldong.me> skribis:
>
>>>From 2b3162dde22a5d44eb5910b0fcfa07318f935aaf Mon Sep 17 00:00:00 2001
>> From: Carl Dong <accounts@carldong.me>
>> Date: Mon, 21 Jan 2019 14:51:57 -0500
>> Subject: [PATCH] gnu: bitcoin-core: Make bitcoin-qt deterministic.
>
> [...]
>
>> + (add-before 'configure 'qt-time
>> + (lambda _
>> + (setenv "QT_RCC_SOURCE_DATE_OVERRIDE" "1"))) ; Make QT deterministic
>
> Looking at this and the upstream commit¹, I’m thinking maybe we should
> do the same in other Qt applications. Any idea how we can identify
> applications where it’s needed?
>
> ¹
> https://github.com/qt/qtbase/commit/38271e9298dcf48652a6e2e08414a940a97867fa
This is a bit unfortunate. It seems to me that the original intent of
the patch was to support SOURCE_DATE_EPOCH as the commit message
mentions that variable’s specification. Pity that it is now a custom Qt
variable.
This probably should be used for all packages that generate resource
files, which I assume are most non-trivial applications. I think it’s
fine to add it to all packages using qtbase.
--
Ricardo
next prev parent reply other threads:[~2019-01-25 10:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 19:55 [bug#34165] [PATCH] gnu: bitcoin-core: Make bitcoin-qt deterministic Carl Dong
2019-01-22 14:28 ` bug#34165: " Danny Milosavljevic
2019-01-23 9:07 ` [bug#34165] " Ludovic Courtès
2019-01-23 14:41 ` Ricardo Wurmus [this message]
2019-01-26 18:07 ` Efraim Flashner
2019-01-27 22:39 ` Ludovic Courtès
2019-01-28 11:07 ` Danny Milosavljevic
2019-01-28 13:39 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736pj77x4.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=34165@debbugs.gnu.org \
--cc=contact@carldong.me \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.