From: Andrew Tropin <andrew@trop.in>
To: Maxime Devos <maximedevos@telenet.be>, 49419@debbugs.gnu.org
Subject: [bug#49419] [PATCH 1/4] home-services: Add most essential home services
Date: Mon, 05 Jul 2021 19:19:39 +0300 [thread overview]
Message-ID: <87mtr0hgx0.fsf@trop.in> (raw)
In-Reply-To: <9ee31c62aef0a42b15b48ece2c1d0fe765fdcc83.camel@telenet.be>
[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]
Maxime Devos <maximedevos@telenet.be> writes:
> Hi,
>
> Andrew Tropin schreef op ma 05-07-2021 om 18:37 [+0300]:
>> + (if (file-exists? (he-init-file new-home))
>> + (let* ((port ((@@ (ice-9 popen) open-input-pipe)
>> + (format #f "source ~a && env"
>> + (he-init-file new-home))))
>> + (result ((@@ (ice-9 rdelim) read-delimited) "" port))
>> + (vars (map (lambda (x)
>> + (let ((si (string-index x #\=)))
>> + (cons (string-take x si)
>> + (string-drop x (1+ si)))))
>> + ((@@ (srfi srfi-1) remove)
>> + string-null?
>> + (string-split result #\newline)))))
>
> Why are you using @@ here? 'open-input-pipe', 'read-delimited' and 'remove'
> are exported variables, so you can just use @ instead of the magic evil @@
> operator.
Because of a bad habbit, I needed it once and after that started to use
it uncoditionally. It should be @, thanks for pointing!
BTW, how to add changes to the patches? Do I need to resend a
particular patch with required updates or have to wait other reviews and
send a v2 patch series?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]
next prev parent reply other threads:[~2021-07-05 16:20 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 15:35 [bug#49419] [PATCH 0/4] Essential home services Andrew Tropin
2021-07-05 15:37 ` [bug#49419] [PATCH 1/4] home-services: Add most essential " Andrew Tropin
2021-07-05 15:47 ` Maxime Devos
2021-07-05 16:19 ` Andrew Tropin [this message]
2021-07-05 19:19 ` Maxime Devos
2021-07-06 7:09 ` Andrew Tropin
2021-07-06 8:26 ` Maxime Devos
2021-07-06 7:23 ` Andrew Tropin
2021-07-05 15:39 ` [bug#49419] [PATCH 2/4] home-services: Add home-run-on-change-service-type Andrew Tropin
2021-07-05 15:41 ` [bug#49419] [PATCH 3/4] home-services: Add home-provenance-service-type Andrew Tropin
2021-07-05 15:41 ` [bug#49419] [PATCH 4/4] home-services: Add fold-home-service-types function Andrew Tropin
2021-07-13 16:17 ` [bug#49419] [PATCH v2 0/4] Essential home services Andrew Tropin
2021-07-05 15:37 ` [bug#49546] [PATCH v2 1/4] home-services: Add most essential " Andrew Tropin
[not found] ` <handler.49546.B.16262002971832.ack@debbugs.gnu.org>
2021-07-13 18:24 ` [bug#49546] Acknowledgement ([PATCH v2 1/4] home-services: Add most essential home services) Andrew Tropin
2021-07-05 15:39 ` [bug#49547] [PATCH v2 2/4] home-services: Add home-run-on-change-service-type Andrew Tropin
2021-07-14 10:41 ` Maxime Devos
2021-07-15 8:46 ` Andrew Tropin
2021-07-18 16:17 ` Maxime Devos
2021-07-05 15:41 ` [bug#49548] [PATCH v2 3/4] home-services: Add home-provenance-service-type Andrew Tropin
2021-07-05 15:41 ` [bug#49549] [PATCH v2 4/4] home-services: Add fold-home-service-types function Andrew Tropin
2021-07-15 9:59 ` [bug#49568] Testing reply without debbugs address Andrew Tropin
2021-07-19 8:04 ` [bug#49419] [PATCH v3 0/4] Essential home services Andrew Tropin
2021-07-05 15:37 ` [bug#49419] [PATCH v3 1/4] home-services: Add most essential " Andrew Tropin
2021-07-05 15:39 ` [bug#49419] [PATCH v3 2/4] home-services: Add home-run-on-change-service-type Andrew Tropin
2021-07-05 15:41 ` [bug#49419] [PATCH v3 3/4] home-services: Add home-provenance-service-type Andrew Tropin
2021-07-05 15:41 ` [bug#49419] [PATCH v3 4/4] home-services: Add fold-home-service-types function Andrew Tropin
2021-07-21 15:08 ` [bug#49419] [PATCH 0/4] Essential home services Ludovic Courtès
2021-07-28 5:35 ` Andrew Tropin
[not found] ` <handler.49419.B.162549932625345.ack@debbugs.gnu.org>
2021-08-05 5:41 ` [bug#49419] [PATCH v4 " Andrew Tropin
2021-08-05 5:45 ` [bug#49419] [PATCH v4 1/4] home-services: Add most essential " Andrew Tropin
2021-08-05 5:46 ` [bug#49419] [PATCH v4 2/4] home-services: Add home-run-on-change-service-type Andrew Tropin
2021-08-05 5:46 ` [bug#49419] [PATCH v4 3/4] home-services: Add home-provenance-service-type Andrew Tropin
2021-08-05 5:47 ` [bug#49419] [PATCH v4 4/4] home-services: Add fold-home-service-types function Andrew Tropin
2021-08-23 9:57 ` [bug#49419] [PATCH v4 0/4] Essential home services Andrew Tropin
2021-08-23 16:24 ` [bug#49419] [PATCH " Oleg Pykhalov
2021-08-24 8:53 ` Andrew Tropin
2021-08-24 12:14 ` bug#49419: " Oleg Pykhalov
2021-08-26 7:01 ` [bug#49419] " Andrew Tropin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtr0hgx0.fsf@trop.in \
--to=andrew@trop.in \
--cc=49419@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.