From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wFk0L2gx42BCxgAAgWs5BA (envelope-from ) for ; Mon, 05 Jul 2021 18:20:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id WLD0Kmgx42ABdAAA1q6Kng (envelope-from ) for ; Mon, 05 Jul 2021 16:20:56 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 769A61C14E for ; Mon, 5 Jul 2021 18:20:56 +0200 (CEST) Received: from localhost ([::1]:46570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0RL5-0003ed-EN for larch@yhetil.org; Mon, 05 Jul 2021 12:20:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0RKF-0002OC-MZ for guix-patches@gnu.org; Mon, 05 Jul 2021 12:20:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35031) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m0RKE-0006fJ-NG for guix-patches@gnu.org; Mon, 05 Jul 2021 12:20:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m0RKE-0007uZ-9m for guix-patches@gnu.org; Mon, 05 Jul 2021 12:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49419] [PATCH 1/4] home-services: Add most essential home services Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Jul 2021 16:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49419 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 49419@debbugs.gnu.org Received: via spool by 49419-submit@debbugs.gnu.org id=B49419.162550199030386 (code B ref 49419); Mon, 05 Jul 2021 16:20:02 +0000 Received: (at 49419) by debbugs.gnu.org; 5 Jul 2021 16:19:50 +0000 Received: from localhost ([127.0.0.1]:46577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0RK2-0007u1-Iu for submit@debbugs.gnu.org; Mon, 05 Jul 2021 12:19:50 -0400 Received: from mail-lj1-f179.google.com ([209.85.208.179]:33673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0RK1-0007tk-6E for 49419@debbugs.gnu.org; Mon, 05 Jul 2021 12:19:49 -0400 Received: by mail-lj1-f179.google.com with SMTP id w11so25399102ljh.0 for <49419@debbugs.gnu.org>; Mon, 05 Jul 2021 09:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20150623.gappssmtp.com; s=20150623; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=s5XcUS/JJ2v5gY5QMB17hYsmnMdlc1qPu3b35EeibjM=; b=xisbRjggTb67FhaAZ/gGjGAJMq+UBbwkNTCgpvr98LxBjp4EAs0+J8wA11jLirOL5e w4JED2odX4dJdxZZfxH096v9+di4u8/8QNWCI7YGHSJC4MK7QgNvN+pME+n6J39eXTBC HfQVfhzVebZI1JplkepPeHv3qMKpt5dFUej+ry3r+Kys8NiuewOw8r7ev1LjkhqldKBF uqSSFfXlj5iKKLt8PbfhLYIcr9Wh2GgdPnUgozlQBp9G/CpzATomta66YqB3vEtNCimZ QRUWYRMJLWIIVW8yotcxtUe8rVvf1yOWzgVLU/YsGOkTG5MMrUokXAPbuRLH1V0bENIj ipbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=s5XcUS/JJ2v5gY5QMB17hYsmnMdlc1qPu3b35EeibjM=; b=rB+tkiEjx+TxkMJPKtsQhUrGGiaQ9rifNdC0gCML+NtU4wfvKVDYhF8vuYI62t42iE q2sT3llRYLr6D+njtVavFwmktS8z9Aa5k2lRvniNolV1m4xF8zUYSbc+fUtAZchLSDV1 XKVuJ4KWUPAzJgO6mn3X2zBvNNiciM6/28nHI3/zlFBn3XTpa/jXA65aJWpChpLtVCtu YjW4JyXYNKhnzEY3UBE8H3wFLWXyvgei+45vbIy1IcAqw3JUMpqdJ2J4OGf8rCDtPajx WWNumE9h5igrAhJJpJmqGh5mjqxEbJtl2saVG22NBw+NDI31jYZYAJUz0+CIncdq5iar z1WQ== X-Gm-Message-State: AOAM5300UU1CfeVqcFEf4PyVC0Rrm644WwRHe0RDwm5C/Wzs61uwy6qP S5UT3nMoS5lR0kbObR/x4cn0E1KOxRytoA== X-Google-Smtp-Source: ABdhPJziGjBhHdkc1eVNsCNFRt7JLwBavKYRG3Qxsdl8k376RhEmcOdh+BMu/qmkTYmByvccA9iRCw== X-Received: by 2002:a2e:7602:: with SMTP id r2mr11651247ljc.271.1625501982500; Mon, 05 Jul 2021 09:19:42 -0700 (PDT) Received: from ixy (109-252-117-164.nat.spd-mgts.ru. [109.252.117.164]) by smtp.gmail.com with ESMTPSA id p3sm1208597lfa.100.2021.07.05.09.19.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jul 2021 09:19:41 -0700 (PDT) From: Andrew Tropin In-Reply-To: <9ee31c62aef0a42b15b48ece2c1d0fe765fdcc83.camel@telenet.be> References: <87y2akhiz1.fsf@trop.in> <87wnq4hivq.fsf@trop.in> <9ee31c62aef0a42b15b48ece2c1d0fe765fdcc83.camel@telenet.be> Date: Mon, 05 Jul 2021 19:19:39 +0300 Message-ID: <87mtr0hgx0.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625502056; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=s5XcUS/JJ2v5gY5QMB17hYsmnMdlc1qPu3b35EeibjM=; b=BnjFjayqUUTRxNFGly9FTI47dVzppNWvN8zy60r9eDsVHeqqLxAooDOOj+CCgKEHFqkT4x Z//bK1FmemMyglOjxMhZMunFWPUT2GVe6v//Z8YZF4zHzkY2479Z1FfD22/TdulDLPmh1C v+j3JMKzvLjY58jRehYXcnTbjeHEg83Ucnl3nlFnBU67E8hBW0d6KXBqY/pG+RmFKxUrJ4 TVo57wL9fOSLSPEuNIdhy8j5pM2v1HPHrivYuKhwhK24gHi1/DJGQbBBi3N0/X8EkzZpvF wgB14R5uuE1xLwBptJNlznqxLSD8lZbpYi0DkaLGP9Tahw3oaik0+xjG0voZnQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625502056; a=rsa-sha256; cv=none; b=TkOgLwdk0XduxTnrmgaNei0tGR5fn3p7hqT2+yz91amLXYwSvNQHY4bt4d0ZoPN7qmjmHl 3gLTuan07/dGsGOHCFjNL6s2UVLxRpYTMGSMGjsJzvN/5+TSBek6/+/51aQ2gIXTpxsrbY V1OuGwM7/IhfMDV+fG5gFpDWk/rysoy/ycB9XIiSvg0B++VDgeywBO/gDEe6pkP4rsRZkI ADV+UTUTy5DyJuG9SoDncPgWkUaZQioiyTGOcncZ5mDXcr+vqUEIknv9vkaWObqqAjvX2D 3dy2dqZEyAO6RXt1Afh5Ykxa+OZTm3LsuXNlO+7iKe1tI80XL7uBKGRlavA14A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20150623.gappssmtp.com header.s=20150623 header.b=xisbRjgg; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.51 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20150623.gappssmtp.com header.s=20150623 header.b=xisbRjgg; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 769A61C14E X-Spam-Score: -3.51 X-Migadu-Scanner: scn0.migadu.com X-TUID: FI7O0nQ4x9Bq --=-=-= Content-Type: text/plain Maxime Devos writes: > Hi, > > Andrew Tropin schreef op ma 05-07-2021 om 18:37 [+0300]: >> + (if (file-exists? (he-init-file new-home)) >> + (let* ((port ((@@ (ice-9 popen) open-input-pipe) >> + (format #f "source ~a && env" >> + (he-init-file new-home)))) >> + (result ((@@ (ice-9 rdelim) read-delimited) "" port)) >> + (vars (map (lambda (x) >> + (let ((si (string-index x #\=))) >> + (cons (string-take x si) >> + (string-drop x (1+ si))))) >> + ((@@ (srfi srfi-1) remove) >> + string-null? >> + (string-split result #\newline))))) > > Why are you using @@ here? 'open-input-pipe', 'read-delimited' and 'remove' > are exported variables, so you can just use @ instead of the magic evil @@ > operator. Because of a bad habbit, I needed it once and after that started to use it uncoditionally. It should be @, thanks for pointing! BTW, how to add changes to the patches? Do I need to resend a particular patch with required updates or have to wait other reviews and send a v2 patch series? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmDjMRsPHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6wZT4QAJEov57pZfK3lU4JxmmbjrSO8VcmU9d2OmDw 8u4ZFeYOgC+U+QJjGEzXnZNW4QuxZGfOwtC9oxCyAqMXFwMc+hKUL28BG1fBRDH9 kl6Gpn5NzARZt6Ou1xfBYXyqO+iTYzjYo8mKfdKDDI9PAi2dVSeAvkAVZ69QCm/f K5AuJnZGpfRceGs60p85i88T8IsSWXC72RnJ9osYYCHosvboNCv5YE5UxLbXH/8T PYMI6tqZvRg6UNtpPUiwLNocLDDghM62Zyb2Q+5iDGcX8ZOkiYLKqq7CgLZBK0kY Khv4wjJHjFIr7g3/1dFrWQqXzW8uJsGZZY5OvG5cPrcdX3hjFnf4WWPRYxwi+/JK afyejohUi45464OO8lo0hy+eouE4PcDSwFu4vJhLZORr49zCzIueMXhcBLk/M7++ 3CGd4ow30StzUnm/YBxyhh+dku9YXJHXsJNxQV5Wi8q5Nsuk13B1MGLoek054FJt bD5otRkNqW1gBQLRhles4znt05fLYHKlMESRXRSwUtiTEeO7KEnLyRyRIE6ewk++ l/et9h/fnyHECpvk+imvn2PmVwKyhWtSKyE0/WBxchVCrUnZJwB5bGQJ11XuWM8Y P5MjEXvboCVwwI5cV6wTInCVRbTqpbQgHxUx3F7itoIqwlLNhky3cbUDLkqg+IS4 Och3Ic1x =dxhj -----END PGP SIGNATURE----- --=-=-=--