From: zimoun <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 53909@debbugs.gnu.org
Subject: [bug#53909] [PATCH 0/4] 'guix pull -l' no longer displays package lists by default
Date: Thu, 10 Feb 2022 18:21:49 +0100 [thread overview]
Message-ID: <87mtiy8wnm.fsf_-_@gmail.com> (raw)
In-Reply-To: <20220209221712.8724-1-ludo@gnu.org> ("Ludovic Courtès"'s message of "Wed, 9 Feb 2022 23:17:09 +0100")
[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]
Hi Ludo,
Cool! Thanks.
On Wed, 09 Feb 2022 at 23:17, Ludovic Courtès <ludo@gnu.org> wrote:
> * guix/scripts/pull.scm (show-help, %options): Add "--details".
IMHO, the commit online header should reflect that.
> diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm
[...]
> (define (process-query opts profile)
> "Process any query on PROFILE specified by OPTS."
> + (define details?
> + (assoc-ref opts 'details?))
> +
> (match (assoc-ref opts 'query)
> (('list-generations pattern)
> (define (list-generations profile numbers)
> (match numbers
> ((first rest ...)
> (display-profile-content profile first)
> +
> (let loop ((numbers numbers))
> (match numbers
> ((first second rest ...)
> - (display-profile-content-diff profile
> - first second)
> + (if details?
> + (display-profile-content-diff profile
> + first second)
> + (display-profile-content profile second))
> (display-channel-news (generation-file-name profile second)
> (generation-file-name profile first))
> (loop (cons second rest)))
Well, "guix pull --details" pulls; which I find annoying. Instead, I
propose to silently runs "guix pull --details -l", see this diff:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: foo --]
[-- Type: text/x-diff, Size: 662 bytes --]
diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm
index 707f1f0929..fb1dd6c82c 100644
--- a/guix/scripts/pull.scm
+++ b/guix/scripts/pull.scm
@@ -142,7 +142,9 @@ (define %options
result)))
(option '("details") #f #f
(lambda (opt name arg result)
- (alist-cons 'details? #t result)))
+ (alist-cons 'details? #t
+ (cons '(query list-generations #f)
+ result))))
(option '("roll-back") #f #f
(lambda (opt name arg result)
(cons '(generation roll-back)
[-- Attachment #3: Type: text/plain, Size: 440 bytes --]
Because warn people that "guix pull --details" alone is not what they
want adds some complexity, and when '--details' only works in tandem
with the option '--list-generations', that’s why I propose this
behaviour.
Last, about this change…
> - (define (no-arguments arg _)
> + (define (no-arguments arg _)
…it a Git twist? I miss what changed––my whitespace mode is badly
configured?
Cheers,
simon
next prev parent reply other threads:[~2022-02-10 18:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 22:12 [bug#53909] [PATCH 0/4] 'guix pull -l' no longer displays package lists by default Ludovic Courtès
2022-02-09 22:17 ` [bug#53909] [PATCH 1/4] pull: '--list-generations' doesn't list package changes " Ludovic Courtès
2022-02-09 22:17 ` [bug#53909] [PATCH 2/4] ui: 'with-paginated-output-port' gives access to the wrapped port Ludovic Courtès
2022-02-09 22:17 ` [bug#53909] [PATCH 3/4] ui: 'display-generation' uses color when talking to a pager Ludovic Courtès
2022-02-09 22:17 ` [bug#53909] [PATCH 4/4] pull: '--list-generations' pipes its output to the pager Ludovic Courtès
2022-02-10 17:21 ` zimoun [this message]
2022-02-14 14:56 ` bug#53909: [PATCH 0/4] 'guix pull -l' no longer displays package lists by default Ludovic Courtès
2022-02-14 17:28 ` [bug#53909] " zimoun
2022-02-10 17:51 ` zimoun
2022-02-14 12:56 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtiy8wnm.fsf_-_@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=53909@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.