From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MDS5Hn5WBWIiFwEAgWs5BA (envelope-from ) for ; Thu, 10 Feb 2022 19:16:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KPs0G35WBWJMswAAauVa8A (envelope-from ) for ; Thu, 10 Feb 2022 19:16:30 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0E0683764F for ; Thu, 10 Feb 2022 19:16:25 +0100 (CET) Received: from localhost ([::1]:51848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIDzU-0007G8-3r for larch@yhetil.org; Thu, 10 Feb 2022 13:16:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIDc8-0007KR-Mz for guix-patches@gnu.org; Thu, 10 Feb 2022 12:52:16 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34880) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nIDbv-0002C9-Kq for guix-patches@gnu.org; Thu, 10 Feb 2022 12:52:16 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nIDbu-0004Jv-Fb for guix-patches@gnu.org; Thu, 10 Feb 2022 12:52:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53909] [PATCH 0/4] 'guix pull -l' no longer displays package lists by default Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Feb 2022 17:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53909 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 53909@debbugs.gnu.org Received: via spool by 53909-submit@debbugs.gnu.org id=B53909.164451548216541 (code B ref 53909); Thu, 10 Feb 2022 17:52:02 +0000 Received: (at 53909) by debbugs.gnu.org; 10 Feb 2022 17:51:22 +0000 Received: from localhost ([127.0.0.1]:57008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIDbG-0004Ih-Gt for submit@debbugs.gnu.org; Thu, 10 Feb 2022 12:51:22 -0500 Received: from mail-wm1-f44.google.com ([209.85.128.44]:33664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIDbE-0004IM-18 for 53909@debbugs.gnu.org; Thu, 10 Feb 2022 12:51:20 -0500 Received: by mail-wm1-f44.google.com with SMTP id y6-20020a7bc186000000b0037bdc5a531eso1575181wmi.0 for <53909@debbugs.gnu.org>; Thu, 10 Feb 2022 09:51:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qQlNjrRPei38GSCfNeK7p9EUZaf0mRtB0H4sUC2Tugk=; b=fw4yhPCQkCJG30UX8gkdY5pyRgFWtqgHj9v1y5J2H4VxTRVJpXMDmeq5QfpE1Vpjhm SbyE+wN1u7tlZ+ftzMxOkG7hwomtI+k2MYU8EQ9U9JJeO87PaDeVwDezsZECm+ewSXjd U+9X9hDRFj22VKHD144t0ZOfZwi7+YJzO+cuBftAYY3hIBNqNeI7FS+A//Csq3z/FgIx dt0GS8gGrTPxsahjuJ3stLlskVog67AB3wOig695e1Ab8svrhWGXyAbyjM+DvIyH/DFi e3bC+hL3A1AMOl+MC4LIv5knk56YTDNVCSFHQcTYXCLxo1wSiDu2oVDfUWVQpOYMhmAH FSNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qQlNjrRPei38GSCfNeK7p9EUZaf0mRtB0H4sUC2Tugk=; b=Kgfsha6xf+zeRpc9PFz93Vf379xtXv652gKU5mzBv2Uob2tB35s/5YqxgGXS4UZiVy FUoeWOQug6+XSSyk3OjLv/UlCyFxi84uQfZ1Tpr8D4LjnpIoNsDbrLDLoZIWcpvhS1EN vv8sLZGptxfReXnH1blwlxRjlb4tjmcdqj5GOYXT5MdCXzM9tXOXgyBVSOgTlGxwCgBG MlJFKP+j1sYmaA6NLpMKn841Wr/Zez+VXV+Bh1KODU0A8rkCMXiWBZaxAYFlRcKNC2qo 8KQZlXyRajJC3y5XjlLnYy+4kWEp/yTGF++le4ZM7L4NSTCPrvPdvq8TcYvnJf4/4Qfx zRzg== X-Gm-Message-State: AOAM533SvMLeYj1x/d1uOPfBdesRP2Ebj9lAac5O2xChcolNLigxLQzI UVBrQpUeAg4RAf+l5MMmfsHXV7Jvr1I= X-Google-Smtp-Source: ABdhPJyGYhR0YwMD0e55qbio1yPTBonty4s/xcRO9ljUUqQ3X+gHkovUVpqKtJjnZBQTo3ODUil8pQ== X-Received: by 2002:a7b:cbd7:: with SMTP id n23mr3153049wmi.76.1644515473822; Thu, 10 Feb 2022 09:51:13 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id c5sm12620147wrq.102.2022.02.10.09.51.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 09:51:13 -0800 (PST) From: zimoun References: <20220209221237.8549-1-ludo@gnu.org> <20220209221712.8724-1-ludo@gnu.org> Date: Thu, 10 Feb 2022 18:21:49 +0100 In-Reply-To: <20220209221712.8724-1-ludo@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 9 Feb 2022 23:17:09 +0100") Message-ID: <87mtiy8wnm.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644516985; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=qQlNjrRPei38GSCfNeK7p9EUZaf0mRtB0H4sUC2Tugk=; b=dBz0MPW2uh//A2ZbSj/RnwcXOBYkNRUlEEanJSBKprkUEKmIc01mYQiT1p7fG95n4rYTR8 k3pckBVg15LSQOW/VNdRRj0EdXZJ2YLMcOSAsD0UgKtIJRdH/XQRqvIESj/YZ+RMXMfqRz CLBWRKp62+w31GP02qHoAH/AaDVzpt0/wTZa7AWtL1gT2JMSlXthl6W02IPqT2CSj7Kcam Pl4bV6K8/blQts6WGzZ6radWUgFuGeyGS7MLbzEv2yH5uCWTebkdFe4VaR1fl6dE0MxE+y WrkYyKxJu0vtF32S5w4niMdMVaxoOQXHfxlorIMfb6+xAkuFg2FBi1naLRCX1A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644516985; a=rsa-sha256; cv=none; b=rmiSpm6DOF3UuD8JPJk2y0I5qSwFHDF0ZtdL+S/ci6nmiUeTyQcr4aQxXUa7qhjQd/OgHN V+DqhjrS69O4hKqb9IMF0ouiVRlF4XBzr6LmGzEkpD1pO5BFzbgxMhfm+mETBRBfKT51YF 9IPsuhtZ060coe0+Hy9EjZLb2Uahk/4z1ANP4ceXWdKvZud1iQmbllecLe6kL1I4xYoUfu abM/iwv6dULf21MbZFtLfSjHj/1RKUxLhBgYXrmhgAsvYkEyH050U7/9aAs8dl/bK4+i/b LmF5hbsA2MvFE9FXr5HOwlYvSpdNisCbYau1HbD961EQ+UdVe9/Miz2w318jyQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=fw4yhPCQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=fw4yhPCQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0E0683764F X-Spam-Score: -2.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: U4RKPlf+PROW --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, Cool! Thanks. On Wed, 09 Feb 2022 at 23:17, Ludovic Court=C3=A8s wrote: > * guix/scripts/pull.scm (show-help, %options): Add "--details". IMHO, the commit online header should reflect that. > diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm [...] > (define (process-query opts profile) > "Process any query on PROFILE specified by OPTS." > + (define details? > + (assoc-ref opts 'details?)) > + > (match (assoc-ref opts 'query) > (('list-generations pattern) > (define (list-generations profile numbers) > (match numbers > ((first rest ...) > (display-profile-content profile first) > + > (let loop ((numbers numbers)) > (match numbers > ((first second rest ...) > - (display-profile-content-diff profile > - first second) > + (if details? > + (display-profile-content-diff profile > + first second) > + (display-profile-content profile second)) > (display-channel-news (generation-file-name profile secon= d) > (generation-file-name profile first= )) > (loop (cons second rest))) Well, "guix pull --details" pulls; which I find annoying. Instead, I propose to silently runs "guix pull --details -l", see this diff: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=foo.patch Content-Description: foo diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm index 707f1f0929..fb1dd6c82c 100644 --- a/guix/scripts/pull.scm +++ b/guix/scripts/pull.scm @@ -142,7 +142,9 @@ (define %options result))) (option '("details") #f #f (lambda (opt name arg result) - (alist-cons 'details? #t result))) + (alist-cons 'details? #t + (cons '(query list-generations #f) + result)))) (option '("roll-back") #f #f (lambda (opt name arg result) (cons '(generation roll-back) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Because warn people that "guix pull --details" alone is not what they want adds some complexity, and when '--details' only works in tandem with the option '--list-generations', that=E2=80=99s why I propose this behaviour. Last, about this change=E2=80=A6 > - (define (no-arguments arg _=E2=80=8C) > + (define (no-arguments arg _) =E2=80=A6it a Git twist? I miss what changed=E2=80=93=E2=80=93my whitespac= e mode is badly configured? Cheers, simon --=-=-=--