From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Sergiu Ivanov <sivanov@colimite.fr>
Cc: 59352@debbugs.gnu.org
Subject: [bug#59352] [PATCH] gnu: Add emacs-org-tree-slide.
Date: Fri, 18 Nov 2022 22:24:22 +0100 [thread overview]
Message-ID: <87mt8oot15.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87v8ncbp09.fsf@colimite.fr> (Sergiu Ivanov's message of "Fri, 18 Nov 2022 10:15:02 +0100")
Hello,
Sergiu Ivanov <sivanov@colimite.fr> writes:
> Here's a patch adding emacs-org-tree-slide.
Thank you.
> It's my second Guix package ever, and I actually enjoyed following the
> instructions from the manual for building, linting and styling it. Tell
> me if I got it right :D
Almost ;) Some comments follow.
> Subject: [PATCH] gnu: Add emacs-org-tree-slide.
>
> ---
> gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
Your commit message is missing a part about the module being modified:
* gnu/packages/emacs-xyz.scm (emacs-org-tree-slide): New variable.
> +(define-public emacs-org-tree-slide
> + (package
> + (name "emacs-org-tree-slide")
> + (version "20221016.1623")
Latest version is 2.8.18, the version above is a fancy date tag from
MELPA unstable.
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://melpa.org/packages/org-tree-slide-"
> + version ".el"))
We don't use MELPA as upstream because it doesn't guarantee the tarball
will always be available. Use GitHub as upstream instead.
> + (synopsis "Emacs minor mode for giving presentations with Org-mode")
Nitpick: Org-mode -> Org mode.
> + (description
> + "This package provides the Org minor mode @code{org-tree-slide} which
> +allows for using an Org-mode document in presentations by
> +progressively revealing individual subtrees of the document.
> +org-tree-slide shows and hides parts of the Org buffer by narrowing.")
I suggest:
Org Tree Slide is a minor mode for using an Org document in
presentations by progressively revealing individual subtrees of the
document.
> + (license license:gpl3)))
License is actually gpl3+ because the license in the org-tree-slide.el
file mention "or (at your option), any later version".
Could you send an updated patch?
Well done BTW!
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2022-11-18 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 9:15 [bug#59352] [PATCH] gnu: Add emacs-org-tree-slide Sergiu Ivanov
2022-11-18 21:24 ` Nicolas Goaziou [this message]
2022-11-18 23:54 ` Sergiu Ivanov
2022-11-19 9:38 ` bug#59352: " Nicolas Goaziou
2022-11-19 11:18 ` [bug#59352] " Sergiu Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt8oot15.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=59352@debbugs.gnu.org \
--cc=sivanov@colimite.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.