From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cNyqNT74d2PXdAAAbAwnHQ (envelope-from ) for ; Fri, 18 Nov 2022 22:25:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id aGvKND74d2MN3AAAG6o9tA (envelope-from ) for ; Fri, 18 Nov 2022 22:25:18 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 89B8013522 for ; Fri, 18 Nov 2022 22:25:18 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ow8rB-0000dZ-DT; Fri, 18 Nov 2022 16:25:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow8r9-0000d5-3U for guix-patches@gnu.org; Fri, 18 Nov 2022 16:25:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ow8r8-0001rq-OW for guix-patches@gnu.org; Fri, 18 Nov 2022 16:25:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ow8r8-0008Ib-HL for guix-patches@gnu.org; Fri, 18 Nov 2022 16:25:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59352] [PATCH] gnu: Add emacs-org-tree-slide. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Nov 2022 21:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59352 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sergiu Ivanov Cc: 59352@debbugs.gnu.org Received: via spool by 59352-submit@debbugs.gnu.org id=B59352.166880668231873 (code B ref 59352); Fri, 18 Nov 2022 21:25:02 +0000 Received: (at 59352) by debbugs.gnu.org; 18 Nov 2022 21:24:42 +0000 Received: from localhost ([127.0.0.1]:38433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow8qo-0008I0-9W for submit@debbugs.gnu.org; Fri, 18 Nov 2022 16:24:42 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:52131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow8qi-0008Hi-Qb for 59352@debbugs.gnu.org; Fri, 18 Nov 2022 16:24:40 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id BC6D31C0004; Fri, 18 Nov 2022 21:24:28 +0000 (UTC) From: Nicolas Goaziou References: <87v8ncbp09.fsf@colimite.fr> Date: Fri, 18 Nov 2022 22:24:22 +0100 In-Reply-To: <87v8ncbp09.fsf@colimite.fr> (Sergiu Ivanov's message of "Fri, 18 Nov 2022 10:15:02 +0100") Message-ID: <87mt8oot15.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668806718; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=6nP3e7LA4C5WoC9BObcJF5dLgs4q7SwrpW3aHBSxWeA=; b=FiD7f2JTyich/AJOqXFzE+AHViYOhnt5phU+ptrw1vJDrPOlVkUX8lz50LAzrhaVysAMSB +9pNgkJW37msCIrgRG9Jn7zMLCgIT7juB6UYvRa9JKAf0UHde5MBGQbZjZIwmJ4sr3teEL KkeYEYSm1T+KR021kJ7/LG1USZQgeRmXxWMt3cjoGByRdOUV1QyWCzkx1gqHkkCmAXu2+G Wj9WaN4Nw4BL8Pup0VaNM0YdV9symAMQysHUXr+msxpTVAeFma/uUjWdUmzFOwY8mWa96o +HzhbC06aiFjLqFMvRxkLSXGX3cAtHXoM7C/O+cDLMptikMKc8JXlhsU2t8gpA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668806718; a=rsa-sha256; cv=none; b=FKS44a9j2s22K9wiXGEEryh9xKcOKssy68EZaauLkIIMHYoPprBxVBaMiz/7SMH9S7rXom hgMWVFY7GF4XfZ0Z2I+AUUAsC0EovjQuN6rYaUmEX7M4yuU6Eo4tloRqjfCk6cENHed2iv cPOCrw9d1sqFzUr40O/e3vaJL5AN6stcuILAGcdFO/GSGEeEI8HqdsYjFDgxbweMokfFpT 27aZSdt1mPhvo9oBBpIw854L7DE0hT0GwjR86LcbXLSxTkapjRF/sfRaH/Nc1mvyqbaT8n tX9+JXHxaKYMZUppsHrr4dkmLz/o/lMraalDMAcUKO9zw1MKTwvuPNPWko5bIg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.82 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 89B8013522 X-Spam-Score: -0.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: HV7TZI6yLFqf Hello, Sergiu Ivanov writes: > Here's a patch adding emacs-org-tree-slide. Thank you. > It's my second Guix package ever, and I actually enjoyed following the > instructions from the manual for building, linting and styling it. Tell > me if I got it right :D Almost ;) Some comments follow. > Subject: [PATCH] gnu: Add emacs-org-tree-slide. > > --- > gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++ Your commit message is missing a part about the module being modified: * gnu/packages/emacs-xyz.scm (emacs-org-tree-slide): New variable. > +(define-public emacs-org-tree-slide > + (package > + (name "emacs-org-tree-slide") > + (version "20221016.1623") Latest version is 2.8.18, the version above is a fancy date tag from MELPA unstable. > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://melpa.org/packages/org-tree-slide-" > + version ".el")) We don't use MELPA as upstream because it doesn't guarantee the tarball will always be available. Use GitHub as upstream instead. > + (synopsis "Emacs minor mode for giving presentations with Org-mode") Nitpick: Org-mode -> Org mode. > + (description > + "This package provides the Org minor mode @code{org-tree-slide} which > +allows for using an Org-mode document in presentations by > +progressively revealing individual subtrees of the document. > +org-tree-slide shows and hides parts of the Org buffer by narrowing.") I suggest: Org Tree Slide is a minor mode for using an Org document in presentations by progressively revealing individual subtrees of the document. > + (license license:gpl3))) License is actually gpl3+ because the license in the org-tree-slide.el file mention "or (at your option), any later version". Could you send an updated patch? Well done BTW! Regards, -- Nicolas Goaziou