all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#69355] [PATCH] gnu: Add libgrapheme.
@ 2024-02-24 13:24 cage
  2024-02-26 16:24 ` Maxim Cournoyer
  0 siblings, 1 reply; 5+ messages in thread
From: cage @ 2024-02-24 13:24 UTC (permalink / raw)
  To: 69355

Change-Id: If19bc5534b8bc3d0aeda4f1e70baa8d42e4948e0
---
 gnu/packages/suckless.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 81e2151854..e71b0e9252 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -1393,3 +1393,33 @@ (define-public 9base
     (description
      "This package provides ported versions of various Plan 9 userland tools
 for Unix.")))
+
+(define-public libgrapheme
+  (package
+    (name "libgrapheme")
+    (version "2.0.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://dl.suckless.org/libgrapheme/libgrapheme-"
+                           version
+                           ".tar.gz"))
+       (sha256
+        (base32 "099i2jm9c25nkbg5420wr12z0gd189gcw5j1ssjmpmbbwzfvv2x6"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:tests? #f
+           #:phases #~(modify-phases %standard-phases
+                        (add-after 'configure 'post-configure
+                          (lambda _
+                            (substitute* "config.mk"
+                              (("ldconfig") "")))))
+           #:make-flags
+           #~(list (string-append "CC=" #$(cc-for-target))
+                   (string-append "PREFIX=" #$output))))
+    (home-page "https://libs.suckless.org/libgrapheme/")
+    (synopsis "Library to handle string according to Unicode standard")
+    (description "Libgrapheme is an extremely simple freestanding C99 library
+providing utilities for properly handling strings
+according to the latest Unicode standard 15.0.0.")
+    (license license:isc)))

base-commit: de24aaf13b17d6c019f3f240fd0eb0e1b8654970
prerequisite-patch-id: aa0b913d42bee51002e7243019d5529984321e91
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#69355] [PATCH] gnu: Add libgrapheme.
  2024-02-24 13:24 [bug#69355] [PATCH] gnu: Add libgrapheme cage
@ 2024-02-26 16:24 ` Maxim Cournoyer
  2024-02-27 18:51   ` cage
  0 siblings, 1 reply; 5+ messages in thread
From: Maxim Cournoyer @ 2024-02-26 16:24 UTC (permalink / raw)
  To: cage; +Cc: 69355

Hi,

cage <cage-dev@twistfold.it> writes:

> Change-Id: If19bc5534b8bc3d0aeda4f1e70baa8d42e4948e0
> ---
>  gnu/packages/suckless.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> index 81e2151854..e71b0e9252 100644
> --- a/gnu/packages/suckless.scm
> +++ b/gnu/packages/suckless.scm
> @@ -1393,3 +1393,33 @@ (define-public 9base
>      (description
>       "This package provides ported versions of various Plan 9 userland tools
>  for Unix.")))
> +
> +(define-public libgrapheme
> +  (package
> +    (name "libgrapheme")
> +    (version "2.0.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://dl.suckless.org/libgrapheme/libgrapheme-"
> +                           version
> +                           ".tar.gz"))
> +       (sha256
> +        (base32 "099i2jm9c25nkbg5420wr12z0gd189gcw5j1ssjmpmbbwzfvv2x6"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     (list #:tests? #f

We strive to enable test suites of packages in Guix, as this gives us a
chance to detect breakage across updates.  Its page mentions a 'test'
target to run the conformance and unit tests of libgrapheme.  Did you
try it, via #:test-target "test" ?  (the default is "check", which is
most common).

> +           #:phases #~(modify-phases %standard-phases
> +                        (add-after 'configure 'post-configure
> +                          (lambda _
> +                            (substitute* "config.mk"

Please leave an explanatory comment mentioning that running ldconfig is
not needed on Guix.

> +                              (("ldconfig") "")))))
> +           #:make-flags
> +           #~(list (string-append "CC=" #$(cc-for-target))
> +                   (string-append "PREFIX=" #$output))))
> +    (home-page "https://libs.suckless.org/libgrapheme/")
> +    (synopsis "Library to handle string according to Unicode standard")
> +    (description "Libgrapheme is an extremely simple freestanding C99 library
> +providing utilities for properly handling strings
> +according to the latest Unicode standard 15.0.0.")

nitpick: The paragraph flow seems broken after 'handling strings' --
"M-;" in Emacs would help.

I'd also drop the exact Unicode standard currently targeted, as this
would probably become outdated information soon.

Could you send a v2 with the above changes?

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#69355] [PATCH] gnu: Add libgrapheme.
  2024-02-26 16:24 ` Maxim Cournoyer
@ 2024-02-27 18:51   ` cage
  2024-04-01  1:26     ` bug#69355: " Maxim Cournoyer
  0 siblings, 1 reply; 5+ messages in thread
From: cage @ 2024-02-27 18:51 UTC (permalink / raw)
  To: Maxim Cournoyer; +Cc: 69355

On Mon, Feb 26, 2024 at 11:24:42AM -0500, Maxim Cournoyer wrote:
> Hi,

Hi!

[...]

> We strive to enable test suites of packages in Guix, as this gives us a
> chance to detect breakage across updates.  Its page mentions a 'test'
> target to run the conformance and unit tests of libgrapheme.  Did you
> try it, via #:test-target "test" ?  (the default is "check", which is
> most common).

I did not  payed the right attention while reading  the README file of
the  package and  I missed  the mentions  of the  tests target  in the
makefile. ^^;

>
> > +           #:phases #~(modify-phases %standard-phases
> > +                        (add-after 'configure 'post-configure
> > +                          (lambda _
> > +                            (substitute* "config.mk"
>
> Please leave an explanatory comment mentioning that running ldconfig is
> not needed on Guix.

sure!

>
> > +                              (("ldconfig") "")))))
> > +           #:make-flags
> > +           #~(list (string-append "CC=" #$(cc-for-target))
> > +                   (string-append "PREFIX=" #$output))))
> > +    (home-page "https://libs.suckless.org/libgrapheme/")
> > +    (synopsis "Library to handle string according to Unicode standard")
> > +    (description "Libgrapheme is an extremely simple freestanding C99 library
> > +providing utilities for properly handling strings
> > +according to the latest Unicode standard 15.0.0.")
>
> nitpick: The paragraph flow seems broken after 'handling strings' --
> "M-;" in Emacs would help.

For some reasons this command does not work for me, i used to use M-q,
i hope the results is acceptable. ^^;

> I'd also drop the exact Unicode standard currently targeted, as this
> would probably become outdated information soon.

Good idea!

> Could you send a v2 with the above changes?

Sure! The new patch is attached below.

Thanks for your comments, let me know if I have addressed, or not, all the issues.
Bye!
C.

---
 gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 81e2151854..b89b3be961 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -1393,3 +1393,36 @@ (define-public 9base
     (description
      "This package provides ported versions of various Plan 9 userland tools
 for Unix.")))
+
+(define-public libgrapheme
+  (package
+    (name "libgrapheme")
+    (version "2.0.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://dl.suckless.org/libgrapheme/libgrapheme-"
+                           version
+                           ".tar.gz"))
+       (sha256
+        (base32 "099i2jm9c25nkbg5420wr12z0gd189gcw5j1ssjmpmbbwzfvv2x6"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:tests? #true
+           #:test-target "test"
+           #:phases #~(modify-phases %standard-phases
+                        (add-after 'configure 'post-configure
+                          (lambda _
+                            ;; removing call of ldconfing in makefile as it is
+                            ;; not actually needed in guix
+                            (substitute* "config.mk"
+                              (("ldconfig") "")))))
+           #:make-flags
+           #~(list (string-append "CC=" #$(cc-for-target))
+                   (string-append "PREFIX=" #$output))))
+    (home-page "https://libs.suckless.org/libgrapheme/")
+    (synopsis "Library to handle string according to Unicode standard.")
+    (description "Libgrapheme is an extremely simple freestanding C99 library
+providing utilities for properly handling strings according to the latest
+Unicode standard.")
+    (license license:isc)))

base-commit: de24aaf13b17d6c019f3f240fd0eb0e1b8654970
prerequisite-patch-id: aa0b913d42bee51002e7243019d5529984321e91
--
2.41.0




^ permalink raw reply related	[flat|nested] 5+ messages in thread

* bug#69355: [PATCH] gnu: Add libgrapheme.
  2024-02-27 18:51   ` cage
@ 2024-04-01  1:26     ` Maxim Cournoyer
  2024-04-02 16:36       ` [bug#69355] " cage
  0 siblings, 1 reply; 5+ messages in thread
From: Maxim Cournoyer @ 2024-04-01  1:26 UTC (permalink / raw)
  To: cage; +Cc: 69355-done

Hi cage,

cage <cage-dev@twistfold.it> writes:

[...]

> ---
>  gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>
> diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> index 81e2151854..b89b3be961 100644


I've added a simple commit message, as autogenerated with 'add...TAB' in
the commit message buffer in Emacs using yasnippet (you could have also
used 'etc/committer.scm').

> --- a/gnu/packages/suckless.scm
> +++ b/gnu/packages/suckless.scm
> @@ -1393,3 +1393,36 @@ (define-public 9base
>      (description
>       "This package provides ported versions of various Plan 9 userland tools
>  for Unix.")))
> +
> +(define-public libgrapheme
> +  (package
> +    (name "libgrapheme")
> +    (version "2.0.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://dl.suckless.org/libgrapheme/libgrapheme-"
> +                           version
> +                           ".tar.gz"))
> +       (sha256
> +        (base32 "099i2jm9c25nkbg5420wr12z0gd189gcw5j1ssjmpmbbwzfvv2x6"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     (list #:tests? #true
> +           #:test-target "test"
> +           #:phases #~(modify-phases %standard-phases
> +                        (add-after 'configure 'post-configure
> +                          (lambda _
> +                            ;; removing call of ldconfing in makefile as it is
> +                            ;; not actually needed in guix

I punctuated the comment (as a full sentence, starting with a capital
letter and ending with a period).

> +                            (substitute* "config.mk"
> +                              (("ldconfig") "")))))
> +           #:make-flags
> +           #~(list (string-append "CC=" #$(cc-for-target))
> +                   (string-append "PREFIX=" #$output))))
> +    (home-page "https://libs.suckless.org/libgrapheme/")
> +    (synopsis "Library to handle string according to Unicode standard.")

I've changed the synopsis to say what it *is*: "C99 library for Unicode
strings".  Note the lack of a period for the synopsis (it is not a
complete sentence -- I think 'guix lint' would have spotted that).

> +    (description "Libgrapheme is an extremely simple freestanding C99 library
> +providing utilities for properly handling strings according to the latest
> +Unicode standard.")
> +    (license license:isc)))

I've dropped 'extremely' which sounded like marketing, and pushed.

Thanks for your contribution!

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#69355] [PATCH] gnu: Add libgrapheme.
  2024-04-01  1:26     ` bug#69355: " Maxim Cournoyer
@ 2024-04-02 16:36       ` cage
  0 siblings, 0 replies; 5+ messages in thread
From: cage @ 2024-04-02 16:36 UTC (permalink / raw)
  To: Maxim Cournoyer; +Cc: 69355-done

On Sun, Mar 31, 2024 at 09:26:25PM -0400, Maxim Cournoyer wrote:
> Hi cage,

Hi!

> cage <cage-dev@twistfold.it> writes:
>
> [...]
>
> > ---
> >  gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> >
> > diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> > index 81e2151854..b89b3be961 100644
>
>
> I've added a simple commit message, as autogenerated with 'add...TAB' in
> the commit message buffer in Emacs using yasnippet (you could have also
> used 'etc/committer.scm').

Thanks  for  your suggestion,  i  tried  using  yasnippet but  with  no
luck. :( But i will try again at the next patch, i swear! :D

[...]

> Note the lack of a period for the synopsis (it is not a
> complete sentence -- I think 'guix lint' would have spotted that).

Yes, likely i did not run guix line, this time, sorry! ^^;

[...]
> I've dropped 'extremely' which sounded like marketing, and pushed.

I agree it is inappropriate here.

> Thanks for your contribution!

Thanks to you for fixing the patch!
C.




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-04-02 17:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-24 13:24 [bug#69355] [PATCH] gnu: Add libgrapheme cage
2024-02-26 16:24 ` Maxim Cournoyer
2024-02-27 18:51   ` cage
2024-04-01  1:26     ` bug#69355: " Maxim Cournoyer
2024-04-02 16:36       ` [bug#69355] " cage

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.