From: ludo@gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong@member.fsf.org>
Cc: 28756-done@debbugs.gnu.org
Subject: bug#28756: Substitute download progress bar doesn't reach 100%
Date: Tue, 17 Oct 2017 14:03:45 +0200 [thread overview]
Message-ID: <87lgkadlr2.fsf@gnu.org> (raw)
In-Reply-To: <878tgajagx.fsf@member.fsf.org> ("宋文武"'s message of "Tue, 17 Oct 2017 19:10:54 +0800")
iyzsong@member.fsf.org (宋文武) skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> iyzsong@member.fsf.org (宋文武) skribis:
>>
>>> From 6a3fa69f96fc2e3e074a9275066640ddfee57fd2 Mon Sep 17 00:00:00 2001
>>> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@member.fsf.org>
>>> Date: Sat, 14 Oct 2017 22:45:55 +0800
>>> Subject: [PATCH] guix: substitute: Report the last progress in the child
>>> process.
>>>
>>> Fixes <https://bugs.gnu.org/28756>.
>>>
>>> * guix/utils.scm (filtered-port): Close the 'input' port for the current
>>> process, and close it upon exit in the child process.
>>> * guix/scripts/substitute.scm (progress-substitution): Display "\n\n" after
>>> the reporter has finished.
>>
>> LGTM!
>>
>> You could commit the utils.scm change separately because it’s a bug-fix
>> in its own right.
>>
>
> Pushed, thanks! I think the utils.scm change alone (without the remove
> of '(close-port progress') and comment) didn't fix this particular bug
> clearly so I didn't seperate it..
Sounds reasonable. Thank you!
Ludo’.
next prev parent reply other threads:[~2017-10-17 12:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 3:52 bug#28756: Substitute download progress bar doesn't reach 100% Leo Famulari
2017-10-09 7:41 ` Ludovic Courtès
2017-10-12 14:39 ` 宋文武
2017-10-14 15:05 ` 宋文武
2017-10-15 19:33 ` Ludovic Courtès
2017-10-16 13:06 ` 宋文武
2017-10-17 7:16 ` Ludovic Courtès
2017-10-17 11:10 ` 宋文武
2017-10-17 12:03 ` Ludovic Courtès [this message]
[not found] ` <handler.28756.D28756.150823866318807.notifdone@debbugs.gnu.org>
2017-10-30 14:30 ` bug#28756: closed (Re: bug#28756: Substitute download progress bar doesn't reach 100%) Leo Famulari
2017-10-30 16:37 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgkadlr2.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=28756-done@debbugs.gnu.org \
--cc=iyzsong@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.