From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#28756: Substitute download progress bar doesn't reach 100%
Date: Tue, 17 Oct 2017 14:03:45 +0200
Message-ID: <87lgkadlr2.fsf@gnu.org>
References: <20171009035203.GA8019@jasmine.lan> <87efqcahur.fsf@gnu.org>
	<87infkv3ai.fsf@member.fsf.org> <87y3od93dg.fsf@member.fsf.org>
	<87lgkcuryg.fsf@gnu.org> <87d15nmedj.fsf@member.fsf.org>
	<877evufdll.fsf@gnu.org> <878tgajagx.fsf@member.fsf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36125)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e4QbQ-0002Aq-O6
	for bug-guix@gnu.org; Tue, 17 Oct 2017 08:04:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e4QbK-0001Bi-S5
	for bug-guix@gnu.org; Tue, 17 Oct 2017 08:04:08 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:36299)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e4QbK-0001Be-PJ
	for bug-guix@gnu.org; Tue, 17 Oct 2017 08:04:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e4QbK-00083F-Gv
	for bug-guix@gnu.org; Tue, 17 Oct 2017 08:04:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.28756.D28756.150824183130933@debbugs.gnu.org>
In-Reply-To: <878tgajagx.fsf@member.fsf.org>
	("=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?="'s message of "Tue,
	17 Oct 2017 19:10:54 +0800")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@member.fsf.org>
Cc: 28756-done@debbugs.gnu.org

iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis:

> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>
>> iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis:
>>
>>> From 6a3fa69f96fc2e3e074a9275066640ddfee57fd2 Mon Sep 17 00:00:00 2001
>>> From: =3D?UTF-8?q?=3DE5=3DAE=3D8B=3DE6=3D96=3D87=3DE6=3DAD=3DA6?=3D <iy=
zsong@member.fsf.org>
>>> Date: Sat, 14 Oct 2017 22:45:55 +0800
>>> Subject: [PATCH] guix: substitute: Report the last progress in the child
>>>  process.
>>>
>>> Fixes <https://bugs.gnu.org/28756>.
>>>
>>> * guix/utils.scm (filtered-port): Close the 'input' port for the current
>>> process, and close it upon exit in the child process.
>>> * guix/scripts/substitute.scm (progress-substitution): Display "\n\n" a=
fter
>>> the reporter has finished.
>>
>> LGTM!
>>
>> You could commit the utils.scm change separately because it=E2=80=99s a =
bug-fix
>> in its own right.
>>
>
> Pushed, thanks!  I think the utils.scm change alone (without the remove
> of '(close-port progress') and comment) didn't fix this particular bug
> clearly so I didn't seperate it..

Sounds reasonable.  Thank you!

Ludo=E2=80=99.